From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Jens Axboe To: linux-block@vger.kernel.org Cc: osandov@fb.com, efault@gmx.de, paolo.valente@linaro.org, Jens Axboe Subject: [PATCH 6/9] sbitmap: warn if using smaller shallow depth than was setup Date: Thu, 10 May 2018 10:24:24 -0600 Message-Id: <1525969467-12476-7-git-send-email-axboe@kernel.dk> In-Reply-To: <1525969467-12476-1-git-send-email-axboe@kernel.dk> References: <1525969467-12476-1-git-send-email-axboe@kernel.dk> List-ID: From: Omar Sandoval Make sure the user passed the right value to sbitmap_queue_min_shallow_depth(). Acked-by: Paolo Valente Signed-off-by: Omar Sandoval Signed-off-by: Jens Axboe --- lib/sbitmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/sbitmap.c b/lib/sbitmap.c index d21473b42465..8f0950fbaa5c 100644 --- a/lib/sbitmap.c +++ b/lib/sbitmap.c @@ -402,6 +402,8 @@ int __sbitmap_queue_get_shallow(struct sbitmap_queue *sbq, unsigned int hint, depth; int nr; + WARN_ON_ONCE(shallow_depth < sbq->min_shallow_depth); + hint = this_cpu_read(*sbq->alloc_hint); depth = READ_ONCE(sbq->sb.depth); if (unlikely(hint >= depth)) { -- 2.7.4