From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Matthew Garrett <mjg59@google.com>, linux-integrity@vger.kernel.org
Subject: Re: [PATCH V4 1/2] EVM: turn evm_config_xattrnames into a list
Date: Fri, 11 May 2018 00:03:24 -0400 [thread overview]
Message-ID: <1526011404.3414.4.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180509202811.29875-1-mjg59@google.com>
On Wed, 2018-05-09 at 13:28 -0700, Matthew Garrett wrote:
> @@ -565,10 +588,11 @@ static int __init init_evm(void)
> */
> static int __init evm_display_config(void)
> {
> - char **xattrname;
> + struct xattr_list *xattr;
> +
> + list_for_each_entry(xattr, &evm_config_xattrnames, list)
> + pr_info("%s\n", xattr->name);
>
> - for (xattrname = evm_config_xattrnames; *xattrname != NULL; xattrname++)
> - pr_info("%s\n", *xattrname);
> return 0;
> }
>
The list is only created in init_evm(), which is initialized at
late_initcall(), yet here we're displaying the list at
pure_initcall(). None of the xattrs are being displayed.
Mimi
prev parent reply other threads:[~2018-05-11 4:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 20:28 [PATCH V4 1/2] EVM: turn evm_config_xattrnames into a list Matthew Garrett
2018-05-09 20:28 ` [PATCH V4 2/2] EVM: Allow runtime modification of the set of verified xattrs Matthew Garrett
2018-05-10 18:14 ` James Morris
2018-05-11 4:41 ` Mimi Zohar
2018-05-11 19:51 ` Matthew Garrett
2018-05-11 20:05 ` Mimi Zohar
2018-05-11 16:58 ` Mimi Zohar
2018-05-10 18:13 ` [PATCH V4 1/2] EVM: turn evm_config_xattrnames into a list James Morris
2018-05-11 4:03 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526011404.3414.4.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.