From: pawel.moll@arm.com (Pawel Moll)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers/perf: arm-ccn: stop spamming dmesg in event_init
Date: Fri, 11 May 2018 14:16:50 +0100 [thread overview]
Message-ID: <1526044610.3315.93.camel@arm.com> (raw)
In-Reply-To: <cee9c043-3d64-56b9-4f23-e8c8370387dd@gmail.com>
On Thu, 2018-05-10 at 01:22 +0100, Florian Fainelli wrote:
> I don't have any dog in this, but maybe if providing information to
> the
> users is so essential to having a pleasant user experience, then
> rethinking the whole way these messages are funneled is necessary
> because the kernel log + dmesg is by no means appropriate. Take a look
> at what the networking maintainers recently did with netlink extended
> ack. You used to just get an "unsupported" error, and now you know
> exactly what is wrong when extack is available. It seems to me like
> something like this is what you might want here since you want to have
> perf be as user friendly as possible.
>
> My 2 cents.
I couldn't agree more. I find the advice "check the dmesg, you may find
something there" that perf tool uses currently... well, pretty lame
(although this was exactly the reason I started dmesg-ing error details
in the first place).
One could play the "you're breaking userspace promise" card here, but
considering that the number of people actually using CCN PMU is...
small, I don't want to do this.
But so far no one was determined enough to get better error reporting
in place. I have ran out of time when I tried it 2 or 3 years ago, I
believe Kim has discussed some approaches and received pushback. Kim
would be better suited to summarize what has happened so far...
Regards
Pawe?
next prev parent reply other threads:[~2018-05-11 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 10:41 [PATCH] drivers/perf: arm-ccn: stop spamming dmesg in event_init Mark Rutland
2018-05-08 23:40 ` Kim Phillips
2018-05-09 16:06 ` Pawel Moll
2018-05-09 16:12 ` Mark Rutland
2018-05-10 0:02 ` Kim Phillips
2018-05-11 13:12 ` Pawel Moll
2018-05-09 23:41 ` Kim Phillips
2018-05-10 0:22 ` Florian Fainelli
2018-05-11 13:16 ` Pawel Moll [this message]
2018-05-17 0:25 ` Kim Phillips
2018-05-17 0:25 ` Kim Phillips
2018-05-17 15:07 ` Matt Sealey
2018-05-17 15:07 ` Matt Sealey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526044610.3315.93.camel@arm.com \
--to=pawel.moll@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.