All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] ndctl: remove warning caused by -D_FORTIFY_SOURCE=2 and -O0 compile flags
Date: Fri, 11 May 2018 16:22:45 +0000	[thread overview]
Message-ID: <1526055764.4429.12.camel@intel.com> (raw)
In-Reply-To: <1526055265.4429.10.camel@intel.com>

On Fri, 2018-05-11 at 16:15 +0000, Verma, Vishal L wrote:
> On Fri, 2018-05-11 at 09:03 -0700, Dan Williams wrote:
> > On Fri, May 11, 2018 at 9:00 AM, Verma, Vishal L
> > <vishal.l.verma@intel.com> wrote:
> > > On Thu, 2018-05-10 at 16:47 -0700, Dave Jiang wrote:
> > > > Compiler spits out warning with -D_FORTIFY_SOURCE=2 and -O0. Moving
> > > > to
> > > > -O2
> > > > to remove warnings.
> > > > 
> > > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > > > ---
> > > >  README.md  |    2 +-
> > > >  autogen.sh |    2 +-
> > > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/README.md b/README.md
> > > > index 899dcbb8..e0bc5b7b 100644
> > > > --- a/README.md
> > > > +++ b/README.md
> > > > @@ -6,7 +6,7 @@ sub-system in the Linux kernel
> > > >  Build
> > > >  =====
> > > >  `./autogen.sh`
> > > > -`./configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --
> > > > libdir=/usr/lib64`
> > > > +`./configure CFLAGS='-g -O2' --prefix=/usr --sysconfdir=/etc --
> > > > libdir=/usr/lib64`
> > > >  `make`
> > > >  `make check`
> > > >  `sudo make install`
> > > > diff --git a/autogen.sh b/autogen.sh
> > > > index a23cf53c..2a52688b 100755
> > > > --- a/autogen.sh
> > > > +++ b/autogen.sh
> > > > @@ -24,5 +24,5 @@ echo "-------------------------------------------
> > > > --
> > > > ----
> > > > ---------------"
> > > >  echo "Initialized build system. For a common configuration please
> > > > run:"
> > > >  echo "------------------------------------------------------------
> > > > ----"
> > > >  echo
> > > > -echo "./configure CFLAGS='-g -O0' $args"
> > > > +echo "./configure CFLAGS='-g -O2' $args"
> > > >  echo
> > > 
> > > Should we also add -O2 to my_CFLAGS in configure.ac, or leave that to
> > > the
> > > user?
> > 
> > Hmm, does it get in the way of the distro specified CFLAGS?
> 
> rpmbuild CFLAGS seem to add to the ones specified here. Not sure what
> would
> happen if both -O1 and -O2 were present for example..

>From the gcc manual,

	If you use multiple -O options, with or without level numbers,
	the last such option is the one that is effective.

So the distro CFLAGS should append to/override anything we specify in
my_CFLAGS.

> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-05-11 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 23:47 [PATCH] ndctl: remove warning caused by -D_FORTIFY_SOURCE=2 and -O0 compile flags Dave Jiang
2018-05-11 16:00 ` Verma, Vishal L
2018-05-11 16:03   ` Dan Williams
2018-05-11 16:15     ` Verma, Vishal L
2018-05-11 16:22       ` Verma, Vishal L [this message]
2018-05-11 16:25         ` Dan Williams
  -- strict thread matches above, loose matches on Subject: below --
2018-05-11 16:49 Dave Jiang
2018-05-11 18:02 ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526055764.4429.12.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.