From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 2/9] drm/i915/psr: Move PSR exit specific code to hardware specific function Date: Tue, 15 May 2018 17:42:14 -0700 Message-ID: <1526431334.17473.111.camel@intel.com> References: <20180418224311.16577-1-jose.souza@intel.com> <20180418224311.16577-2-jose.souza@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CA026E26E for ; Wed, 16 May 2018 00:16:53 +0000 (UTC) In-Reply-To: <20180418224311.16577-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTA0LTE4IGF0IDE1OjQzIC0wNzAwLCBKb3PDqSBSb2JlcnRvIGRlIFNvdXph IHdyb3RlOgo+IFRvIHByb3BlciBleGVjdXRlIFBTUiBleGl0IGl0IHdhcyB1c2luZyAnaWYgKEhB U19EREkoZGV2X3ByaXYpKScgdG8KPiBkaWZmZXJlbnRpYXRlIGJldHdlZW4gVkxWL0NIViBhbmQg SFNXKyBoYXJkd2FyZSwgc28gaGVyZSBtb3ZpbmcgZWFjaAo+IGhhcmR3YXJlIGhhbmRsaW5nIHRv IGhpcyBvd24gZnVuY3Rpb24uCgpXaGVuwqBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5v cmcvcGF0Y2gvMjIyMjMwL8KgbGFuZHMsIHdlIGRvbid0CmhhdmUgdG8gd29ycnkgYWJvdXQgdGhp cyA6KQo+IAo+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291 emFAaW50ZWwuY29tPgo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRp eWFuQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlA aW50ZWwuY29tPgo+IC0tLQo+IAo+IE5vIGNoYW5nZXMgZnJvbSB2MS4KPiAKPiDCoGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmjCoMKgfMKgwqAxICsKPiDCoGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3Bzci5jIHwgOTQgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gLS0K PiDCoDIgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgMzkgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA4ZTg2NjdkOWIwODQuLjQ3NmJjYTg3 MmQ0OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC02MTcsNiArNjE3LDcgQEAg c3RydWN0IGk5MTVfcHNyIHsKPiDCoAl2b2lkICgqZW5hYmxlX3NpbmspKHN0cnVjdCBpbnRlbF9k cCAqKTsKPiDCoAl2b2lkICgqYWN0aXZhdGUpKHN0cnVjdCBpbnRlbF9kcCAqKTsKPiDCoAl2b2lk ICgqc2V0dXBfdnNjKShzdHJ1Y3QgaW50ZWxfZHAgKiwgY29uc3Qgc3RydWN0Cj4gaW50ZWxfY3J0 Y19zdGF0ZSAqKTsKPiArCXZvaWQgKCpleGl0KShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKTsK PiDCoH07Cj4gwqAKPiDCoGVudW0gaW50ZWxfcGNoIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bz ci5jCj4gaW5kZXggNjU5MTgwNjU2ZjViLi5lYmM0N2UyYjA4Y2EgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wc3IuYwo+IEBAIC04NDQsNTMgKzg0NCw2NyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9w c3Jfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QKPiAqd29yaykKPiDCoAltdXRleF91bmxvY2soJmRl dl9wcml2LT5wc3IubG9jayk7Cj4gwqB9Cj4gwqAKPiAtc3RhdGljIHZvaWQgaW50ZWxfcHNyX2V4 aXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgdm9pZCBoc3df cHNyX2V4aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiDCoHsKPiAtCXN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAgPSBkZXZfcHJpdi0+cHNyLmVuYWJsZWQ7Cj4gLQlzdHJ1Y3QgZHJtX2Ny dGMgKmNydGMgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCktCj4gPmJhc2UuYmFzZS5jcnRjOwo+ ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPQo+IGRwX3RvX2RpZ19wb3J0 KGludGVsX2RwKTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdfcG9ydC0+YmFzZS5i YXNlLmRldjsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUo ZGV2KTsKPiArCXUzMiB2YWw7Cj4gKwo+ICsJaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVk KSB7Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCk7Cj4gKwkJV0FSTl9PTighKHZh bCAmIEVEUF9QU1IyX0VOQUJMRSkpOwo+ICsJCUk5MTVfV1JJVEUoRURQX1BTUjJfQ1RMLCB2YWwg JiB+RURQX1BTUjJfRU5BQkxFKTsKPiArCX0gZWxzZSB7Cj4gKwkJdmFsID0gSTkxNV9SRUFEKEVE UF9QU1JfQ1RMKTsKPiArCQlXQVJOX09OKCEodmFsICYgRURQX1BTUl9FTkFCTEUpKTsKPiArCQlJ OTE1X1dSSVRFKEVEUF9QU1JfQ1RMLCB2YWwgJiB+RURQX1BTUl9FTkFCTEUpOwo+ICsJfQo+ICt9 Cj4gKwo+ICtzdGF0aWMgdm9pZCB2bHZfcHNyX2V4aXQoc3RydWN0IGludGVsX2RwICppbnRlbF9k cCkKPiArewo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPQo+IGRwX3Rv X2RpZ19wb3J0KGludGVsX2RwKTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdfcG9y dC0+YmFzZS5iYXNlLmRldjsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IGRpZ19wb3J0LT5iYXNl LmJhc2UuY3J0YzsKPiDCoAllbnVtIHBpcGUgcGlwZSA9IHRvX2ludGVsX2NydGMoY3J0YyktPnBp cGU7Cj4gwqAJdTMyIHZhbDsKPiDCoAo+IC0JaWYgKCFkZXZfcHJpdi0+cHNyLmFjdGl2ZSkKPiAt CQlyZXR1cm47Cj4gKwl2YWwgPSBJOTE1X1JFQUQoVkxWX1BTUkNUTChwaXBlKSk7Cj4gwqAKPiAt CWlmIChIQVNfRERJKGRldl9wcml2KSkgewo+IC0JCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5h YmxlZCkgewo+IC0JCQl2YWwgPSBJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKTsKPiAtCQkJV0FSTl9P TighKHZhbCAmIEVEUF9QU1IyX0VOQUJMRSkpOwo+IC0JCQlJOTE1X1dSSVRFKEVEUF9QU1IyX0NU TCwgdmFsICYKPiB+RURQX1BTUjJfRU5BQkxFKTsKPiAtCQl9IGVsc2Ugewo+IC0JCQl2YWwgPSBJ OTE1X1JFQUQoRURQX1BTUl9DVEwpOwo+IC0JCQlXQVJOX09OKCEodmFsICYgRURQX1BTUl9FTkFC TEUpKTsKPiAtCQkJSTkxNV9XUklURShFRFBfUFNSX0NUTCwgdmFsICYKPiB+RURQX1BTUl9FTkFC TEUpOwo+IC0JCX0KPiAtCX0gZWxzZSB7Cj4gLQkJdmFsID0gSTkxNV9SRUFEKFZMVl9QU1JDVEwo cGlwZSkpOwo+ICsJLyoKPiArCcKgKiBIZXJlIHdlIGRvIHRoZSB0cmFuc2l0aW9uIGRyaXJlY3Rs eSBmcm9tCj4gKwnCoCogUFNSX3N0YXRlIDMgKGFjdGl2ZSAtIG5vIFJlbW90ZSBGcmFtZSBCdWZm ZXIgKFJGQikKPiB1cGRhdGUpIHRvCj4gKwnCoCogUFNSX3N0YXRlIDUgKGV4aXQpLgo+ICsJwqAq IFBTUiBTdGF0ZSA0IChhY3RpdmUgd2l0aCBzaW5nbGUgZnJhbWUgdXBkYXRlKSBjYW4gYmUKPiBz a2lwcGVkLgo+ICsJwqAqIE9uIFBTUl9zdGF0ZSA1IChleGl0KSBIYXJkd2FyZSBpcyByZXNwb25z aWJsZSB0bwo+IHRyYW5zaXRpb24KPiArCcKgKiBiYWNrIHRvIFBTUl9zdGF0ZSAxIChpbmFjdGl2 ZSkuCj4gKwnCoCogTm93IHdlIGFyZSBhdCBTYW1lIHN0YXRlIGFmdGVyIHZsdl9wc3JfZW5hYmxl X3NvdXJjZS4KPiArCcKgKi8KPiArCXZhbCAmPSB+VkxWX0VEUF9QU1JfQUNUSVZFX0VOVFJZOwo+ ICsJSTkxNV9XUklURShWTFZfUFNSQ1RMKHBpcGUpLCB2YWwpOwo+IMKgCj4gLQkJLyoKPiAtCQnC oCogSGVyZSB3ZSBkbyB0aGUgdHJhbnNpdGlvbiBkcmlyZWN0bHkgZnJvbQo+IC0JCcKgKiBQU1Jf c3RhdGUgMyAoYWN0aXZlIC0gbm8gUmVtb3RlIEZyYW1lIEJ1ZmZlcgo+IChSRkIpIHVwZGF0ZSkg dG8KPiAtCQnCoCogUFNSX3N0YXRlIDUgKGV4aXQpLgo+IC0JCcKgKiBQU1IgU3RhdGUgNCAoYWN0 aXZlIHdpdGggc2luZ2xlIGZyYW1lIHVwZGF0ZSkgY2FuCj4gYmUgc2tpcHBlZC4KPiAtCQnCoCog T24gUFNSX3N0YXRlIDUgKGV4aXQpIEhhcmR3YXJlIGlzIHJlc3BvbnNpYmxlIHRvCj4gdHJhbnNp dGlvbgo+IC0JCcKgKiBiYWNrIHRvIFBTUl9zdGF0ZSAxIChpbmFjdGl2ZSkuCj4gLQkJwqAqIE5v dyB3ZSBhcmUgYXQgU2FtZSBzdGF0ZSBhZnRlcgo+IHZsdl9wc3JfZW5hYmxlX3NvdXJjZS4KPiAt CQnCoCovCj4gLQkJdmFsICY9IH5WTFZfRURQX1BTUl9BQ1RJVkVfRU5UUlk7Cj4gLQkJSTkxNV9X UklURShWTFZfUFNSQ1RMKHBpcGUpLCB2YWwpOwo+ICsJLyoKPiArCcKgKiBTZW5kIEFVWCB3YWtl IHVwIC0gU3BlYyBzYXlzIGFmdGVyIHRyYW5zaXRpb25pbmcgdG8gUFNSCj4gKwnCoCogYWN0aXZl IHdlIGhhdmUgdG8gc2VuZCBBVVggd2FrZSB1cCBieSB3cml0aW5nIDAxaCBpbiBEUENECj4gKwnC oCogNjAwaCBvZiBzaW5rIGRldmljZS4KPiArCcKgKiBYWFg6IFRoaXMgbWlnaHQgc2xvdyBkb3du IHRoZSB0cmFuc2l0aW9uLCBidXQgd2l0aG91dAo+IHRoaXMKPiArCcKgKiBIVyBkb2Vzbid0IGNv bXBsZXRlIHRoZSB0cmFuc2l0aW9uIHRvIFBTUl9zdGF0ZSAxIGFuZCB3ZQo+ICsJwqAqIG5ldmVy IGdldCB0aGUgc2NyZWVuIHVwZGF0ZWQuCj4gKwnCoCovCj4gKwlkcm1fZHBfZHBjZF93cml0ZWIo JmludGVsX2RwLT5hdXgsIERQX1NFVF9QT1dFUiwKPiArCQkJwqDCoMKgRFBfU0VUX1BPV0VSX0Qw KTsKPiArfQo+IMKgCj4gLQkJLyoKPiAtCQnCoCogU2VuZCBBVVggd2FrZSB1cCAtIFNwZWMgc2F5 cyBhZnRlciB0cmFuc2l0aW9uaW5nCj4gdG8gUFNSCj4gLQkJwqAqIGFjdGl2ZSB3ZSBoYXZlIHRv IHNlbmQgQVVYIHdha2UgdXAgYnkgd3JpdGluZyAwMWgKPiBpbiBEUENECj4gLQkJwqAqIDYwMGgg b2Ygc2luayBkZXZpY2UuCj4gLQkJwqAqIFhYWDogVGhpcyBtaWdodCBzbG93IGRvd24gdGhlIHRy YW5zaXRpb24sIGJ1dAo+IHdpdGhvdXQgdGhpcwo+IC0JCcKgKiBIVyBkb2Vzbid0IGNvbXBsZXRl IHRoZSB0cmFuc2l0aW9uIHRvIFBTUl9zdGF0ZSAxCj4gYW5kIHdlCj4gLQkJwqAqIG5ldmVyIGdl dCB0aGUgc2NyZWVuIHVwZGF0ZWQuCj4gLQkJwqAqLwo+IC0JCWRybV9kcF9kcGNkX3dyaXRlYigm aW50ZWxfZHAtPmF1eCwgRFBfU0VUX1BPV0VSLAo+IC0JCQkJwqDCoMKgRFBfU0VUX1BPV0VSX0Qw KTsKPiAtCX0KPiArc3RhdGljIHZvaWQgaW50ZWxfcHNyX2V4aXQoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gZGV2 X3ByaXYtPnBzci5lbmFibGVkOwo+ICsKPiArCWlmICghZGV2X3ByaXYtPnBzci5hY3RpdmUpCj4g KwkJcmV0dXJuOwo+IMKgCj4gKwlkZXZfcHJpdi0+cHNyLmV4aXQoaW50ZWxfZHApOwo+IMKgCWRl dl9wcml2LT5wc3IuYWN0aXZlID0gZmFsc2U7Cj4gwqB9Cj4gwqAKPiBAQCAtMTEwMCw2ICsxMTE0 LDcgQEAgdm9pZCBpbnRlbF9wc3JfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ICpkZXZf cHJpdikKPiDCoAkJZGV2X3ByaXYtPnBzci5lbmFibGVfc2luayA9IHZsdl9wc3JfZW5hYmxlX3Np bms7Cj4gwqAJCWRldl9wcml2LT5wc3IuYWN0aXZhdGUgPSB2bHZfcHNyX2FjdGl2YXRlOwo+IMKg CQlkZXZfcHJpdi0+cHNyLnNldHVwX3ZzYyA9IHZsdl9wc3Jfc2V0dXBfdnNjOwo+ICsJCWRldl9w cml2LT5wc3IuZXhpdCA9IHZsdl9wc3JfZXhpdDsKPiDCoAl9IGVsc2Ugewo+IMKgCQlkZXZfcHJp di0+cHNyLmhhc19od190cmFja2luZyA9IHRydWU7Cj4gwqAJCWRldl9wcml2LT5wc3IuZW5hYmxl X3NvdXJjZSA9IGhzd19wc3JfZW5hYmxlX3NvdXJjZTsKPiBAQCAtMTEwNyw1ICsxMTIyLDYgQEAg dm9pZCBpbnRlbF9wc3JfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ICpkZXZfcHJpdikK PiDCoAkJZGV2X3ByaXYtPnBzci5lbmFibGVfc2luayA9IGhzd19wc3JfZW5hYmxlX3Npbms7Cj4g wqAJCWRldl9wcml2LT5wc3IuYWN0aXZhdGUgPSBoc3dfcHNyX2FjdGl2YXRlOwo+IMKgCQlkZXZf cHJpdi0+cHNyLnNldHVwX3ZzYyA9IGhzd19wc3Jfc2V0dXBfdnNjOwo+ICsJCWRldl9wcml2LT5w c3IuZXhpdCA9IGhzd19wc3JfZXhpdDsKPiDCoAl9Cj4gwqB9Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=