All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <jjohnson@codeaurora.org>,
	Dedy Lansky <dlansky@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event
Date: Thu, 17 May 2018 21:29:05 +0200	[thread overview]
Message-ID: <1526585345.5351.3.camel@sipsolutions.net> (raw)
In-Reply-To: <a19275473776283a94997b8f5436f3b9@codeaurora.org> (sfid-20180517_204322_111043_9C68DA25)

On Thu, 2018-05-17 at 11:43 -0700, Jeff Johnson wrote:
> 
> > -	msg = nlmsg_new(100 + ft_event->ric_ies_len, GFP_KERNEL);
> > +	msg = nlmsg_new(100 + ft_event->ies_len + ft_event->ric_ies_len,
> > +			GFP_KERNEL);
> >  	if (!msg)
> >  		return;
> 
> should these really be nla_total_size(ft_event->ies_len) + 
> nla_total_size(ft_event->ric_ies_len) to properly account for the NLA 
> header + padding? or do we consider that to be noise captured by the 
> "100"?

We do, technically we should have something like nla_total_size() of
various things including all those wiphy, ifindex, MAC attributes etc.
so we just get lazy...

johannes

  reply	other threads:[~2018-05-17 19:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 13:25 [PATCH] nl80211: fix nlmsg allocation in cfg80211_ft_event Dedy Lansky
2018-05-17 18:43 ` Jeff Johnson
2018-05-17 19:29   ` Johannes Berg [this message]
2018-05-21  7:23     ` Dedy Lansky
2018-05-22  9:00       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526585345.5351.3.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=dlansky@codeaurora.org \
    --cc=jjohnson@codeaurora.org \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.