From: Matt Mullins <mmullins@fb.com>
To: "davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Dave Watson <davejwatson@fb.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"aviadye@mellanox.com" <aviadye@mellanox.com>,
Doron Roberts-Kedes <doronrk@fb.com>
Subject: Re: [PATCH net] tls: don't use stack memory in a scatterlist
Date: Thu, 17 May 2018 20:28:46 +0000 [thread overview]
Message-ID: <1526588924.24138.2.camel@fb.com> (raw)
In-Reply-To: <20180517.145056.1635507477734784563.davem@davemloft.net>
On Thu, 2018-05-17 at 14:50 -0400, David Miller wrote:
> I'm surprised this problem wasn't discovered sooner. How exactly did you
> discover it? Did you actually see it trigger or is this purely from code
> inspection?
Honestly, I'm not sure how it got uncovered, but it was observed at
runtime. Doron Roberts-Kedes hit a null pointer dereference so we
turned on CONFIG_DEBUG_SG -- then it became a proper
BUG_ON(!virt_addr_valid(buf)); in sg_set_buf.
next prev parent reply other threads:[~2018-05-17 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 17:48 [PATCH net] tls: don't use stack memory in a scatterlist Matt Mullins
2018-05-17 18:50 ` David Miller
2018-05-17 20:28 ` Matt Mullins [this message]
2018-05-17 20:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526588924.24138.2.camel@fb.com \
--to=mmullins@fb.com \
--cc=aviadye@mellanox.com \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=doronrk@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.