From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RESEND PATCH] cfg80211: dynamically allocate per-tid stats for station info
Date: Fri, 18 May 2018 11:38:15 +0200 [thread overview]
Message-ID: <1526636295.3805.10.camel@sipsolutions.net> (raw)
In-Reply-To: <5AFE9ECE.50306@broadcom.com> (sfid-20180518_113721_333172_594E80B6)
On Fri, 2018-05-18 at 11:37 +0200, Arend van Spriel wrote:
> On 5/18/2018 11:25 AM, Johannes Berg wrote:
> > On Thu, 2018-05-10 at 13:50 +0200, Arend van Spriel wrote:
> > >
> > > Here an alternative approach. Currently the only cfg80211-based driver
> > > providing per-tid stats is mac80211. This patch only changes mac80211
> > > and the other driver can keep using stack allocation. Even mac80211 could
> > > if wanted, but I left that part as is.
> >
> > I decided to take this and remove the BIT() thing entirely (you had a
> > bug there anyway)
>
> I figured you would drop this one. The error paths may need to do kfree
> here and there. Kalle took dynamic alloc fixes in driver already so my
> patch is not really needed right now.
Heh. I asked Kalle if he wanted to revert, but I decided that for the
single user in mac80211 it wasn't worth the hassle of doing the dynamic
allocations all over the place.
I'll look at the error paths I guess.
johannes
prev parent reply other threads:[~2018-05-18 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5AF430B2.2060903@broadcom.com>
2018-05-10 11:50 ` [RESEND PATCH] cfg80211: dynamically allocate per-tid stats for station info Arend van Spriel
2018-05-10 13:02 ` Toke Høiland-Jørgensen
2018-05-18 9:25 ` Johannes Berg
2018-05-18 9:37 ` Arend van Spriel
2018-05-18 9:38 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526636295.3805.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.