From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: Tarun Vyas <tarun.vyas@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/6] drm/i915/psr: Fix ALPM cap check for PSR2
Date: Tue, 22 May 2018 13:21:22 -0700 [thread overview]
Message-ID: <1527020482.2226.17.camel@intel.com> (raw)
In-Reply-To: <20180522143750.GA138318@otc-chromeosbuild-5>
On Tue, 2018-05-22 at 07:37 -0700, Tarun Vyas wrote:
> On Fri, May 11, 2018 at 12:51:45PM -0700, Dhinakaran Pandiyan wrote:
> >
> > While touching the code around this, I noticed that absence of ALPM
> > capability does not stop us from enabling PSR2. But, the spec
> > unambiguously states that ALPM is required for PSR2 and so does
> > this
> > commit that introduced this code
> >
> > drm/i915/psr: enable ALPM for psr2
> >
> > As per edp1.4 spec , alpm is required for psr2 operation as
> > it's
> > used for all psr2 main link power down management and alpm
> > enable
> > bit must be set for psr2 operation.
> >
> Since, the code introduced by "drm/i915/psr: enable ALPM for psr2"
> enables PSR2 even if ALPM isn't supported, can we add the "Fixes" tag
> here ?
I thought about it. I don't think PSR2 was enabled upstream by default,
so we should be good without Fixes. And I didn't investigate if the
original commit missed the ALPM check or if it was mangled later.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-22 19:56 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 19:51 [PATCH 1/6] drm/i915/psr: Avoid DPCD reads when panel does not support PSR Dhinakaran Pandiyan
2018-05-11 19:51 ` [PATCH 2/6] drm/i915/psr: Check for SET_POWER_CAPABLE bit at PSR init time Dhinakaran Pandiyan
2018-05-11 22:14 ` Dhinakaran Pandiyan
2018-05-24 13:28 ` Jani Nikula
2018-05-11 19:51 ` [PATCH 3/6] drm/psr: Fix missed entry in PSR setup time table Dhinakaran Pandiyan
2018-05-24 14:00 ` Jani Nikula
2018-05-24 14:00 ` Jani Nikula
2018-05-11 19:51 ` [PATCH 4/6] drm/i915/psr: Avoid unnecessary DPCD read of DP_PSR_CAPS Dhinakaran Pandiyan
2018-05-20 23:01 ` Tarun Vyas
2018-05-24 14:01 ` Jani Nikula
2018-05-22 12:32 ` Nagaraju, Vathsala
2018-05-11 19:51 ` [PATCH 5/6] drm/i915/psr: Fall back to max. synchronization latency if DPCD read fails Dhinakaran Pandiyan
2018-05-21 23:58 ` Souza, Jose
2018-05-11 19:51 ` [PATCH 6/6] drm/i915/psr: Fix ALPM cap check for PSR2 Dhinakaran Pandiyan
2018-05-22 9:33 ` Nagaraju, Vathsala
2018-05-22 14:37 ` Tarun Vyas
2018-05-22 20:21 ` Dhinakaran Pandiyan [this message]
2018-05-11 20:26 ` ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/psr: Avoid DPCD reads when panel does not support PSR Patchwork
2018-05-11 21:17 ` ✓ Fi.CI.IGT: " Patchwork
2018-05-18 0:27 ` [PATCH 1/6] " Tarun Vyas
2018-05-21 23:40 ` Dhinakaran Pandiyan
2018-05-24 13:29 ` Jani Nikula
2018-05-22 12:29 ` Nagaraju, Vathsala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527020482.2226.17.camel@intel.com \
--to=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tarun.vyas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.