From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mimi Zohar Subject: Re: [PATCH 5/8] integrity: Add exe= and tty= before res= to integrity audits Date: Wed, 30 May 2018 09:04:40 -0400 Message-ID: <1527685480.3534.54.camel@linux.vnet.ibm.com> References: <20180524201105.3179904-1-stefanb@linux.vnet.ibm.com> <20180524201105.3179904-6-stefanb@linux.vnet.ibm.com> <4331521.GQBdaJNAj6@x2> <1527634686.3534.27.camel@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1527634686.3534.27.camel@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Moore , Steve Grubb , Stefan Berger Cc: linux-integrity@vger.kernel.org, linux-audit@redhat.com, linux-kernel@vger.kernel.org List-Id: linux-audit@redhat.com On Tue, 2018-05-29 at 18:58 -0400, Mimi Zohar wrote: > On Tue, 2018-05-29 at 17:47 -0400, Paul Moore wrote: > > On Tue, May 29, 2018 at 5:35 PM, Steve Grubb wrote: > > > On Tuesday, May 29, 2018 5:19:39 PM EDT Paul Moore wrote: > > >> On Thu, May 24, 2018 at 4:11 PM, Stefan Berger > > >> > > >> wrote: > > >> > Use the new public audit functions to add the exe= and tty= > > >> > parts to the integrity audit records. We place them before > > >> > res=. > > >> > > > >> > Signed-off-by: Stefan Berger > > >> > Suggested-by: Steve Grubb > > >> > --- > > >> > > > >> > security/integrity/integrity_audit.c | 2 ++ > > >> > 1 file changed, 2 insertions(+) > > >> > > > >> > diff --git a/security/integrity/integrity_audit.c > > >> > b/security/integrity/integrity_audit.c index db30763d5525..8d25d3c4dcca > > >> > 100644 > > >> > --- a/security/integrity/integrity_audit.c > > >> > +++ b/security/integrity/integrity_audit.c > > >> > @@ -56,6 +56,8 @@ void integrity_audit_msg(int audit_msgno, struct inode > > >> > *inode,> > > >> > audit_log_untrustedstring(ab, inode->i_sb->s_id); > > >> > audit_log_format(ab, " ino=%lu", inode->i_ino); > > >> > > > >> > } > > >> > > > >> > + audit_log_d_path_exe(ab, current->mm); > > >> > + audit_log_tty(ab, current); > > >> > > >> NACK > > >> > > >> Please add the new fields to the end of the audit record, thank you. > > > > > > Let's see what an example event looks like before NACK'ing this. Way back in > > > 2013 the IMA events were good. I think this is repairing the event after some > > > drift. > > > > Can you reference a specific commit, or point in time during 2013? > > Looking at the git log quickly, if I go back to commit d726d8d719b6 > > ("integrity: move integrity_audit_msg()") from March 18, 2013 (the > > commit that created integrity_audit.c) the field ordering appears to > > be the same as it today. > > > > My NACK still stands. > > There hasn't been any changes up to now.  This patch set refactors > integrity_audit_msg(), creating integrity_audit_msg_common(), which > will be called from both ima_audit_measurement() and > ima_parse_rule(). That should have been "from integrity_audit_msg() and ima_parse_rule()", not ima_audit_measurement(). > Previously the audit record generated by ima_parse_rule() did not > include this info.  The change in this patch will affect both the > existing and the new INTEGRITY_AUDIT_POLICY_RULE audit records. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33338 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753169AbeE3NFA (ORCPT ); Wed, 30 May 2018 09:05:00 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4UCuNiS083054 for ; Wed, 30 May 2018 09:05:00 -0400 Received: from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j9vdarex4-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 30 May 2018 09:04:59 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 May 2018 14:04:56 +0100 Subject: Re: [PATCH 5/8] integrity: Add exe= and tty= before res= to integrity audits From: Mimi Zohar To: Paul Moore , Steve Grubb , Stefan Berger Cc: linux-integrity@vger.kernel.org, linux-audit@redhat.com, linux-kernel@vger.kernel.org Date: Wed, 30 May 2018 09:04:40 -0400 In-Reply-To: <1527634686.3534.27.camel@linux.vnet.ibm.com> References: <20180524201105.3179904-1-stefanb@linux.vnet.ibm.com> <20180524201105.3179904-6-stefanb@linux.vnet.ibm.com> <4331521.GQBdaJNAj6@x2> <1527634686.3534.27.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Message-Id: <1527685480.3534.54.camel@linux.vnet.ibm.com> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Tue, 2018-05-29 at 18:58 -0400, Mimi Zohar wrote: > On Tue, 2018-05-29 at 17:47 -0400, Paul Moore wrote: > > On Tue, May 29, 2018 at 5:35 PM, Steve Grubb wrote: > > > On Tuesday, May 29, 2018 5:19:39 PM EDT Paul Moore wrote: > > >> On Thu, May 24, 2018 at 4:11 PM, Stefan Berger > > >> > > >> wrote: > > >> > Use the new public audit functions to add the exe= and tty= > > >> > parts to the integrity audit records. We place them before > > >> > res=. > > >> > > > >> > Signed-off-by: Stefan Berger > > >> > Suggested-by: Steve Grubb > > >> > --- > > >> > > > >> > security/integrity/integrity_audit.c | 2 ++ > > >> > 1 file changed, 2 insertions(+) > > >> > > > >> > diff --git a/security/integrity/integrity_audit.c > > >> > b/security/integrity/integrity_audit.c index db30763d5525..8d25d3c4dcca > > >> > 100644 > > >> > --- a/security/integrity/integrity_audit.c > > >> > +++ b/security/integrity/integrity_audit.c > > >> > @@ -56,6 +56,8 @@ void integrity_audit_msg(int audit_msgno, struct inode > > >> > *inode,> > > >> > audit_log_untrustedstring(ab, inode->i_sb->s_id); > > >> > audit_log_format(ab, " ino=%lu", inode->i_ino); > > >> > > > >> > } > > >> > > > >> > + audit_log_d_path_exe(ab, current->mm); > > >> > + audit_log_tty(ab, current); > > >> > > >> NACK > > >> > > >> Please add the new fields to the end of the audit record, thank you. > > > > > > Let's see what an example event looks like before NACK'ing this. Way back in > > > 2013 the IMA events were good. I think this is repairing the event after some > > > drift. > > > > Can you reference a specific commit, or point in time during 2013? > > Looking at the git log quickly, if I go back to commit d726d8d719b6 > > ("integrity: move integrity_audit_msg()") from March 18, 2013 (the > > commit that created integrity_audit.c) the field ordering appears to > > be the same as it today. > > > > My NACK still stands. > > There hasn't been any changes up to now. This patch set refactors > integrity_audit_msg(), creating integrity_audit_msg_common(), which > will be called from both ima_audit_measurement() and > ima_parse_rule(). That should have been "from integrity_audit_msg() and ima_parse_rule()", not ima_audit_measurement(). > Previously the audit record generated by ima_parse_rule() did not > include this info. The change in this patch will affect both the > existing and the new INTEGRITY_AUDIT_POLICY_RULE audit records.