From: Rik van Riel <riel@surriel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
songliubraving@fb.com, kernel-team <kernel-team@fb.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>, X86 ML <x86@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86,switch_mm: skip atomic operations for init_mm
Date: Fri, 01 Jun 2018 16:35:24 -0400 [thread overview]
Message-ID: <1527885324.7898.88.camel@surriel.com> (raw)
In-Reply-To: <CALCETrVE5ugmiSOjQ5sw7V+S4bRpMDs419rgrbTzfvjfhbWeqA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
On Fri, 2018-06-01 at 13:03 -0700, Andy Lutomirski wrote:
> Mike, you never did say: do you have PCID on your CPU? Also, what is
> your workload doing to cause so many switches back and forth between
> init_mm and a task.
>
> The point of the optimization is that switching to init_mm() should
> be
> fairly fast on a PCID system, whereas an IPI to do the deferred flush
> is very expensive regardless of PCID.
While I am sure that bit is true, Song and I
observed about 4x as much CPU use in the atomic
operations in cpumask_clear_cpu and cpumask_set_cpu
(inside switch_mm_irqs_off) as we saw CPU used
in the %cr3 reload itself.
Given how expensive those cpumask updates are,
lazy TLB mode might always be worth it, especially
on larger systems.
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-06-01 20:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 12:28 [PATCH] x86,switch_mm: skip atomic operations for init_mm Rik van Riel
2018-06-01 15:11 ` Andy Lutomirski
2018-06-01 18:22 ` Rik van Riel
2018-06-01 18:48 ` Mike Galbraith
2018-06-01 19:43 ` Rik van Riel
2018-06-01 20:03 ` Andy Lutomirski
2018-06-01 20:35 ` Rik van Riel [this message]
2018-06-01 21:21 ` Andy Lutomirski
2018-06-01 22:13 ` Rik van Riel
2018-06-02 3:35 ` Andy Lutomirski
2018-06-02 5:04 ` Rik van Riel
2018-06-02 20:14 ` Andy Lutomirski
2018-06-03 0:51 ` Song Liu
2018-06-03 1:38 ` Rik van Riel
2018-06-06 18:17 ` Andy Lutomirski
2018-06-06 19:00 ` Rik van Riel
2018-06-06 19:23 ` Andy Lutomirski
2018-06-02 3:39 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527885324.7898.88.camel@surriel.com \
--to=riel@surriel.com \
--cc=efault@gmx.de \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.