All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/13] drm/omap: panel-dpi: remove non-DT support
Date: Fri, 12 May 2017 15:30:57 +0300	[thread overview]
Message-ID: <1528311.M2npY2gt6N@avalon> (raw)
In-Reply-To: <8b0635cf-3d0a-8ed4-5df5-266627759c9d@ti.com>

Hi Tomi,

On Friday 12 May 2017 15:29:38 Tomi Valkeinen wrote:
> On 12/05/17 15:08, Laurent Pinchart wrote:
> > On Friday 12 May 2017 13:41:30 Tomi Valkeinen wrote:
> >> Non-DT booting is no longer supported, so remove legacy code.
> >> 
> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> >> ---
> >> 
> >>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 78 +++-------------------
> >>  1 file changed, 6 insertions(+), 72 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> >> b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c index
> >> 04ce8c5f2954..75b98bb81de2 100644
> >> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> >> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> >> @@ -18,7 +18,6 @@
> > 
> > I think you can drop linux/of_gpio.h.
> 
> Yep.
> 
> >> +	if (!pdev->dev.of_node)
> >> +		return -ENODEV;
> >> +
> > 
> > This can't happen.
> 
> True. I have removed that from the first three patches.
> 
> Do you want me to resend, or can I get your reviewed-by?

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-05-12 12:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 10:41 [PATCH 00/13] drm/omap: legacy cleanup Tomi Valkeinen
2017-05-12 10:41 ` [PATCH 01/13] drm/omap: panel-dpi: remove non-DT support Tomi Valkeinen
2017-05-12 12:08   ` Laurent Pinchart
2017-05-12 12:29     ` Tomi Valkeinen
2017-05-12 12:30       ` Laurent Pinchart [this message]
2017-05-12 10:41 ` [PATCH 02/13] drm/omap: acx565akm: " Tomi Valkeinen
2017-05-12 12:10   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 03/13] drm/omap: connector-analog-tv: " Tomi Valkeinen
2017-05-12 10:41 ` [PATCH 04/13] drm/omap: connector-dvi/hdmi: remove extra include Tomi Valkeinen
2017-05-12 12:14   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 05/13] drm/omap: sdi: remove legacy set_datapairs Tomi Valkeinen
2017-05-12 12:14   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 06/13] drm/omap: venc: remove set_type & invert_vid_out_polarity Tomi Valkeinen
2017-05-12 12:15   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 07/13] drm/omap: remove recommended_bpp Tomi Valkeinen
2017-05-12 12:16   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 08/13] drm/omap: dpi: remove legacy data_lines Tomi Valkeinen
2017-05-12 12:17   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 09/13] drm/omap: remove rfbi Tomi Valkeinen
2017-05-12 12:18   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 10/13] drm/omap: remove unused get_dimensions() Tomi Valkeinen
2017-05-12 12:19   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 11/13] drm/omap: remove legacy get_resolution Tomi Valkeinen
2017-05-12 12:20   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 12/13] drm/omap: remove unused fields Tomi Valkeinen
2017-05-12 12:21   ` Laurent Pinchart
2017-05-12 10:41 ` [PATCH 13/13] drm/omap: remove omap_overlay & omap_overlay_manager Tomi Valkeinen
2017-05-12 12:25   ` Laurent Pinchart
2017-05-12 12:33 ` [PATCH 14/13] drm: omapdrm: Remove unused omap_dss_find_output() function Laurent Pinchart
2017-05-12 12:40   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528311.M2npY2gt6N@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.