From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init Date: Wed, 13 Jun 2018 15:35:05 +0800 Message-ID: <1528875305.30263.14.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stu Hsieh Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIFN0dToKCk9uIE1vbiwgMjAxOC0wNi0xMSBhdCAxMToyNiArMDgwMCwgU3R1IEhzaWVoIHdy b3RlOgo+IFRoaXMgcGF0Y2ggYWRkIGNvbXBvbmVudHMgRFBJMS9EU0kxL0RTSTIvRFNJMyBpbiBj b21wX2luaXQuCj4gQmVjYXVzZSB0aGUgc29tZSBwYXJhbWV0ZXIgZm9yIHRoZXNlIGNvbXBvbmVu dHMgaW5pdGlhbGl6ZWQKPiBpbiB0aGVpciBkcml2ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogU3R1 IEhzaWVoIDxzdHUuaHNpZWhAbWVkaWF0ZWsuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v bWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIHwgNCArKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kcm1fZGRwX2NvbXAuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rk cF9jb21wLmMKPiBpbmRleCAyMmY0YzcyZmE3ODUuLmZmOTc0ZDgyYTRhNiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYwo+IEBAIC0yNzgsNyArMjc4 LDExIEBAIGludCBtdGtfZGRwX2NvbXBfaW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBk ZXZpY2Vfbm9kZSAqbm9kZSwKPiAgCj4gIAlpZiAoY29tcF9pZCA9PSBERFBfQ09NUE9ORU5UX0JM UyB8fAo+ICAJICAgIGNvbXBfaWQgPT0gRERQX0NPTVBPTkVOVF9EUEkwIHx8Cj4gKwkgICAgY29t cF9pZCA9PSBERFBfQ09NUE9ORU5UX0RQSTEgfHwKCldoeSBub3QgbW92ZSB0aGlzIG1vZGlmaWNh dGlvbiB0byB0aGUgcGF0Y2ggJ2FkZCBjb21wb25lbnQgRFBJMSc/Cgo+ICAJICAgIGNvbXBfaWQg PT0gRERQX0NPTVBPTkVOVF9EU0kwIHx8Cj4gKwkgICAgY29tcF9pZCA9PSBERFBfQ09NUE9ORU5U X0RTSTEgfHwKPiArCSAgICBjb21wX2lkID09IEREUF9DT01QT05FTlRfRFNJMiB8fAoKV2h5IG5v dCBtb3ZlIHRoaXMgbW9kaWZpY2F0aW9uIHRvIHRoZSBwYXRjaCAnYWRkIGNvbXBvbmVudCBEU0ky Jz8KCj4gKwkgICAgY29tcF9pZCA9PSBERFBfQ09NUE9ORU5UX0RTSTMgfHwKCldoeSBub3QgbW92 ZSB0aGlzIG1vZGlmaWNhdGlvbiB0byB0aGUgcGF0Y2ggJ2FkZCBjb21wb25lbnQgRFNJMyc/CgpS ZWdhcmRzLApDSwoKPiAgCSAgICBjb21wX2lkID09IEREUF9DT01QT05FTlRfUFdNMCkgewo+ICAJ CWNvbXAtPnJlZ3MgPSBOVUxMOwo+ICAJCWNvbXAtPmNsayA9IE5VTEw7CgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Wed, 13 Jun 2018 15:35:05 +0800 Subject: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init In-Reply-To: <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> Message-ID: <1528875305.30263.14.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init. > Because the some parameter for these components initialized > in their driver. > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 22f4c72fa785..ff974d82a4a6 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -278,7 +278,11 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > if (comp_id == DDP_COMPONENT_BLS || > comp_id == DDP_COMPONENT_DPI0 || > + comp_id == DDP_COMPONENT_DPI1 || Why not move this modification to the patch 'add component DPI1'? > comp_id == DDP_COMPONENT_DSI0 || > + comp_id == DDP_COMPONENT_DSI1 || > + comp_id == DDP_COMPONENT_DSI2 || Why not move this modification to the patch 'add component DSI2'? > + comp_id == DDP_COMPONENT_DSI3 || Why not move this modification to the patch 'add component DSI3'? Regards, CK > comp_id == DDP_COMPONENT_PWM0) { > comp->regs = NULL; > comp->clk = NULL; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 149F7C004E4 for ; Wed, 13 Jun 2018 07:35:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C898C20891 for ; Wed, 13 Jun 2018 07:35:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C898C20891 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934603AbeFMHfP (ORCPT ); Wed, 13 Jun 2018 03:35:15 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:15576 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933759AbeFMHfN (ORCPT ); Wed, 13 Jun 2018 03:35:13 -0400 X-UUID: 4eb89f8c63de46778035ebcadd31e606-20180613 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1076597531; Wed, 13 Jun 2018 15:35:07 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 13 Jun 2018 15:35:05 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 13 Jun 2018 15:35:05 +0800 Message-ID: <1528875305.30263.14.camel@mtksdaap41> Subject: Re: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init From: CK Hu To: Stu Hsieh CC: Philipp Zabel , David Airlie , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , Date: Wed, 13 Jun 2018 15:35:05 +0800 In-Reply-To: <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init. > Because the some parameter for these components initialized > in their driver. > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > index 22f4c72fa785..ff974d82a4a6 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > @@ -278,7 +278,11 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > if (comp_id == DDP_COMPONENT_BLS || > comp_id == DDP_COMPONENT_DPI0 || > + comp_id == DDP_COMPONENT_DPI1 || Why not move this modification to the patch 'add component DPI1'? > comp_id == DDP_COMPONENT_DSI0 || > + comp_id == DDP_COMPONENT_DSI1 || > + comp_id == DDP_COMPONENT_DSI2 || Why not move this modification to the patch 'add component DSI2'? > + comp_id == DDP_COMPONENT_DSI3 || Why not move this modification to the patch 'add component DSI3'? Regards, CK > comp_id == DDP_COMPONENT_PWM0) { > comp->regs = NULL; > comp->clk = NULL;