From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3 Date: Wed, 13 Jun 2018 16:05:12 +0800 Message-ID: <1528877112.30263.24.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-14-git-send-email-stu.hsieh@mediatek.com> <1528868751.15127.10.camel@mtksdaap41> <1528875983.11190.29.camel@mtksdccf07> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1528875983.11190.29.camel@mtksdccf07> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stu Hsieh Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIFN0dToKCk9uIFdlZCwgMjAxOC0wNi0xMyBhdCAxNTo0NiArMDgwMCwgU3R1IEhzaWVoIHdy b3RlOgo+IEhpLCBDSzoKPiAKPiBPbiBXZWQsIDIwMTgtMDYtMTMgYXQgMTM6NDUgKzA4MDAsIENL IEh1IHdyb3RlOgo+ID4gSGksIFN0dToKPiA+IAo+ID4gVHdvIGlubGluZSBjb21tZW50Lgo+ID4g Cj4gPiBPbiBNb24sIDIwMTgtMDYtMTEgYXQgMTE6MjYgKzA4MDAsIFN0dSBIc2llaCB3cm90ZToK PiA+ID4gVGhpcyBwYXRjaCBhZGQgdGhlIGNvbm5lY3Rpb24gZnJvbSBSRE1BMCB0byBEU0kzCj4g PiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBTdHUgSHNpZWggPHN0dS5oc2llaEBtZWRpYXRlay5j b20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRw LmMgICAgICB8IDQgKysrKwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1f ZGRwX2NvbXAuYyB8IDIgKy0KPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fZGRwLmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9kZHAuYwo+ID4gPiBpbmRleCBjMDhhZWQ4ZGFlNDQuLmZlZDFiNTcwNDM1NSAxMDA2NDQKPiA+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMKPiA+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMKPiA+ID4gQEAgLTgzLDYg KzgzLDcgQEAKPiA+ID4gICNkZWZpbmUgR0FNTUFfTU9VVF9FTl9SRE1BMQkJMHgxCj4gPiA+ICAj ZGVmaW5lIFJETUEwX01PVVRfRFBJMAkJCTB4Mgo+ID4gPiAgI2RlZmluZSBSRE1BMF9NT1VUX0RT STIJCQkweDQKPiA+ID4gKyNkZWZpbmUgUkRNQTBfTU9VVF9EU0kzCQkJMHg1Cj4gPiAKPiA+IFVz dWFsbHksIGVhY2ggYml0IG9mIGEgbW91dCByZWdpc3RlciByZXByZXNlbnQgYSBvdXRwdXQgZW5h YmxlLiBJcyB0aGlzCj4gPiB2YWx1ZSAweDUgaXMgYSBjb3JyZWN0IHZhbHVlPwo+IAo+IEluIGh3 IENPTkZJRyBTUEVDIHNob3cgYXMgZm9sbG93aW5nOgo+IEJpdChzKQlOYW1lCQkJRGVzY3JpcHRp b24KPiAyOjAJRElTUF9QQVRIMF9TT1VUX1NFTF9JTgkwIDogT3V0cHV0IHRvIERTSTAKPiAJCQkJ MTogIE9vdXRwdXQgdG8gRFNJMQo+IAkJCQkyOiAgT291dHB1dCB0byBEUEkKPiAJCQkJMzogIE9v dXRwdXQgdG8gRFBJMQo+IAkJCQk0OiAgT291dHB1dCB0byBEU0kyCj4gCQkJCTU6ICBPb3V0cHV0 IHRvIERTSTMKPiAJCQkJNiA6IHJlc2VydmVkCj4gCQkJCTc6ICBPb3V0cHV0IHRvIERJU1BfVUZP RQo+IFNvLCB0aGUgdmFsdWUgMHg1IGlzIGNvcnJlY3QgdmFsdWUuCj4gCgpGcm9tIHRoZSBkZWZp bml0aW9uLCBpdCBsb29rcyBsaWtlIHRoYXQgUkRNQTAgY291bGQgb25seSBzaW5nbGUgb3V0cHV0 CihvdXRwdXQgdG8gb25seSBvbmUgZGVzdGluYXRpb24gYXQgb25lIG1vbWVudCkuIFRoZSByZWdp c3RlciBuYW1pbmcKJ0RJU1BfUkVHX0NPTkZJR19ESVNQX1JETUEwX01PVVRfRU4nIChNT1VUIG1l YW5zIG91dHB1dCB0byBtdWx0aXBsZQpkZXN0aW5hdGlvbiBzaW11bHRhbmVvdXNseSkgd291bGQg Y29uZnVzZSBtZS4gSWYgdGhlIGRhdGEgc2hlZXQgdXNlIHRoZQpjb25mdXNlZCBuYW1pbmcsIEkg dGhpbmsgSSBjb3VsZCBqdXN0IGFjY2VwdCBpdC4KClJlZ2FyZHMsCkNLCgo+IFJlZ2FyZCwKPiBT dHUKPiAKPiA+IAo+ID4gPiAgI2RlZmluZSBSRE1BMV9NT1VUX0RQSTAJCQkweDIKPiA+ID4gICNk ZWZpbmUgRFBJMF9TRUxfSU5fUkRNQTEJCTB4MQo+ID4gPiAgI2RlZmluZSBDT0xPUjFfU0VMX0lO X09WTDEJCTB4MQo+ID4gPiBAQCAtMTY0LDYgKzE2NSw5IEBAIHN0YXRpYyB1bnNpZ25lZCBpbnQg bXRrX2RkcF9tb3V0X2VuKGVudW0gbXRrX2RkcF9jb21wX2lkIGN1ciwKPiA+ID4gIAl9IGVsc2Ug aWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX1JETUEwICYmIG5leHQgPT0gRERQX0NPTVBPTkVOVF9E U0kyKSB7Cj4gPiA+ICAJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RJU1BfUkRNQTBfTU9VVF9F TjsKPiA+ID4gIAkJdmFsdWUgPSBSRE1BMF9NT1VUX0RTSTI7Cj4gPiA+ICsJfSBlbHNlIGlmIChj dXIgPT0gRERQX0NPTVBPTkVOVF9SRE1BMCAmJiBuZXh0ID09IEREUF9DT01QT05FTlRfRFNJMykg ewo+ID4gPiArCQkqYWRkciA9IERJU1BfUkVHX0NPTkZJR19ESVNQX1JETUEwX01PVVRfRU47Cj4g PiA+ICsJCXZhbHVlID0gUkRNQTBfTU9VVF9EU0kzOwo+ID4gPiAgCX0gZWxzZSBpZiAoY3VyID09 IEREUF9DT01QT05FTlRfUkRNQTEgJiYgbmV4dCA9PSBERFBfQ09NUE9ORU5UX0RQSTApIHsKPiA+ ID4gIAkJKmFkZHIgPSBESVNQX1JFR19DT05GSUdfRElTUF9SRE1BMV9NT1VUX0VOOwo+ID4gPiAg CQl2YWx1ZSA9IFJETUExX01PVVRfRFBJMDsKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvbXRrX2RybV9kZHBfY29tcC5jCj4gPiA+IGluZGV4IGZlNmZkYzAyMWZjNy4uMjJmNGM3MmZh Nzg1IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9k ZHBfY29tcC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2Rk cF9jb21wLmMKPiA+ID4gQEAgLTIyOCw3ICsyMjgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG10 a19kZHBfY29tcF9tYXRjaCBtdGtfZGRwX21hdGNoZXNbRERQX0NPTVBPTkVOVF9JRF9NQVhdID0g ewo+ID4gPiAgCVtERFBfQ09NUE9ORU5UX0RTSTBdCT0geyBNVEtfRFNJLAkJMCwgTlVMTCB9LAo+ ID4gPiAgCVtERFBfQ09NUE9ORU5UX0RTSTFdCT0geyBNVEtfRFNJLAkJMSwgTlVMTCB9LAo+ID4g PiAgCVtERFBfQ09NUE9ORU5UX0RTSTJdCT0geyBNVEtfRFNJLAkJMiwgTlVMTCB9LAo+ID4gPiAt CVtERFBfQ09NUE9ORU5UX0RTSTJdCT0geyBNVEtfRFNJLAkJMywgTlVMTCB9LAo+ID4gPiArCVtE RFBfQ09NUE9ORU5UX0RTSTNdCT0geyBNVEtfRFNJLAkJMywgTlVMTCB9LAo+ID4gCj4gPiBJIHRo aW5rIHRoaXMgaXMgbm90IHJlbGF0ZWQgdG8gdGhpcyBwYXRjaC4KPiBPSwo+IAo+ID4gCj4gPiBS ZWdhcmRzLAo+ID4gQ0sKPiA+IAo+ID4gPiAgCVtERFBfQ09NUE9ORU5UX0dBTU1BXQk9IHsgTVRL X0RJU1BfR0FNTUEsCTAsICZkZHBfZ2FtbWEgfSwKPiA+ID4gIAlbRERQX0NPTVBPTkVOVF9PRDBd CT0geyBNVEtfRElTUF9PRCwJMCwgJmRkcF9vZCB9LAo+ID4gPiAgCVtERFBfQ09NUE9ORU5UX09E MV0JPSB7IE1US19ESVNQX09ELAkxLCAmZGRwX29kIH0sCj4gPiAKPiA+IAo+IAo+IAoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Wed, 13 Jun 2018 16:05:12 +0800 Subject: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3 In-Reply-To: <1528875983.11190.29.camel@mtksdccf07> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-14-git-send-email-stu.hsieh@mediatek.com> <1528868751.15127.10.camel@mtksdaap41> <1528875983.11190.29.camel@mtksdccf07> Message-ID: <1528877112.30263.24.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Stu: On Wed, 2018-06-13 at 15:46 +0800, Stu Hsieh wrote: > Hi, CK: > > On Wed, 2018-06-13 at 13:45 +0800, CK Hu wrote: > > Hi, Stu: > > > > Two inline comment. > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > This patch add the connection from RDMA0 to DSI3 > > > > > > Signed-off-by: Stu Hsieh > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > index c08aed8dae44..fed1b5704355 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > @@ -83,6 +83,7 @@ > > > #define GAMMA_MOUT_EN_RDMA1 0x1 > > > #define RDMA0_MOUT_DPI0 0x2 > > > #define RDMA0_MOUT_DSI2 0x4 > > > +#define RDMA0_MOUT_DSI3 0x5 > > > > Usually, each bit of a mout register represent a output enable. Is this > > value 0x5 is a correct value? > > In hw CONFIG SPEC show as following: > Bit(s) Name Description > 2:0 DISP_PATH0_SOUT_SEL_IN 0 : Output to DSI0 > 1: Ooutput to DSI1 > 2: Ooutput to DPI > 3: Ooutput to DPI1 > 4: Ooutput to DSI2 > 5: Ooutput to DSI3 > 6 : reserved > 7: Ooutput to DISP_UFOE > So, the value 0x5 is correct value. > >>From the definition, it looks like that RDMA0 could only single output (output to only one destination at one moment). The register naming 'DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN' (MOUT means output to multiple destination simultaneously) would confuse me. If the data sheet use the confused naming, I think I could just accept it. Regards, CK > Regard, > Stu > > > > > > #define RDMA1_MOUT_DPI0 0x2 > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > #define COLOR1_SEL_IN_OVL1 0x1 > > > @@ -164,6 +165,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI2) { > > > *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > value = RDMA0_MOUT_DSI2; > > > + } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI3) { > > > + *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > + value = RDMA0_MOUT_DSI3; > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > value = RDMA1_MOUT_DPI0; > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > index fe6fdc021fc7..22f4c72fa785 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > @@ -228,7 +228,7 @@ static const struct mtk_ddp_comp_match mtk_ddp_matches[DDP_COMPONENT_ID_MAX] = { > > > [DDP_COMPONENT_DSI0] = { MTK_DSI, 0, NULL }, > > > [DDP_COMPONENT_DSI1] = { MTK_DSI, 1, NULL }, > > > [DDP_COMPONENT_DSI2] = { MTK_DSI, 2, NULL }, > > > - [DDP_COMPONENT_DSI2] = { MTK_DSI, 3, NULL }, > > > + [DDP_COMPONENT_DSI3] = { MTK_DSI, 3, NULL }, > > > > I think this is not related to this patch. > OK > > > > > Regards, > > CK > > > > > [DDP_COMPONENT_GAMMA] = { MTK_DISP_GAMMA, 0, &ddp_gamma }, > > > [DDP_COMPONENT_OD0] = { MTK_DISP_OD, 0, &ddp_od }, > > > [DDP_COMPONENT_OD1] = { MTK_DISP_OD, 1, &ddp_od }, > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 9B3D5C004E4 for ; Wed, 13 Jun 2018 08:05:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57982208AF for ; Wed, 13 Jun 2018 08:05:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57982208AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754549AbeFMIFV (ORCPT ); Wed, 13 Jun 2018 04:05:21 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:8730 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754472AbeFMIFQ (ORCPT ); Wed, 13 Jun 2018 04:05:16 -0400 X-UUID: c5e17e59590d4b878061811ab621b682-20180613 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 110980950; Wed, 13 Jun 2018 16:05:14 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 13 Jun 2018 16:05:12 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 13 Jun 2018 16:05:12 +0800 Message-ID: <1528877112.30263.24.camel@mtksdaap41> Subject: Re: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3 From: CK Hu To: Stu Hsieh CC: Philipp Zabel , David Airlie , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , Date: Wed, 13 Jun 2018 16:05:12 +0800 In-Reply-To: <1528875983.11190.29.camel@mtksdccf07> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-14-git-send-email-stu.hsieh@mediatek.com> <1528868751.15127.10.camel@mtksdaap41> <1528875983.11190.29.camel@mtksdccf07> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Stu: On Wed, 2018-06-13 at 15:46 +0800, Stu Hsieh wrote: > Hi, CK: > > On Wed, 2018-06-13 at 13:45 +0800, CK Hu wrote: > > Hi, Stu: > > > > Two inline comment. > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > This patch add the connection from RDMA0 to DSI3 > > > > > > Signed-off-by: Stu Hsieh > > > --- > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > index c08aed8dae44..fed1b5704355 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > @@ -83,6 +83,7 @@ > > > #define GAMMA_MOUT_EN_RDMA1 0x1 > > > #define RDMA0_MOUT_DPI0 0x2 > > > #define RDMA0_MOUT_DSI2 0x4 > > > +#define RDMA0_MOUT_DSI3 0x5 > > > > Usually, each bit of a mout register represent a output enable. Is this > > value 0x5 is a correct value? > > In hw CONFIG SPEC show as following: > Bit(s) Name Description > 2:0 DISP_PATH0_SOUT_SEL_IN 0 : Output to DSI0 > 1: Ooutput to DSI1 > 2: Ooutput to DPI > 3: Ooutput to DPI1 > 4: Ooutput to DSI2 > 5: Ooutput to DSI3 > 6 : reserved > 7: Ooutput to DISP_UFOE > So, the value 0x5 is correct value. > >From the definition, it looks like that RDMA0 could only single output (output to only one destination at one moment). The register naming 'DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN' (MOUT means output to multiple destination simultaneously) would confuse me. If the data sheet use the confused naming, I think I could just accept it. Regards, CK > Regard, > Stu > > > > > > #define RDMA1_MOUT_DPI0 0x2 > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > #define COLOR1_SEL_IN_OVL1 0x1 > > > @@ -164,6 +165,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI2) { > > > *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > value = RDMA0_MOUT_DSI2; > > > + } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI3) { > > > + *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > + value = RDMA0_MOUT_DSI3; > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > value = RDMA1_MOUT_DPI0; > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > index fe6fdc021fc7..22f4c72fa785 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > @@ -228,7 +228,7 @@ static const struct mtk_ddp_comp_match mtk_ddp_matches[DDP_COMPONENT_ID_MAX] = { > > > [DDP_COMPONENT_DSI0] = { MTK_DSI, 0, NULL }, > > > [DDP_COMPONENT_DSI1] = { MTK_DSI, 1, NULL }, > > > [DDP_COMPONENT_DSI2] = { MTK_DSI, 2, NULL }, > > > - [DDP_COMPONENT_DSI2] = { MTK_DSI, 3, NULL }, > > > + [DDP_COMPONENT_DSI3] = { MTK_DSI, 3, NULL }, > > > > I think this is not related to this patch. > OK > > > > > Regards, > > CK > > > > > [DDP_COMPONENT_GAMMA] = { MTK_DISP_GAMMA, 0, &ddp_gamma }, > > > [DDP_COMPONENT_OD0] = { MTK_DISP_OD, 0, &ddp_od }, > > > [DDP_COMPONENT_OD1] = { MTK_DISP_OD, 1, &ddp_od }, > > > > > >