From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stu Hsieh Subject: Re: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init Date: Wed, 13 Jun 2018 16:05:55 +0800 Message-ID: <1528877155.11190.36.camel@mtksdccf07> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> <1528875305.30263.14.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1528875305.30263.14.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: CK Hu Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIENLOgoKT24gV2VkLCAyMDE4LTA2LTEzIGF0IDE1OjM1ICswODAwLCBDSyBIdSB3cm90ZToK PiBIaSwgU3R1Ogo+IAo+IE9uIE1vbiwgMjAxOC0wNi0xMSBhdCAxMToyNiArMDgwMCwgU3R1IEhz aWVoIHdyb3RlOgo+ID4gVGhpcyBwYXRjaCBhZGQgY29tcG9uZW50cyBEUEkxL0RTSTEvRFNJMi9E U0kzIGluIGNvbXBfaW5pdC4KPiA+IEJlY2F1c2UgdGhlIHNvbWUgcGFyYW1ldGVyIGZvciB0aGVz ZSBjb21wb25lbnRzIGluaXRpYWxpemVkCj4gPiBpbiB0aGVpciBkcml2ZXIuCj4gPiAKPiA+IFNp Z25lZC1vZmYtYnk6IFN0dSBIc2llaCA8c3R1LmhzaWVoQG1lZGlhdGVrLmNvbT4KPiA+IC0tLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgfCA0ICsrKysK PiA+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jIGIvZHJpdmVycy9n cHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYwo+ID4gaW5kZXggMjJmNGM3MmZhNzg1 Li5mZjk3NGQ4MmE0YTYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsv bXRrX2RybV9kZHBfY29tcC5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRr X2RybV9kZHBfY29tcC5jCj4gPiBAQCAtMjc4LDcgKzI3OCwxMSBAQCBpbnQgbXRrX2RkcF9jb21w X2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGUsCj4gPiAg Cj4gPiAgCWlmIChjb21wX2lkID09IEREUF9DT01QT05FTlRfQkxTIHx8Cj4gPiAgCSAgICBjb21w X2lkID09IEREUF9DT01QT05FTlRfRFBJMCB8fAo+ID4gKwkgICAgY29tcF9pZCA9PSBERFBfQ09N UE9ORU5UX0RQSTEgfHwKPiAKPiBXaHkgbm90IG1vdmUgdGhpcyBtb2RpZmljYXRpb24gdG8gdGhl IHBhdGNoICdhZGQgY29tcG9uZW50IERQSTEnPwo+IAo+ID4gIAkgICAgY29tcF9pZCA9PSBERFBf Q09NUE9ORU5UX0RTSTAgfHwKPiA+ICsJICAgIGNvbXBfaWQgPT0gRERQX0NPTVBPTkVOVF9EU0kx IHx8Cj4gPiArCSAgICBjb21wX2lkID09IEREUF9DT01QT05FTlRfRFNJMiB8fAo+IAo+IFdoeSBu b3QgbW92ZSB0aGlzIG1vZGlmaWNhdGlvbiB0byB0aGUgcGF0Y2ggJ2FkZCBjb21wb25lbnQgRFNJ Mic/Cj4gCj4gPiArCSAgICBjb21wX2lkID09IEREUF9DT01QT05FTlRfRFNJMyB8fAo+IAo+IFdo eSBub3QgbW92ZSB0aGlzIG1vZGlmaWNhdGlvbiB0byB0aGUgcGF0Y2ggJ2FkZCBjb21wb25lbnQg RFNJMyc/Cj4gCj4gUmVnYXJkcywKPiBDSwo+IApvawoKUmVnYXJkLApTdHUKPiA+ICAJICAgIGNv bXBfaWQgPT0gRERQX0NPTVBPTkVOVF9QV00wKSB7Cj4gPiAgCQljb21wLT5yZWdzID0gTlVMTDsK PiA+ICAJCWNvbXAtPmNsayA9IE5VTEw7Cj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: stu.hsieh@mediatek.com (Stu Hsieh) Date: Wed, 13 Jun 2018 16:05:55 +0800 Subject: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init In-Reply-To: <1528875305.30263.14.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> <1528875305.30263.14.camel@mtksdaap41> Message-ID: <1528877155.11190.36.camel@mtksdccf07> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, CK: On Wed, 2018-06-13 at 15:35 +0800, CK Hu wrote: > Hi, Stu: > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init. > > Because the some parameter for these components initialized > > in their driver. > > > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > index 22f4c72fa785..ff974d82a4a6 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > @@ -278,7 +278,11 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > > > if (comp_id == DDP_COMPONENT_BLS || > > comp_id == DDP_COMPONENT_DPI0 || > > + comp_id == DDP_COMPONENT_DPI1 || > > Why not move this modification to the patch 'add component DPI1'? > > > comp_id == DDP_COMPONENT_DSI0 || > > + comp_id == DDP_COMPONENT_DSI1 || > > + comp_id == DDP_COMPONENT_DSI2 || > > Why not move this modification to the patch 'add component DSI2'? > > > + comp_id == DDP_COMPONENT_DSI3 || > > Why not move this modification to the patch 'add component DSI3'? > > Regards, > CK > ok Regard, Stu > > comp_id == DDP_COMPONENT_PWM0) { > > comp->regs = NULL; > > comp->clk = NULL; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 90A8CC433EF for ; Wed, 13 Jun 2018 08:06:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 507402086A for ; Wed, 13 Jun 2018 08:06:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 507402086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754562AbeFMIGF (ORCPT ); Wed, 13 Jun 2018 04:06:05 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:27103 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754472AbeFMIGB (ORCPT ); Wed, 13 Jun 2018 04:06:01 -0400 X-UUID: d1892caf26694712963d84253744c681-20180613 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1471039441; Wed, 13 Jun 2018 16:05:56 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 13 Jun 2018 16:05:55 +0800 Received: from [172.21.84.99] (172.21.84.99) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 13 Jun 2018 16:05:55 +0800 Message-ID: <1528877155.11190.36.camel@mtksdccf07> Subject: Re: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init From: Stu Hsieh To: CK Hu CC: Philipp Zabel , David Airlie , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , Date: Wed, 13 Jun 2018 16:05:55 +0800 In-Reply-To: <1528875305.30263.14.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-27-git-send-email-stu.hsieh@mediatek.com> <1528875305.30263.14.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK: On Wed, 2018-06-13 at 15:35 +0800, CK Hu wrote: > Hi, Stu: > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init. > > Because the some parameter for these components initialized > > in their driver. > > > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > index 22f4c72fa785..ff974d82a4a6 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > @@ -278,7 +278,11 @@ int mtk_ddp_comp_init(struct device *dev, struct device_node *node, > > > > if (comp_id == DDP_COMPONENT_BLS || > > comp_id == DDP_COMPONENT_DPI0 || > > + comp_id == DDP_COMPONENT_DPI1 || > > Why not move this modification to the patch 'add component DPI1'? > > > comp_id == DDP_COMPONENT_DSI0 || > > + comp_id == DDP_COMPONENT_DSI1 || > > + comp_id == DDP_COMPONENT_DSI2 || > > Why not move this modification to the patch 'add component DSI2'? > > > + comp_id == DDP_COMPONENT_DSI3 || > > Why not move this modification to the patch 'add component DSI3'? > > Regards, > CK > ok Regard, Stu > > comp_id == DDP_COMPONENT_PWM0) { > > comp->regs = NULL; > > comp->clk = NULL; > >