From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stu Hsieh Subject: Re: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3 Date: Wed, 13 Jun 2018 16:52:08 +0800 Message-ID: <1528879928.11190.39.camel@mtksdccf07> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-14-git-send-email-stu.hsieh@mediatek.com> <1528868751.15127.10.camel@mtksdaap41> <1528875983.11190.29.camel@mtksdccf07> <1528877112.30263.24.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1528877112.30263.24.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: CK Hu Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIENLOgoKT24gV2VkLCAyMDE4LTA2LTEzIGF0IDE2OjA1ICswODAwLCBDSyBIdSB3cm90ZToK PiBIaSwgU3R1Ogo+IAo+IE9uIFdlZCwgMjAxOC0wNi0xMyBhdCAxNTo0NiArMDgwMCwgU3R1IEhz aWVoIHdyb3RlOgo+ID4gSGksIENLOgo+ID4gCj4gPiBPbiBXZWQsIDIwMTgtMDYtMTMgYXQgMTM6 NDUgKzA4MDAsIENLIEh1IHdyb3RlOgo+ID4gPiBIaSwgU3R1Ogo+ID4gPiAKPiA+ID4gVHdvIGlu bGluZSBjb21tZW50Lgo+ID4gPiAKPiA+ID4gT24gTW9uLCAyMDE4LTA2LTExIGF0IDExOjI2ICsw ODAwLCBTdHUgSHNpZWggd3JvdGU6Cj4gPiA+ID4gVGhpcyBwYXRjaCBhZGQgdGhlIGNvbm5lY3Rp b24gZnJvbSBSRE1BMCB0byBEU0kzCj4gPiA+ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogU3R1 IEhzaWVoIDxzdHUuaHNpZWhAbWVkaWF0ZWsuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYyAgICAgIHwgNCArKysrCj4gPiA+ID4g IGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgfCAyICstCj4gPiA+ ID4gIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2RkcC5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMKPiA+ID4gPiBp bmRleCBjMDhhZWQ4ZGFlNDQuLmZlZDFiNTcwNDM1NSAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcC5jCj4gPiA+ID4gQEAgLTgzLDYgKzgzLDcgQEAK PiA+ID4gPiAgI2RlZmluZSBHQU1NQV9NT1VUX0VOX1JETUExCQkweDEKPiA+ID4gPiAgI2RlZmlu ZSBSRE1BMF9NT1VUX0RQSTAJCQkweDIKPiA+ID4gPiAgI2RlZmluZSBSRE1BMF9NT1VUX0RTSTIJ CQkweDQKPiA+ID4gPiArI2RlZmluZSBSRE1BMF9NT1VUX0RTSTMJCQkweDUKPiA+ID4gCj4gPiA+ IFVzdWFsbHksIGVhY2ggYml0IG9mIGEgbW91dCByZWdpc3RlciByZXByZXNlbnQgYSBvdXRwdXQg ZW5hYmxlLiBJcyB0aGlzCj4gPiA+IHZhbHVlIDB4NSBpcyBhIGNvcnJlY3QgdmFsdWU/Cj4gPiAK PiA+IEluIGh3IENPTkZJRyBTUEVDIHNob3cgYXMgZm9sbG93aW5nOgo+ID4gQml0KHMpCU5hbWUJ CQlEZXNjcmlwdGlvbgo+ID4gMjowCURJU1BfUEFUSDBfU09VVF9TRUxfSU4JMCA6IE91dHB1dCB0 byBEU0kwCj4gPiAJCQkJMTogIE9vdXRwdXQgdG8gRFNJMQo+ID4gCQkJCTI6ICBPb3V0cHV0IHRv IERQSQo+ID4gCQkJCTM6ICBPb3V0cHV0IHRvIERQSTEKPiA+IAkJCQk0OiAgT291dHB1dCB0byBE U0kyCj4gPiAJCQkJNTogIE9vdXRwdXQgdG8gRFNJMwo+ID4gCQkJCTYgOiByZXNlcnZlZAo+ID4g CQkJCTc6ICBPb3V0cHV0IHRvIERJU1BfVUZPRQo+ID4gU28sIHRoZSB2YWx1ZSAweDUgaXMgY29y cmVjdCB2YWx1ZS4KPiA+IAo+IAo+IEZyb20gdGhlIGRlZmluaXRpb24sIGl0IGxvb2tzIGxpa2Ug dGhhdCBSRE1BMCBjb3VsZCBvbmx5IHNpbmdsZSBvdXRwdXQKPiAob3V0cHV0IHRvIG9ubHkgb25l IGRlc3RpbmF0aW9uIGF0IG9uZSBtb21lbnQpLiBUaGUgcmVnaXN0ZXIgbmFtaW5nCj4gJ0RJU1Bf UkVHX0NPTkZJR19ESVNQX1JETUEwX01PVVRfRU4nIChNT1VUIG1lYW5zIG91dHB1dCB0byBtdWx0 aXBsZQo+IGRlc3RpbmF0aW9uIHNpbXVsdGFuZW91c2x5KSB3b3VsZCBjb25mdXNlIG1lLiBJZiB0 aGUgZGF0YSBzaGVldCB1c2UgdGhlCj4gY29uZnVzZWQgbmFtaW5nLCBJIHRoaW5rIEkgY291bGQg anVzdCBhY2NlcHQgaXQuCj4gCj4gUmVnYXJkcywKPiBDSwo+IApPSywgSSB3b3VsZCBjaGFuZ2Ug dGhlIGRlZmluaXRpb24gbmFtZSBmcm9tCkRJU1BfUkVHX0NPTkZJR19ESVNQX1JETUEwX01PVVRf RU4gdG8gRElTUF9SRUdfQ09ORklHX0RJU1BfUkRNQTBfU09VVF9FTgoKPiA+IFJlZ2FyZCwKPiA+ IFN0dQo+ID4gCj4gPiA+IAo+ID4gPiA+ICAjZGVmaW5lIFJETUExX01PVVRfRFBJMAkJCTB4Mgo+ ID4gPiA+ICAjZGVmaW5lIERQSTBfU0VMX0lOX1JETUExCQkweDEKPiA+ID4gPiAgI2RlZmluZSBD T0xPUjFfU0VMX0lOX09WTDEJCTB4MQo+ID4gPiA+IEBAIC0xNjQsNiArMTY1LDkgQEAgc3RhdGlj IHVuc2lnbmVkIGludCBtdGtfZGRwX21vdXRfZW4oZW51bSBtdGtfZGRwX2NvbXBfaWQgY3VyLAo+ ID4gPiA+ICAJfSBlbHNlIGlmIChjdXIgPT0gRERQX0NPTVBPTkVOVF9SRE1BMCAmJiBuZXh0ID09 IEREUF9DT01QT05FTlRfRFNJMikgewo+ID4gPiA+ICAJCSphZGRyID0gRElTUF9SRUdfQ09ORklH X0RJU1BfUkRNQTBfTU9VVF9FTjsKPiA+ID4gPiAgCQl2YWx1ZSA9IFJETUEwX01PVVRfRFNJMjsK PiA+ID4gPiArCX0gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfUkRNQTAgJiYgbmV4dCA9 PSBERFBfQ09NUE9ORU5UX0RTSTMpIHsKPiA+ID4gPiArCQkqYWRkciA9IERJU1BfUkVHX0NPTkZJ R19ESVNQX1JETUEwX01PVVRfRU47Cj4gPiA+ID4gKwkJdmFsdWUgPSBSRE1BMF9NT1VUX0RTSTM7 Cj4gPiA+ID4gIAl9IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX1JETUExICYmIG5leHQg PT0gRERQX0NPTVBPTkVOVF9EUEkwKSB7Cj4gPiA+ID4gIAkJKmFkZHIgPSBESVNQX1JFR19DT05G SUdfRElTUF9SRE1BMV9NT1VUX0VOOwo+ID4gPiA+ICAJCXZhbHVlID0gUkRNQTFfTU9VVF9EUEkw Owo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9k ZHBfY29tcC5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwX2NvbXAuYwo+ ID4gPiA+IGluZGV4IGZlNmZkYzAyMWZjNy4uMjJmNGM3MmZhNzg1IDEwMDY0NAo+ID4gPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMKPiA+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5jCj4gPiA+ID4g QEAgLTIyOCw3ICsyMjgsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG10a19kZHBfY29tcF9tYXRj aCBtdGtfZGRwX21hdGNoZXNbRERQX0NPTVBPTkVOVF9JRF9NQVhdID0gewo+ID4gPiA+ICAJW0RE UF9DT01QT05FTlRfRFNJMF0JPSB7IE1US19EU0ksCQkwLCBOVUxMIH0sCj4gPiA+ID4gIAlbRERQ X0NPTVBPTkVOVF9EU0kxXQk9IHsgTVRLX0RTSSwJCTEsIE5VTEwgfSwKPiA+ID4gPiAgCVtERFBf Q09NUE9ORU5UX0RTSTJdCT0geyBNVEtfRFNJLAkJMiwgTlVMTCB9LAo+ID4gPiA+IC0JW0REUF9D T01QT05FTlRfRFNJMl0JPSB7IE1US19EU0ksCQkzLCBOVUxMIH0sCj4gPiA+ID4gKwlbRERQX0NP TVBPTkVOVF9EU0kzXQk9IHsgTVRLX0RTSSwJCTMsIE5VTEwgfSwKPiA+ID4gCj4gPiA+IEkgdGhp bmsgdGhpcyBpcyBub3QgcmVsYXRlZCB0byB0aGlzIHBhdGNoLgo+ID4gT0sKPiA+IAo+ID4gPiAK PiA+ID4gUmVnYXJkcywKPiA+ID4gQ0sKPiA+ID4gCj4gPiA+ID4gIAlbRERQX0NPTVBPTkVOVF9H QU1NQV0JPSB7IE1US19ESVNQX0dBTU1BLAkwLCAmZGRwX2dhbW1hIH0sCj4gPiA+ID4gIAlbRERQ X0NPTVBPTkVOVF9PRDBdCT0geyBNVEtfRElTUF9PRCwJMCwgJmRkcF9vZCB9LAo+ID4gPiA+ICAJ W0REUF9DT01QT05FTlRfT0QxXQk9IHsgTVRLX0RJU1BfT0QsCTEsICZkZHBfb2QgfSwKPiA+ID4g Cj4gPiA+IAo+ID4gCj4gPiAKPiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: stu.hsieh@mediatek.com (Stu Hsieh) Date: Wed, 13 Jun 2018 16:52:08 +0800 Subject: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3 In-Reply-To: <1528877112.30263.24.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-14-git-send-email-stu.hsieh@mediatek.com> <1528868751.15127.10.camel@mtksdaap41> <1528875983.11190.29.camel@mtksdccf07> <1528877112.30263.24.camel@mtksdaap41> Message-ID: <1528879928.11190.39.camel@mtksdccf07> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, CK: On Wed, 2018-06-13 at 16:05 +0800, CK Hu wrote: > Hi, Stu: > > On Wed, 2018-06-13 at 15:46 +0800, Stu Hsieh wrote: > > Hi, CK: > > > > On Wed, 2018-06-13 at 13:45 +0800, CK Hu wrote: > > > Hi, Stu: > > > > > > Two inline comment. > > > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > > This patch add the connection from RDMA0 to DSI3 > > > > > > > > Signed-off-by: Stu Hsieh > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++++ > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > index c08aed8dae44..fed1b5704355 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > @@ -83,6 +83,7 @@ > > > > #define GAMMA_MOUT_EN_RDMA1 0x1 > > > > #define RDMA0_MOUT_DPI0 0x2 > > > > #define RDMA0_MOUT_DSI2 0x4 > > > > +#define RDMA0_MOUT_DSI3 0x5 > > > > > > Usually, each bit of a mout register represent a output enable. Is this > > > value 0x5 is a correct value? > > > > In hw CONFIG SPEC show as following: > > Bit(s) Name Description > > 2:0 DISP_PATH0_SOUT_SEL_IN 0 : Output to DSI0 > > 1: Ooutput to DSI1 > > 2: Ooutput to DPI > > 3: Ooutput to DPI1 > > 4: Ooutput to DSI2 > > 5: Ooutput to DSI3 > > 6 : reserved > > 7: Ooutput to DISP_UFOE > > So, the value 0x5 is correct value. > > > > From the definition, it looks like that RDMA0 could only single output > (output to only one destination at one moment). The register naming > 'DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN' (MOUT means output to multiple > destination simultaneously) would confuse me. If the data sheet use the > confused naming, I think I could just accept it. > > Regards, > CK > OK, I would change the definition name from DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN to DISP_REG_CONFIG_DISP_RDMA0_SOUT_EN > > Regard, > > Stu > > > > > > > > > #define RDMA1_MOUT_DPI0 0x2 > > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > > #define COLOR1_SEL_IN_OVL1 0x1 > > > > @@ -164,6 +165,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI2) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > > value = RDMA0_MOUT_DSI2; > > > > + } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI3) { > > > > + *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > > + value = RDMA0_MOUT_DSI3; > > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > > value = RDMA1_MOUT_DPI0; > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > index fe6fdc021fc7..22f4c72fa785 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > @@ -228,7 +228,7 @@ static const struct mtk_ddp_comp_match mtk_ddp_matches[DDP_COMPONENT_ID_MAX] = { > > > > [DDP_COMPONENT_DSI0] = { MTK_DSI, 0, NULL }, > > > > [DDP_COMPONENT_DSI1] = { MTK_DSI, 1, NULL }, > > > > [DDP_COMPONENT_DSI2] = { MTK_DSI, 2, NULL }, > > > > - [DDP_COMPONENT_DSI2] = { MTK_DSI, 3, NULL }, > > > > + [DDP_COMPONENT_DSI3] = { MTK_DSI, 3, NULL }, > > > > > > I think this is not related to this patch. > > OK > > > > > > > > Regards, > > > CK > > > > > > > [DDP_COMPONENT_GAMMA] = { MTK_DISP_GAMMA, 0, &ddp_gamma }, > > > > [DDP_COMPONENT_OD0] = { MTK_DISP_OD, 0, &ddp_od }, > > > > [DDP_COMPONENT_OD1] = { MTK_DISP_OD, 1, &ddp_od }, > > > > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id CFFD6C004E4 for ; Wed, 13 Jun 2018 08:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82EA32086A for ; Wed, 13 Jun 2018 08:52:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82EA32086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934923AbeFMIwP (ORCPT ); Wed, 13 Jun 2018 04:52:15 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:14153 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933912AbeFMIwN (ORCPT ); Wed, 13 Jun 2018 04:52:13 -0400 X-UUID: 4ac543b8a64f4994b8e72572b99e009a-20180613 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 386407530; Wed, 13 Jun 2018 16:52:10 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 13 Jun 2018 16:52:08 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 13 Jun 2018 16:52:08 +0800 Message-ID: <1528879928.11190.39.camel@mtksdccf07> Subject: Re: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3 From: Stu Hsieh To: CK Hu CC: Philipp Zabel , David Airlie , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , Date: Wed, 13 Jun 2018 16:52:08 +0800 In-Reply-To: <1528877112.30263.24.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-14-git-send-email-stu.hsieh@mediatek.com> <1528868751.15127.10.camel@mtksdaap41> <1528875983.11190.29.camel@mtksdccf07> <1528877112.30263.24.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK: On Wed, 2018-06-13 at 16:05 +0800, CK Hu wrote: > Hi, Stu: > > On Wed, 2018-06-13 at 15:46 +0800, Stu Hsieh wrote: > > Hi, CK: > > > > On Wed, 2018-06-13 at 13:45 +0800, CK Hu wrote: > > > Hi, Stu: > > > > > > Two inline comment. > > > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > > This patch add the connection from RDMA0 to DSI3 > > > > > > > > Signed-off-by: Stu Hsieh > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++++ > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > index c08aed8dae44..fed1b5704355 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > @@ -83,6 +83,7 @@ > > > > #define GAMMA_MOUT_EN_RDMA1 0x1 > > > > #define RDMA0_MOUT_DPI0 0x2 > > > > #define RDMA0_MOUT_DSI2 0x4 > > > > +#define RDMA0_MOUT_DSI3 0x5 > > > > > > Usually, each bit of a mout register represent a output enable. Is this > > > value 0x5 is a correct value? > > > > In hw CONFIG SPEC show as following: > > Bit(s) Name Description > > 2:0 DISP_PATH0_SOUT_SEL_IN 0 : Output to DSI0 > > 1: Ooutput to DSI1 > > 2: Ooutput to DPI > > 3: Ooutput to DPI1 > > 4: Ooutput to DSI2 > > 5: Ooutput to DSI3 > > 6 : reserved > > 7: Ooutput to DISP_UFOE > > So, the value 0x5 is correct value. > > > > From the definition, it looks like that RDMA0 could only single output > (output to only one destination at one moment). The register naming > 'DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN' (MOUT means output to multiple > destination simultaneously) would confuse me. If the data sheet use the > confused naming, I think I could just accept it. > > Regards, > CK > OK, I would change the definition name from DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN to DISP_REG_CONFIG_DISP_RDMA0_SOUT_EN > > Regard, > > Stu > > > > > > > > > #define RDMA1_MOUT_DPI0 0x2 > > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > > #define COLOR1_SEL_IN_OVL1 0x1 > > > > @@ -164,6 +165,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI2) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > > value = RDMA0_MOUT_DSI2; > > > > + } else if (cur == DDP_COMPONENT_RDMA0 && next == DDP_COMPONENT_DSI3) { > > > > + *addr = DISP_REG_CONFIG_DISP_RDMA0_MOUT_EN; > > > > + value = RDMA0_MOUT_DSI3; > > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > > value = RDMA1_MOUT_DPI0; > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > index fe6fdc021fc7..22f4c72fa785 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > > > @@ -228,7 +228,7 @@ static const struct mtk_ddp_comp_match mtk_ddp_matches[DDP_COMPONENT_ID_MAX] = { > > > > [DDP_COMPONENT_DSI0] = { MTK_DSI, 0, NULL }, > > > > [DDP_COMPONENT_DSI1] = { MTK_DSI, 1, NULL }, > > > > [DDP_COMPONENT_DSI2] = { MTK_DSI, 2, NULL }, > > > > - [DDP_COMPONENT_DSI2] = { MTK_DSI, 3, NULL }, > > > > + [DDP_COMPONENT_DSI3] = { MTK_DSI, 3, NULL }, > > > > > > I think this is not related to this patch. > > OK > > > > > > > > Regards, > > > CK > > > > > > > [DDP_COMPONENT_GAMMA] = { MTK_DISP_GAMMA, 0, &ddp_gamma }, > > > > [DDP_COMPONENT_OD0] = { MTK_DISP_OD, 0, &ddp_od }, > > > > [DDP_COMPONENT_OD1] = { MTK_DISP_OD, 1, &ddp_od }, > > > > > > > > > > > >