From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stu Hsieh Subject: Re: [PATCH 14/28] drm/mediatek: add connection from RDMA1 to DPI1 Date: Wed, 13 Jun 2018 16:53:31 +0800 Message-ID: <1528880011.11190.41.camel@mtksdccf07> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-15-git-send-email-stu.hsieh@mediatek.com> <1528870410.15127.11.camel@mtksdaap41> <1528876574.11190.32.camel@mtksdccf07> <1528878446.30263.30.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1528878446.30263.30.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: CK Hu Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIENLOgoKT24gV2VkLCAyMDE4LTA2LTEzIGF0IDE2OjI3ICswODAwLCBDSyBIdSB3cm90ZToK PiBIaSwgU3R1Ogo+IAo+IE9uIFdlZCwgMjAxOC0wNi0xMyBhdCAxNTo1NiArMDgwMCwgU3R1IEhz aWVoIHdyb3RlOgo+ID4gSGksIENLOgo+ID4gCj4gPiBPbiBXZWQsIDIwMTgtMDYtMTMgYXQgMTQ6 MTMgKzA4MDAsIENLIEh1IHdyb3RlOgo+ID4gPiBIaSwgU3R1Ogo+ID4gPiAKPiA+ID4gT24gTW9u LCAyMDE4LTA2LTExIGF0IDExOjI2ICswODAwLCBTdHUgSHNpZWggd3JvdGU6Cj4gPiA+ID4gVGhp cyBwYXRjaCBhZGQgdGhlIGNvbm5lY3Rpb24gZnJvbSBSRE1BMSB0byBEUEkxCj4gPiA+ID4gCj4g PiA+ID4gU2lnbmVkLW9mZi1ieTogU3R1IEhzaWVoIDxzdHUuaHNpZWhAbWVkaWF0ZWsuY29tPgo+ ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAu YyB8IDggKysrKysrKysKPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQo+ ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRr X2RybV9kZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcC5jCj4gPiA+ ID4gaW5kZXggZmVkMWI1NzA0MzU1Li40YWJkNWRhYmVjY2YgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMKPiA+ID4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYwo+ID4gPiA+IEBAIC04NSw3ICs4NSw5 IEBACj4gPiA+ID4gICNkZWZpbmUgUkRNQTBfTU9VVF9EU0kyCQkJMHg0Cj4gPiA+ID4gICNkZWZp bmUgUkRNQTBfTU9VVF9EU0kzCQkJMHg1Cj4gPiA+ID4gICNkZWZpbmUgUkRNQTFfTU9VVF9EUEkw CQkJMHgyCj4gPiA+ID4gKyNkZWZpbmUgUkRNQTFfTU9VVF9EUEkxCQkJMHgzCj4gPiA+IAo+ID4g PiBVc3VhbGx5LCBlYWNoIGJpdCBvZiBhIG1vdXQgcmVnaXN0ZXIgcmVwcmVzZW50IGEgb3V0cHV0 IGVuYWJsZS4gSXMgdGhpcwo+ID4gPiB2YWx1ZSAweDMgYSBjb3JyZWN0IHZhbHVlPwo+ID4gPiAK PiA+ID4gUmVnYXJkcywKPiA+ID4gQ0sKPiA+ID4gCj4gPiBJbiBIVyBDT05GSUcgU1BFQyBzaG93 IGFzIGZvbGxvd2luZwo+ID4gCj4gPiBCaXQocykJTmFtZQkJCURlc2NyaXB0aW9uCj4gPiAyOjAJ RElTUF9QQVRIMV9TT1VUX1NFTF9JTgkwIDogT3V0cHV0IHRvIERTSTAKPiA+IAkJCQkxOiAgT291 dHB1dCB0byBEU0kxCj4gPiAJCQkJMjogIE9vdXRwdXQgdG8gRFBJCj4gPiAJCQkJMzogIE9vdXRw dXQgdG8gRFBJMQo+ID4gCQkJCTQ6ICBPb3V0cHV0IHRvIERTSTIKPiA+IAkJCQk1OiAgT291dHB1 dCB0byBEU0kzCj4gPiAJCQkJNiA6IHJlc2VydmVkCj4gPiAJCQkJNzogIE9vdXRwdXQgdG8gRElT UF9VRk9FCj4gPiAKPiA+IFNvLCAweDMgaXMgY29ycmVjdCB2YWx1ZQo+IAo+IEl0IGxvb2tzIGxp a2UgdGhhdCBSRE1BMSBvdXRwdXQgaXMgYWxzbyBTT1VULCB1c2UgdGhlIG5hbWluZyBTT1VUIHdv dWxkCj4gYmUgYmV0dGVyLiAKPiAKPiBSZWdhcmRzLAo+IENLCj4gCk9LLCBJIHdvdWxkIGNoYW5n ZSB0aGUgZGVmaW5pdGlvbiBuYW1lIGZyb20KRElTUF9SRUdfQ09ORklHX0RJU1BfUkRNQTFfTU9V VF9FTiB0byBESVNQX1JFR19DT05GSUdfRElTUF9SRE1BMV9TT1VUX0VOCgpSZWdhcmQsClNUdQoK PiA+IAo+ID4gUmVnYXJkLAo+ID4gU3R1Cj4gPiAKPiA+IAo+ID4gPiA+ICAjZGVmaW5lIERQSTBf U0VMX0lOX1JETUExCQkweDEKPiA+ID4gPiArI2RlZmluZSBEUEkxX1NFTF9JTl9SRE1BMQkJKDB4 MSA8PCA4KQo+ID4gPiA+ICAjZGVmaW5lIENPTE9SMV9TRUxfSU5fT1ZMMQkJMHgxCj4gPiA+ID4g IAo+ID4gPiA+ICAjZGVmaW5lIE9WTF9NT1VUX0VOX1JETUEJCTB4MQo+ID4gPiA+IEBAIC0xNzEs NiArMTczLDkgQEAgc3RhdGljIHVuc2lnbmVkIGludCBtdGtfZGRwX21vdXRfZW4oZW51bSBtdGtf ZGRwX2NvbXBfaWQgY3VyLAo+ID4gPiA+ICAJfSBlbHNlIGlmIChjdXIgPT0gRERQX0NPTVBPTkVO VF9SRE1BMSAmJiBuZXh0ID09IEREUF9DT01QT05FTlRfRFBJMCkgewo+ID4gPiA+ICAJCSphZGRy ID0gRElTUF9SRUdfQ09ORklHX0RJU1BfUkRNQTFfTU9VVF9FTjsKPiA+ID4gPiAgCQl2YWx1ZSA9 IFJETUExX01PVVRfRFBJMDsKPiA+ID4gPiArCX0gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05F TlRfUkRNQTEgJiYgbmV4dCA9PSBERFBfQ09NUE9ORU5UX0RQSTEpIHsKPiA+ID4gPiArCQkqYWRk ciA9IERJU1BfUkVHX0NPTkZJR19ESVNQX1JETUExX01PVVRfRU47Cj4gPiA+ID4gKwkJdmFsdWUg PSBSRE1BMV9NT1VUX0RQSTE7Cj4gPiA+ID4gIAl9IGVsc2Ugewo+ID4gPiA+ICAJCXZhbHVlID0g MDsKPiA+ID4gPiAgCX0KPiA+ID4gPiBAQCAtMTkwLDYgKzE5NSw5IEBAIHN0YXRpYyB1bnNpZ25l ZCBpbnQgbXRrX2RkcF9zZWxfaW4oZW51bSBtdGtfZGRwX2NvbXBfaWQgY3VyLAo+ID4gPiA+ICAJ fSBlbHNlIGlmIChjdXIgPT0gRERQX0NPTVBPTkVOVF9SRE1BMSAmJiBuZXh0ID09IEREUF9DT01Q T05FTlRfRFBJMCkgewo+ID4gPiA+ICAJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RQSV9TRUxf SU47Cj4gPiA+ID4gIAkJdmFsdWUgPSBEUEkwX1NFTF9JTl9SRE1BMTsKPiA+ID4gPiArCX0gZWxz ZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfUkRNQTEgJiYgbmV4dCA9PSBERFBfQ09NUE9ORU5U X0RQSTEpIHsKPiA+ID4gPiArCQkqYWRkciA9IERJU1BfUkVHX0NPTkZJR19EUElfU0VMX0lOOwo+ ID4gPiA+ICsJCXZhbHVlID0gRFBJMV9TRUxfSU5fUkRNQTE7Cj4gPiA+ID4gIAl9IGVsc2UgaWYg KGN1ciA9PSBERFBfQ09NUE9ORU5UX09WTDEgJiYgbmV4dCA9PSBERFBfQ09NUE9ORU5UX0NPTE9S MSkgewo+ID4gPiA+ICAJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RJU1BfQ09MT1IxX1NFTF9J TjsKPiA+ID4gPiAgCQl2YWx1ZSA9IENPTE9SMV9TRUxfSU5fT1ZMMTsKPiA+ID4gCj4gPiA+IAo+ ID4gCj4gPiAKPiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: stu.hsieh@mediatek.com (Stu Hsieh) Date: Wed, 13 Jun 2018 16:53:31 +0800 Subject: [PATCH 14/28] drm/mediatek: add connection from RDMA1 to DPI1 In-Reply-To: <1528878446.30263.30.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-15-git-send-email-stu.hsieh@mediatek.com> <1528870410.15127.11.camel@mtksdaap41> <1528876574.11190.32.camel@mtksdccf07> <1528878446.30263.30.camel@mtksdaap41> Message-ID: <1528880011.11190.41.camel@mtksdccf07> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, CK: On Wed, 2018-06-13 at 16:27 +0800, CK Hu wrote: > Hi, Stu: > > On Wed, 2018-06-13 at 15:56 +0800, Stu Hsieh wrote: > > Hi, CK: > > > > On Wed, 2018-06-13 at 14:13 +0800, CK Hu wrote: > > > Hi, Stu: > > > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > > This patch add the connection from RDMA1 to DPI1 > > > > > > > > Signed-off-by: Stu Hsieh > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > index fed1b5704355..4abd5dabeccf 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > @@ -85,7 +85,9 @@ > > > > #define RDMA0_MOUT_DSI2 0x4 > > > > #define RDMA0_MOUT_DSI3 0x5 > > > > #define RDMA1_MOUT_DPI0 0x2 > > > > +#define RDMA1_MOUT_DPI1 0x3 > > > > > > Usually, each bit of a mout register represent a output enable. Is this > > > value 0x3 a correct value? > > > > > > Regards, > > > CK > > > > > In HW CONFIG SPEC show as following > > > > Bit(s) Name Description > > 2:0 DISP_PATH1_SOUT_SEL_IN 0 : Output to DSI0 > > 1: Ooutput to DSI1 > > 2: Ooutput to DPI > > 3: Ooutput to DPI1 > > 4: Ooutput to DSI2 > > 5: Ooutput to DSI3 > > 6 : reserved > > 7: Ooutput to DISP_UFOE > > > > So, 0x3 is correct value > > It looks like that RDMA1 output is also SOUT, use the naming SOUT would > be better. > > Regards, > CK > OK, I would change the definition name from DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN to DISP_REG_CONFIG_DISP_RDMA1_SOUT_EN Regard, STu > > > > Regard, > > Stu > > > > > > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > > +#define DPI1_SEL_IN_RDMA1 (0x1 << 8) > > > > #define COLOR1_SEL_IN_OVL1 0x1 > > > > > > > > #define OVL_MOUT_EN_RDMA 0x1 > > > > @@ -171,6 +173,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > > value = RDMA1_MOUT_DPI0; > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > > + value = RDMA1_MOUT_DPI1; > > > > } else { > > > > value = 0; > > > > } > > > > @@ -190,6 +195,9 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > value = DPI0_SEL_IN_RDMA1; > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > + value = DPI1_SEL_IN_RDMA1; > > > > } else if (cur == DDP_COMPONENT_OVL1 && next == DDP_COMPONENT_COLOR1) { > > > > *addr = DISP_REG_CONFIG_DISP_COLOR1_SEL_IN; > > > > value = COLOR1_SEL_IN_OVL1; > > > > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id A44DBC004E4 for ; Wed, 13 Jun 2018 08:53:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6367F208B2 for ; Wed, 13 Jun 2018 08:53:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6367F208B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935007AbeFMIxj (ORCPT ); Wed, 13 Jun 2018 04:53:39 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:9417 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933732AbeFMIxh (ORCPT ); Wed, 13 Jun 2018 04:53:37 -0400 X-UUID: 871c162f13b74c738a4cb7d54c44bbca-20180613 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 765725271; Wed, 13 Jun 2018 16:53:33 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 13 Jun 2018 16:53:31 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 13 Jun 2018 16:53:31 +0800 Message-ID: <1528880011.11190.41.camel@mtksdccf07> Subject: Re: [PATCH 14/28] drm/mediatek: add connection from RDMA1 to DPI1 From: Stu Hsieh To: CK Hu CC: Philipp Zabel , David Airlie , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , Date: Wed, 13 Jun 2018 16:53:31 +0800 In-Reply-To: <1528878446.30263.30.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-15-git-send-email-stu.hsieh@mediatek.com> <1528870410.15127.11.camel@mtksdaap41> <1528876574.11190.32.camel@mtksdccf07> <1528878446.30263.30.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK: On Wed, 2018-06-13 at 16:27 +0800, CK Hu wrote: > Hi, Stu: > > On Wed, 2018-06-13 at 15:56 +0800, Stu Hsieh wrote: > > Hi, CK: > > > > On Wed, 2018-06-13 at 14:13 +0800, CK Hu wrote: > > > Hi, Stu: > > > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > > This patch add the connection from RDMA1 to DPI1 > > > > > > > > Signed-off-by: Stu Hsieh > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > index fed1b5704355..4abd5dabeccf 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > @@ -85,7 +85,9 @@ > > > > #define RDMA0_MOUT_DSI2 0x4 > > > > #define RDMA0_MOUT_DSI3 0x5 > > > > #define RDMA1_MOUT_DPI0 0x2 > > > > +#define RDMA1_MOUT_DPI1 0x3 > > > > > > Usually, each bit of a mout register represent a output enable. Is this > > > value 0x3 a correct value? > > > > > > Regards, > > > CK > > > > > In HW CONFIG SPEC show as following > > > > Bit(s) Name Description > > 2:0 DISP_PATH1_SOUT_SEL_IN 0 : Output to DSI0 > > 1: Ooutput to DSI1 > > 2: Ooutput to DPI > > 3: Ooutput to DPI1 > > 4: Ooutput to DSI2 > > 5: Ooutput to DSI3 > > 6 : reserved > > 7: Ooutput to DISP_UFOE > > > > So, 0x3 is correct value > > It looks like that RDMA1 output is also SOUT, use the naming SOUT would > be better. > > Regards, > CK > OK, I would change the definition name from DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN to DISP_REG_CONFIG_DISP_RDMA1_SOUT_EN Regard, STu > > > > Regard, > > Stu > > > > > > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > > +#define DPI1_SEL_IN_RDMA1 (0x1 << 8) > > > > #define COLOR1_SEL_IN_OVL1 0x1 > > > > > > > > #define OVL_MOUT_EN_RDMA 0x1 > > > > @@ -171,6 +173,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > > value = RDMA1_MOUT_DPI0; > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DISP_RDMA1_MOUT_EN; > > > > + value = RDMA1_MOUT_DPI1; > > > > } else { > > > > value = 0; > > > > } > > > > @@ -190,6 +195,9 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > value = DPI0_SEL_IN_RDMA1; > > > > + } else if (cur == DDP_COMPONENT_RDMA1 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > + value = DPI1_SEL_IN_RDMA1; > > > > } else if (cur == DDP_COMPONENT_OVL1 && next == DDP_COMPONENT_COLOR1) { > > > > *addr = DISP_REG_CONFIG_DISP_COLOR1_SEL_IN; > > > > value = COLOR1_SEL_IN_OVL1; > > > > > > > > > > > >