From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stu Hsieh Subject: Re: [PATCH 19/28] drm/mediatek: add connection from RDMA2 to DPI1 Date: Wed, 13 Jun 2018 16:58:11 +0800 Message-ID: <1528880291.11190.45.camel@mtksdccf07> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-20-git-send-email-stu.hsieh@mediatek.com> <1528874037.30263.6.camel@mtksdaap41> <1528876862.11190.35.camel@mtksdccf07> <1528877675.30263.27.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1528877675.30263.27.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: CK Hu Cc: Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIENLOgoKT24gV2VkLCAyMDE4LTA2LTEzIGF0IDE2OjE0ICswODAwLCBDSyBIdSB3cm90ZToK PiBIaSwgU3R1Ogo+IAo+IE9uIFdlZCwgMjAxOC0wNi0xMyBhdCAxNjowMSArMDgwMCwgU3R1IEhz aWVoIHdyb3RlOgo+ID4gSGksIENLOgo+ID4gCj4gPiAKPiA+IE9uIFdlZCwgMjAxOC0wNi0xMyBh dCAxNToxMyArMDgwMCwgQ0sgSHUgd3JvdGU6Cj4gPiA+IEhpLCBTdHU6Cj4gPiA+IAo+ID4gPiBP biBNb24sIDIwMTgtMDYtMTEgYXQgMTE6MjYgKzA4MDAsIFN0dSBIc2llaCB3cm90ZToKPiA+ID4g PiBUaGlzIHBhdGNoIGFkZCB0aGUgY29ubmVjdGlvbiBmcm9tIFJETUEyIHRvIERQSTEKPiA+ID4g PiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBTdHUgSHNpZWggPHN0dS5oc2llaEBtZWRpYXRlay5j b20+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJt X2RkcC5jIHwgOCArKysrKysrKwo+ID4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25z KCspCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRl ay9tdGtfZHJtX2RkcC5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZGRwLmMK PiA+ID4gPiBpbmRleCAzMWEwODMyZWY5ZWMuLjJkODgzODE1ZDc5YyAxMDA2NDQKPiA+ID4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYwo+ID4gPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcC5jCj4gPiA+ID4gQEAgLTkzLDkg KzkzLDExIEBACj4gPiA+ID4gICNkZWZpbmUgUkRNQTFfTU9VVF9EUEkwCQkJMHgyCj4gPiA+ID4g ICNkZWZpbmUgUkRNQTFfTU9VVF9EUEkxCQkJMHgzCj4gPiA+ID4gICNkZWZpbmUgUkRNQTJfTU9V VF9EUEkwCQkJMHgyCj4gPiA+ID4gKyNkZWZpbmUgUkRNQTJfTU9VVF9EUEkxCQkJMHgzCj4gPiA+ IAo+ID4gPiBVc3VhbGx5LCBlYWNoIGJpdCBvZiBhIG1vdXQgcmVnaXN0ZXIgcmVwcmVzZW50IGEg b3V0cHV0IGVuYWJsZS4gSXMgdGhpcwo+ID4gPiB2YWx1ZSAweDMgYSBjb3JyZWN0IHZhbHVlPwo+ ID4gPiAKPiA+ID4gUmVnYXJkcywKPiA+ID4gQ0sKPiA+ID4gCj4gPiBJbiBIVyBDT05GSUcgU1BF QyBvciBNVDI3MTJfRTJfTU1TWVNfQ2hhbmdlX25vdGUgc2hvdyBhcyBmb2xsb3dpbmc6Cj4gPiAK PiA+IEJpdChzKQlOYW1lCQkJRGVzY3JpcHRpb24KPiA+IDI6MAlESVNQX1JETUEyX1NPVVRfU0VM X0lOCTA6IG91dHB1dCB0byBkc2kwCj4gPiAJCQkJMTogb3V0cHR1IHRvIGRzaTEKPiA+IAkJCQky OiBvdXRwdXQgdG8gZHBpMAo+ID4gCQkJCTM6IG91dHB1dCB0byBkcGkxCj4gPiAJCQkJNDogb3V0 cHV0IHRvIGRzaTIKPiA+IAkJCQk1OiBvdXRwdXQgdG8gZHNpMwo+ID4gCj4gPiBTbywgMHgzIGlz IGNvcnJlY3QgdmFsdWUuCj4gCj4gVGhlIGRhdGEgc2hlZXQgdXNlIHRoZSB0ZXJtIFNPVVQgbWF0 Y2ggaXRzIGZ1bmN0aW9uLCBzbyBJIHRoaW5rIGRyaXZlcgo+IGhhdmUgYmV0dGVyIGNoYW5nZSB0 aGUgbmFtaW5nIHRvIFNPVVQuCj4gCj4gUmVnYXJkcywKPiBDSwo+IAoKVGhlIGRlZmluaXRpb24g RElTUF9SRUdfQ09ORklHX0RJU1BfUkRNQTJfU09VVCBpcyB1c2UgdGVybSBTT1VUIGluIHRoaXMK cGF0Y2guCgpSZWdhcmQsClN0dQoKPiA+IAo+ID4gUmVnYXJkLAo+ID4gU3R1Cj4gPiAKPiA+ID4g PiAgI2RlZmluZSBEUEkwX1NFTF9JTl9SRE1BMQkJMHgxCj4gPiA+ID4gICNkZWZpbmUgRFBJMF9T RUxfSU5fUkRNQTIJCTB4Mwo+ID4gPiA+ICAjZGVmaW5lIERQSTFfU0VMX0lOX1JETUExCQkoMHgx IDw8IDgpCj4gPiA+ID4gKyNkZWZpbmUgRFBJMV9TRUxfSU5fUkRNQTIJCSgweDMgPDwgOCkKPiA+ ID4gPiAgI2RlZmluZSBEU0kxX1NFTF9JTl9SRE1BMQkJMHgxCj4gPiA+ID4gICNkZWZpbmUgRFNJ Ml9TRUxfSU5fUkRNQTEJCSgweDEgPDwgMTYpCj4gPiA+ID4gICNkZWZpbmUgRFNJM19TRUxfSU5f UkRNQTEJCSgweDEgPDwgMTYpCj4gPiA+ID4gQEAgLTE5OSw2ICsyMDEsOSBAQCBzdGF0aWMgdW5z aWduZWQgaW50IG10a19kZHBfbW91dF9lbihlbnVtIG10a19kZHBfY29tcF9pZCBjdXIsCj4gPiA+ ID4gIAl9IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9ORU5UX1JETUEyICYmIG5leHQgPT0gRERQ X0NPTVBPTkVOVF9EUEkwKSB7Cj4gPiA+ID4gIAkJKmFkZHIgPSBESVNQX1JFR19DT05GSUdfRElT UF9SRE1BMl9TT1VUOwo+ID4gPiA+ICAJCXZhbHVlID0gUkRNQTJfTU9VVF9EUEkwOwo+ID4gPiA+ ICsJfSBlbHNlIGlmIChjdXIgPT0gRERQX0NPTVBPTkVOVF9SRE1BMiAmJiBuZXh0ID09IEREUF9D T01QT05FTlRfRFBJMSkgewo+ID4gPiA+ICsJCSphZGRyID0gRElTUF9SRUdfQ09ORklHX0RJU1Bf UkRNQTJfU09VVDsKPiA+ID4gPiArCQl2YWx1ZSA9IFJETUEyX01PVVRfRFBJMTsKPiA+ID4gPiAg CX0gZWxzZSB7Cj4gPiA+ID4gIAkJdmFsdWUgPSAwOwo+ID4gPiA+ICAJfQo+ID4gPiA+IEBAIC0y MzMsNiArMjM4LDkgQEAgc3RhdGljIHVuc2lnbmVkIGludCBtdGtfZGRwX3NlbF9pbihlbnVtIG10 a19kZHBfY29tcF9pZCBjdXIsCj4gPiA+ID4gIAl9IGVsc2UgaWYgKGN1ciA9PSBERFBfQ09NUE9O RU5UX1JETUEyICYmIG5leHQgPT0gRERQX0NPTVBPTkVOVF9EUEkwKSB7Cj4gPiA+ID4gIAkJKmFk ZHIgPSBESVNQX1JFR19DT05GSUdfRFBJX1NFTF9JTjsKPiA+ID4gPiAgCQl2YWx1ZSA9IERQSTBf U0VMX0lOX1JETUEyOwo+ID4gPiA+ICsJfSBlbHNlIGlmIChjdXIgPT0gRERQX0NPTVBPTkVOVF9S RE1BMiAmJiBuZXh0ID09IEREUF9DT01QT05FTlRfRFBJMSkgewo+ID4gPiA+ICsJCSphZGRyID0g RElTUF9SRUdfQ09ORklHX0RQSV9TRUxfSU47Cj4gPiA+ID4gKwkJdmFsdWUgPSBEUEkxX1NFTF9J Tl9SRE1BMjsKPiA+ID4gPiAgCX0gZWxzZSBpZiAoY3VyID09IEREUF9DT01QT05FTlRfT1ZMMSAm JiBuZXh0ID09IEREUF9DT01QT05FTlRfQ09MT1IxKSB7Cj4gPiA+ID4gIAkJKmFkZHIgPSBESVNQ X1JFR19DT05GSUdfRElTUF9DT0xPUjFfU0VMX0lOOwo+ID4gPiA+ICAJCXZhbHVlID0gQ09MT1Ix X1NFTF9JTl9PVkwxOwo+ID4gPiAKPiA+ID4gCj4gPiAKPiA+IAo+IAo+IAoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: stu.hsieh@mediatek.com (Stu Hsieh) Date: Wed, 13 Jun 2018 16:58:11 +0800 Subject: [PATCH 19/28] drm/mediatek: add connection from RDMA2 to DPI1 In-Reply-To: <1528877675.30263.27.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-20-git-send-email-stu.hsieh@mediatek.com> <1528874037.30263.6.camel@mtksdaap41> <1528876862.11190.35.camel@mtksdccf07> <1528877675.30263.27.camel@mtksdaap41> Message-ID: <1528880291.11190.45.camel@mtksdccf07> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, CK: On Wed, 2018-06-13 at 16:14 +0800, CK Hu wrote: > Hi, Stu: > > On Wed, 2018-06-13 at 16:01 +0800, Stu Hsieh wrote: > > Hi, CK: > > > > > > On Wed, 2018-06-13 at 15:13 +0800, CK Hu wrote: > > > Hi, Stu: > > > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > > This patch add the connection from RDMA2 to DPI1 > > > > > > > > Signed-off-by: Stu Hsieh > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > index 31a0832ef9ec..2d883815d79c 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > @@ -93,9 +93,11 @@ > > > > #define RDMA1_MOUT_DPI0 0x2 > > > > #define RDMA1_MOUT_DPI1 0x3 > > > > #define RDMA2_MOUT_DPI0 0x2 > > > > +#define RDMA2_MOUT_DPI1 0x3 > > > > > > Usually, each bit of a mout register represent a output enable. Is this > > > value 0x3 a correct value? > > > > > > Regards, > > > CK > > > > > In HW CONFIG SPEC or MT2712_E2_MMSYS_Change_note show as following: > > > > Bit(s) Name Description > > 2:0 DISP_RDMA2_SOUT_SEL_IN 0: output to dsi0 > > 1: outptu to dsi1 > > 2: output to dpi0 > > 3: output to dpi1 > > 4: output to dsi2 > > 5: output to dsi3 > > > > So, 0x3 is correct value. > > The data sheet use the term SOUT match its function, so I think driver > have better change the naming to SOUT. > > Regards, > CK > The definition DISP_REG_CONFIG_DISP_RDMA2_SOUT is use term SOUT in this patch. Regard, Stu > > > > Regard, > > Stu > > > > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > > #define DPI0_SEL_IN_RDMA2 0x3 > > > > #define DPI1_SEL_IN_RDMA1 (0x1 << 8) > > > > +#define DPI1_SEL_IN_RDMA2 (0x3 << 8) > > > > #define DSI1_SEL_IN_RDMA1 0x1 > > > > #define DSI2_SEL_IN_RDMA1 (0x1 << 16) > > > > #define DSI3_SEL_IN_RDMA1 (0x1 << 16) > > > > @@ -199,6 +201,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA2_SOUT; > > > > value = RDMA2_MOUT_DPI0; > > > > + } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DISP_RDMA2_SOUT; > > > > + value = RDMA2_MOUT_DPI1; > > > > } else { > > > > value = 0; > > > > } > > > > @@ -233,6 +238,9 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > value = DPI0_SEL_IN_RDMA2; > > > > + } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > + value = DPI1_SEL_IN_RDMA2; > > > > } else if (cur == DDP_COMPONENT_OVL1 && next == DDP_COMPONENT_COLOR1) { > > > > *addr = DISP_REG_CONFIG_DISP_COLOR1_SEL_IN; > > > > value = COLOR1_SEL_IN_OVL1; > > > > > > > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,UNPARSEABLE_RELAY,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 6DB21C433EF for ; Wed, 13 Jun 2018 08:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2484920891 for ; Wed, 13 Jun 2018 08:58:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2484920891 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754534AbeFMI6U (ORCPT ); Wed, 13 Jun 2018 04:58:20 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:39664 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754475AbeFMI6R (ORCPT ); Wed, 13 Jun 2018 04:58:17 -0400 X-UUID: e11c36332d6e484a804267f28679ffad-20180613 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1795494233; Wed, 13 Jun 2018 16:58:13 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n1.mediatek.inc (172.21.101.181) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 13 Jun 2018 16:58:12 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Wed, 13 Jun 2018 16:58:11 +0800 Message-ID: <1528880291.11190.45.camel@mtksdccf07> Subject: Re: [PATCH 19/28] drm/mediatek: add connection from RDMA2 to DPI1 From: Stu Hsieh To: CK Hu CC: Philipp Zabel , David Airlie , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , Date: Wed, 13 Jun 2018 16:58:11 +0800 In-Reply-To: <1528877675.30263.27.camel@mtksdaap41> References: <1528687580-549-1-git-send-email-stu.hsieh@mediatek.com> <1528687580-549-20-git-send-email-stu.hsieh@mediatek.com> <1528874037.30263.6.camel@mtksdaap41> <1528876862.11190.35.camel@mtksdccf07> <1528877675.30263.27.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK: On Wed, 2018-06-13 at 16:14 +0800, CK Hu wrote: > Hi, Stu: > > On Wed, 2018-06-13 at 16:01 +0800, Stu Hsieh wrote: > > Hi, CK: > > > > > > On Wed, 2018-06-13 at 15:13 +0800, CK Hu wrote: > > > Hi, Stu: > > > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > > This patch add the connection from RDMA2 to DPI1 > > > > > > > > Signed-off-by: Stu Hsieh > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > index 31a0832ef9ec..2d883815d79c 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > > > @@ -93,9 +93,11 @@ > > > > #define RDMA1_MOUT_DPI0 0x2 > > > > #define RDMA1_MOUT_DPI1 0x3 > > > > #define RDMA2_MOUT_DPI0 0x2 > > > > +#define RDMA2_MOUT_DPI1 0x3 > > > > > > Usually, each bit of a mout register represent a output enable. Is this > > > value 0x3 a correct value? > > > > > > Regards, > > > CK > > > > > In HW CONFIG SPEC or MT2712_E2_MMSYS_Change_note show as following: > > > > Bit(s) Name Description > > 2:0 DISP_RDMA2_SOUT_SEL_IN 0: output to dsi0 > > 1: outptu to dsi1 > > 2: output to dpi0 > > 3: output to dpi1 > > 4: output to dsi2 > > 5: output to dsi3 > > > > So, 0x3 is correct value. > > The data sheet use the term SOUT match its function, so I think driver > have better change the naming to SOUT. > > Regards, > CK > The definition DISP_REG_CONFIG_DISP_RDMA2_SOUT is use term SOUT in this patch. Regard, Stu > > > > Regard, > > Stu > > > > > > #define DPI0_SEL_IN_RDMA1 0x1 > > > > #define DPI0_SEL_IN_RDMA2 0x3 > > > > #define DPI1_SEL_IN_RDMA1 (0x1 << 8) > > > > +#define DPI1_SEL_IN_RDMA2 (0x3 << 8) > > > > #define DSI1_SEL_IN_RDMA1 0x1 > > > > #define DSI2_SEL_IN_RDMA1 (0x1 << 16) > > > > #define DSI3_SEL_IN_RDMA1 (0x1 << 16) > > > > @@ -199,6 +201,9 @@ static unsigned int mtk_ddp_mout_en(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DISP_RDMA2_SOUT; > > > > value = RDMA2_MOUT_DPI0; > > > > + } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DISP_RDMA2_SOUT; > > > > + value = RDMA2_MOUT_DPI1; > > > > } else { > > > > value = 0; > > > > } > > > > @@ -233,6 +238,9 @@ static unsigned int mtk_ddp_sel_in(enum mtk_ddp_comp_id cur, > > > > } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI0) { > > > > *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > value = DPI0_SEL_IN_RDMA2; > > > > + } else if (cur == DDP_COMPONENT_RDMA2 && next == DDP_COMPONENT_DPI1) { > > > > + *addr = DISP_REG_CONFIG_DPI_SEL_IN; > > > > + value = DPI1_SEL_IN_RDMA2; > > > > } else if (cur == DDP_COMPONENT_OVL1 && next == DDP_COMPONENT_COLOR1) { > > > > *addr = DISP_REG_CONFIG_DISP_COLOR1_SEL_IN; > > > > value = COLOR1_SEL_IN_OVL1; > > > > > > > > > > > >