From: Mika Kahola <mika.kahola@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_flip: Set duration for subtest from command line
Date: Wed, 13 Jun 2018 15:49:59 +0300 [thread overview]
Message-ID: <1528894199.27355.46.camel@intel.com> (raw)
In-Reply-To: <152889162359.13958.13244997892653329610@mail.alporthouse.com>
On Wed, 2018-06-13 at 13:07 +0100, Chris Wilson wrote:
> Quoting Mika Kahola (2018-06-13 12:30:37)
> >
> > To reduce the execution time of kms_flip test on CI, let's move
> > subtest
> > duration parameter as command line option. The default subtest
> > duration
> > is 0 seconds meaning that the subtest is run only once.
> >
> > The patch reduces the kms_flip binary mode execution time on
> > Geminilake from
> > 1189 seconds down to 307 seconds with default subtest duration.
> >
> > No functional changes on subtests.
> That's a bold claim, since you change the very essence of the test.
> Going from a few commits to one is a big change, a supplementary set
> of
> tests but not a replacement.
What I meant to say by this statement was that I didn't change any
functionality of the subtests itself. The patch introduces a command
line option to set the duration of the subtest instead of hardcoded
one. In that sense, I didn't considered it such a big change as you
still have the option to set the test duration.
> -Chris
--
Mika Kahola - Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-06-13 12:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 11:19 [igt-dev] [PATCH i-g-t 0/2] tests/kms_flip: Binary mode optimizations Mika Kahola
2018-06-12 11:19 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_flip: Set duration for subtest from command line Mika Kahola
2018-06-13 11:30 ` [igt-dev] [PATCH i-g-t v2 " Mika Kahola
2018-06-13 12:07 ` Chris Wilson
2018-06-13 12:49 ` Mika Kahola [this message]
2018-06-12 11:19 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_flip: Change 2x tests execution order Mika Kahola
2018-06-13 11:05 ` Petri Latvala
2018-06-13 11:06 ` Mika Kahola
2018-06-12 12:13 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: Binary mode optimizations Patchwork
2018-06-12 15:28 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-06-13 11:57 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: Binary mode optimizations (rev2) Patchwork
2018-06-13 14:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-06-13 12:58 [igt-dev] [PATCH i-g-t v2 0/2] tests/kms_flip: Binary mode optimizations Mika Kahola
2018-06-13 12:58 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_flip: Set duration for subtest from command line Mika Kahola
2018-06-13 13:57 ` Ville Syrjälä
2018-06-14 10:40 ` Mika Kahola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528894199.27355.46.camel@intel.com \
--to=mika.kahola@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.