From: Oliver Neukum <oneukum@suse.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Robert Foss" <robert.foss@collabora.com>,
tglx@linutronix.de,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bjørn Mork" <bjorn@mork.no>,
"Alan Stern" <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org
Subject: [v2] USB: cdc-wdm: don't enable interrupts in USB-giveback
Date: Thu, 14 Jun 2018 10:44:20 +0200 [thread overview]
Message-ID: <1528965860.8189.4.camel@suse.com> (raw)
On Mi, 2018-06-13 at 22:28 +0200, Sebastian Andrzej Siewior wrote:
> On 2018-06-13 19:43:55 [+0200], Oliver Neukum wrote:
> >
>
> Hi Oliver,
Hi Sebastian,
> > I am just looking at your patch and I am wondering why
> > wdm_in_callback() won't just call service_outstanding_interrupt()
> > again and again? OK, maybe I am dense and it may well be present now,
> > but it just looks to me that way.
>
> But this part didn't change, did it?
Right, it didn't change, but that does not make it correct.
> The user blocks in wdmw_read()
We can only hope that he does. The wait is interruptible.
If a signal comes at the wrong time, nobody will be waiting.
> Maybe we should delay the WDM_READ flag in the error case until the
> worker is done (before the wakeup).
I don't think that will help. It seems like we need to make sure
that error recovery is a one shot activity.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-06-14 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 8:44 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-14 15:33 [v2] USB: cdc-wdm: don't enable interrupts in USB-giveback Oliver Neukum
2018-06-14 11:17 Sebastian Andrzej Siewior
2018-06-13 20:28 Sebastian Andrzej Siewior
2018-06-13 17:43 Oliver Neukum
2018-06-13 16:28 Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528965860.8189.4.camel@suse.com \
--to=oneukum@suse.com \
--cc=bigeasy@linutronix.de \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.foss@collabora.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.