From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([2a01:4f8:191:72ef::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fV15u-00086O-97 for ath10k@lists.infradead.org; Mon, 18 Jun 2018 20:49:47 +0000 Message-ID: <1529354967.3092.43.camel@sipsolutions.net> Subject: Re: [PATCH] ath10k: add dynamic vlan support From: Johannes Berg Date: Mon, 18 Jun 2018 22:49:27 +0200 In-Reply-To: References: <1524232653-22573-1-git-send-email-mpubbise@codeaurora.org> <87r2n5auvq.fsf@kamboji.qca.qualcomm.com> <1526637270.3805.15.camel@sipsolutions.net> <59ff8201-fc1b-8579-d5a9-f4b08621f5ec@codeaurora.org> <1527069018.3759.15.camel@sipsolutions.net> <988f350d-a6eb-1733-4a2f-43a87053e96a@codeaurora.org> <1527071997.3759.18.camel@sipsolutions.net> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Sebastian Gottschall , Manikanta Pubbisetty Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Kalle Valo On Thu, 2018-05-24 at 06:41 +0200, Sebastian Gottschall wrote: > > mmh not sure. it might not check the capabilitiy, but it sets the > interface type to IFTYPE_AP_VLAN > for wds sta interfaces. that might collide That was my point - if it doesn't check the capability then we can remove it without impacting backward compatibility, and add it back in another bit saying "AP-VLAN for 4-addr only". johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([144.76.63.242]:58312 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936286AbeFRUtb (ORCPT ); Mon, 18 Jun 2018 16:49:31 -0400 Message-ID: <1529354967.3092.43.camel@sipsolutions.net> (sfid-20180618_224943_979473_4B387212) Subject: Re: [PATCH] ath10k: add dynamic vlan support From: Johannes Berg To: Sebastian Gottschall , Manikanta Pubbisetty Cc: Kalle Valo , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Date: Mon, 18 Jun 2018 22:49:27 +0200 In-Reply-To: References: <1524232653-22573-1-git-send-email-mpubbise@codeaurora.org> <87r2n5auvq.fsf@kamboji.qca.qualcomm.com> <1526637270.3805.15.camel@sipsolutions.net> <59ff8201-fc1b-8579-d5a9-f4b08621f5ec@codeaurora.org> <1527069018.3759.15.camel@sipsolutions.net> <988f350d-a6eb-1733-4a2f-43a87053e96a@codeaurora.org> <1527071997.3759.18.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2018-05-24 at 06:41 +0200, Sebastian Gottschall wrote: > > mmh not sure. it might not check the capabilitiy, but it sets the > interface type to IFTYPE_AP_VLAN > for wds sta interfaces. that might collide That was my point - if it doesn't check the capability then we can remove it without impacting backward compatibility, and add it back in another bit saying "AP-VLAN for 4-addr only". johannes