From: Oliver Neukum <oneukum@suse.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Robert Foss" <robert.foss@collabora.com>,
tglx@linutronix.de,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bjørn Mork" <bjorn@mork.no>,
"Alan Stern" <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org
Subject: [v4] USB: cdc-wdm: don't enable interrupts in USB-giveback
Date: Tue, 19 Jun 2018 15:58:58 +0200 [thread overview]
Message-ID: <1529416738.16694.0.camel@suse.com> (raw)
On Do, 2018-06-14 at 18:36 +0200, Sebastian Andrzej Siewior wrote:
> In the code path
> __usb_hcd_giveback_urb()
> -> wdm_in_callback()
> -> service_outstanding_interrupt()
>
> The function service_outstanding_interrupt() will unconditionally enable
> interrupts during unlock and invoke usb_submit_urb() with GFP_KERNEL.
> If the HCD completes in BH (like ehci does) then the context remains
> atomic due local_bh_disable() and enabling interrupts does not change
> this.
>
> Defer the error case handling to a workqueue as suggested by Oliver
> Neukum. In case of an error the worker performs the read out and wakes
> the user.
>
> Fixes: c1da59dad0eb ("cdc-wdm: Clear read pipeline in case of error")
> Cc: Robert Foss <robert.foss@collabora.com>
> Cc: Oliver Neukum <oneukum@suse.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
<Acked-by: Oliver Neukum <oneukum@suse.com>
It fixes the identified issue.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-06-19 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 13:58 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-14 16:36 [v4] USB: cdc-wdm: don't enable interrupts in USB-giveback Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529416738.16694.0.camel@suse.com \
--to=oneukum@suse.com \
--cc=bigeasy@linutronix.de \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.foss@collabora.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.