From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Denis Kenzior <denkenz@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix oops in ieee80211_tx_control_port
Date: Wed, 20 Jun 2018 09:53:02 +0200 [thread overview]
Message-ID: <1529481182.3130.2.camel@sipsolutions.net> (raw)
In-Reply-To: <5B2A0772.4060200@broadcom.com> (sfid-20180620_095116_985132_88265637)
On Wed, 2018-06-20 at 09:51 +0200, Arend van Spriel wrote:
> On 6/19/2018 5:39 PM, Denis Kenzior wrote:
> > On pre-emption enabled kernels the following oops was being seen due
> > to missing local_bh_disable/local_bh_enable calls. mac80211 assumes
> > that pre-emption is disabled in the data path.
>
> No sure if "assumes" is the right term here. It seems like it is
> required and there is probably a good reason for that. Would be nice to
> know what that reason is.
It's using per-CPU data.
johannes
next prev parent reply other threads:[~2018-06-20 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 15:39 [PATCH] mac80211: Fix oops in ieee80211_tx_control_port Denis Kenzior
2018-06-20 7:51 ` Arend van Spriel
2018-06-20 7:53 ` Johannes Berg [this message]
2018-06-20 7:54 ` Arend van Spriel
2018-06-20 7:55 ` Johannes Berg
2018-06-29 7:40 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529481182.3130.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.