All of lore.kernel.org
 help / color / mirror / Atom feed
From: Justin Mitchell <jumitche@redhat.com>
To: Calum Mackay <calum.mackay@oracle.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 5/5] nfs-utils: Add config setting to nfsconf cli tool
Date: Fri, 22 Jun 2018 10:43:13 +0100	[thread overview]
Message-ID: <1529660593.7576.5.camel@redhat.com> (raw)
In-Reply-To: <e6d15961-2381-8212-253d-6e970587f862@oracle.com>

On Fri, 2018-06-22 at 04:18 +0100, Calum Mackay wrote:
> hi Justin, it's not a part of your patch, but I noticed a tiny typo: see 
> below.
> 
> On 20/06/2018 1:14 pm, Justin Mitchell wrote:
> >   	} else {
> >   		fprintf(stderr, "Mode not yet implimented.\n");
> 
> -> implemented

Well spotted, a quick check with the spell checker spots a few others,
so patch submitted separately.

thanks for pointing it out
-J





  reply	other threads:[~2018-06-22  9:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-20 12:09 [PATCH 0/5] nfs-utils: config value setting Justin Mitchell
2018-06-20 12:11 ` [PATCH 1/5] nfs-utils: Ignore empty lines in config Justin Mitchell
2018-06-20 12:12 ` [PATCH 2/5] nfs-utils: Fix comparison check for subsection headers Justin Mitchell
2018-06-20 12:12 ` [PATCH 3/5] nfs-utils: swap xlog_err for less fatal version Justin Mitchell
2018-06-20 12:13 ` [PATCH 4/5] nfs-utils: Add config file writing function Justin Mitchell
2018-06-20 12:14 ` [PATCH 5/5] nfs-utils: Add config setting to nfsconf cli tool Justin Mitchell
2018-06-22  3:18   ` Calum Mackay
2018-06-22  9:43     ` Justin Mitchell [this message]
2018-06-25 15:38 ` [PATCH 0/5] nfs-utils: config value setting Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529660593.7576.5.camel@redhat.com \
    --to=jumitche@redhat.com \
    --cc=calum.mackay@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.