From: alanx.chiang@intel.com
To: linux-i2c@vger.kernel.org
Cc: andy.yeh@intel.com, sakari.ailus@linux.intel.com,
andriy.shevchenko@intel.com, rajmohan.mani@intel.com,
andy.shevchenko@gmail.com, brgl@bgdev.pl, robh+dt@kernel.org,
mark.rutland@arm.com, arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
"alanx.chiang" <alanx.chiang@intel.com>
Subject: [PATCH v2 2/2] eeprom: at24: Add support for address-width property
Date: Tue, 26 Jun 2018 14:22:08 +0800 [thread overview]
Message-ID: <1529994128-26770-3-git-send-email-alanx.chiang@intel.com> (raw)
In-Reply-To: <1529994128-26770-1-git-send-email-alanx.chiang@intel.com>
From: "alanx.chiang" <alanx.chiang@intel.com>
Provide a flexible way to determine the addressing bits of eeprom.
Pass the addressing bits to driver through address-width property.
Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
---
since v1
-- Add a warn message for 8-bit addressing.
---
drivers/misc/eeprom/at24.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 0c125f2..231afcd 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -478,6 +478,22 @@ static void at24_properties_to_pdata(struct device *dev,
if (device_property_present(dev, "no-read-rollover"))
chip->flags |= AT24_FLAG_NO_RDROL;
+ err = device_property_read_u32(dev, "address-width", &val);
+ if (!err) {
+ switch (val) {
+ case 8:
+ chip->flags &= ~AT24_FLAG_ADDR16;
+ dev_warn(dev, "address-width is 8, clear the ADD16 bit\n");
+ break;
+ case 16:
+ chip->flags |= AT24_FLAG_ADDR16;
+ break;
+ default:
+ dev_warn(dev, "Bad \"address-width\" property: %u\n",
+ val);
+ }
+ }
+
err = device_property_read_u32(dev, "size", &val);
if (!err)
chip->byte_len = val;
--
2.7.4
next prev parent reply other threads:[~2018-06-26 6:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 6:22 [PATCH v2 0/2] Add a property in at24.c alanx.chiang
2018-06-26 6:22 ` [PATCH v2 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-06-26 6:49 ` Sakari Ailus
2018-06-26 16:44 ` Rob Herring
2018-06-26 6:22 ` alanx.chiang [this message]
2018-06-26 6:47 ` [PATCH v2 2/2] eeprom: at24: Add support for " Sakari Ailus
2018-06-26 7:11 ` Chiang, AlanX
2018-06-26 7:26 ` Sakari Ailus
2018-06-26 12:11 ` Andy Shevchenko
2018-06-26 7:41 ` [PATCH v2 0/2] Add a property in at24.c Bartosz Golaszewski
2018-06-26 12:14 ` Andy Shevchenko
2018-06-26 12:36 ` Bartosz Golaszewski
2018-06-26 13:23 ` Andy Shevchenko
2018-06-26 13:30 ` Bartosz Golaszewski
2018-06-26 15:48 ` Andy Shevchenko
2018-06-26 16:21 ` Yeh, Andy
2018-06-26 16:31 ` Mani, Rajmohan
2018-06-26 16:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529994128-26770-3-git-send-email-alanx.chiang@intel.com \
--to=alanx.chiang@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy.yeh@intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rajmohan.mani@intel.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.