From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH v6 1/2] drm/i915/psr: Lockless version of psr_wait_for_idle Date: Tue, 26 Jun 2018 12:43:42 -0700 Message-ID: <1530042222.5598.6.camel@intel.com> References: <20180626055724.167534-1-tarun.vyas@intel.com> <20180626082657.GV2958@phenom.ffwll.local> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30DF06E4BE for ; Tue, 26 Jun 2018 19:17:38 +0000 (UTC) In-Reply-To: <20180626082657.GV2958@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Tarun Vyas Cc: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE4LTA2LTI2IGF0IDEwOjI2ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ IE9uIE1vbiwgSnVuIDI1LCAyMDE4IGF0IDEwOjU3OjIzUE0gLTA3MDAsIFRhcnVuIFZ5YXMgd3Jv dGU6Cj4gPiAKPiA+IFRoaXMgaXMgYSBsb2NrbGVzcyB2ZXJzaW9uIG9mIHRoZSBleGlzaXRpbmcg cHNyX3dhaXRfZm9yX2lkbGUoKS4KPiA+IFdlIHdhbnQgdG8gd2FpdCBmb3IgUFNSIHRvIGlkbGUg b3V0IGluc2lkZSBpbnRlbF9waXBlX3VwZGF0ZV9zdGFydC4KPiA+IEF0IHRoZSB0aW1lIG9mIGEg cGlwZSB1cGRhdGUsIHdlIHNob3VsZCBuZXZlciByYWNlIHdpdGggYW55IHBzcgo+ID4gZW5hYmxl IG9yIGRpc2FibGUgY29kZSwgd2hpY2ggaXMgYSBwYXJ0IG9mIGNydGMgZW5hYmxlL2Rpc2FibGUu IFNvLAo+ID4gd2UgY2FuIGxpdmUgdy9vIHRha2luZyBhbnkgcHNyIGxvY2tzIGF0IGFsbC4KPiA+ IFRoZSBmb2xsb3cgdXAgcGF0Y2ggd2lsbCB1c2UgdGhpcyBsb2NrbGVzcyB3YWl0IGluc2lkZSBw aXBlX3VwZGF0ZV8KPiA+IHN0YXJ0IHRvIHdhaXQgZm9yIFBTUiB0byBpZGxlIG91dCBiZWZvcmUg Y2hlY2tpbmcgZm9yIHZibGFuawo+ID4gZXZhc2lvbi4KPiBXaGF0J3MgdGhlIHVwc2lkZSBvZiB0 aGUgbG9ja2xlc3Mgd2FpdD8gVGhlIHBhdGNoIHNlZW1zIHRvIGJlCj4gZW50aXJlbHkKPiBtaXNz aW5nIHRoZSBtb3RpdmF0aW9uIGZvciB0aGUgY2hhbmdlLiAiTWFrZSBpdCBsb2NrbGVzcyIgaXNu J3QgYQo+IGdvb2QKPiBqdXN0aWZpY2F0aW9uIG9uIGl0c2VsZiwgdGhlcmUgbmVlZHMgdG8gYmUg ZGF0YSBhYm91dCBvdmVyaGVhZCBvcgo+IHN0YWxscwo+IGluY2x1ZGVkIGlmIHRoYXQncyB0aGUg cmVhc29uIGZvciBkb2luZyB0aGlzIGNoYW5nZS4KPiAKQWNxdWlyaW5nIHRoZSBQU1IgbXV0ZXgg bWVhbnMgcG90ZW50aWFsIHN0YWxscyBkdWUgdG8gUFNSIHdvcmsgaGF2aW5nCmFscmVhZHkgYWNx dWlyZWQgaXQuIFRoZSBpZGVhIHdhcyB0byBrZWVwIFBTUiBjaGFuZ2VzIGluCnBpcGVfdXBkYXRl X3N0YXJ0KCkgbGVzcyBpbnZhc2l2ZSBsYXRlbmN5IHdpc2UuCgpCdXQgeWVhaCwgdGhlIGNvbW1p dCBoYXMgdG8gYWRkIHRoZSBleHBsYW5hdGlvbi4KCgoKPiA+IAo+ID4gRXZlbiBpZiBwc3IgaXMg bmV2ZXIgZW5hYmxlZCwgcHNyMl9lbmFibGVkIHdpbGwgYmUgZmFsc2UgYW5kIHRoaXMKPiA+IGZ1 bmN0aW9uIHdpbGwgd2FpdCBmb3IgUFNSMSB0byBpZGxlIG91dCwgd2hpY2ggc2hvdWxkIGp1c3Qg cmV0dXJuCj4gPiBpbW1lZGlhdGVseSwgc28gYSB2ZXJ5IHNob3J0ICh+MS0yIHVzZWMpIHdhaXQg Zm9yIGNhc2VzIHdoZXJlIFBTUgo+ID4gaXMgZGlzYWJsZWQuCj4gPiAKPiA+IHYyOiBBZGQgY29t bWVudCB0byBleHBsYWluIHRoZSAyNW1zZWMgdGltZW91dCAoREspCj4gPiAKPiA+IHYzOiBSZW5h bWUgcHNyX3dhaXRfZm9yX2lkbGUgdG8gX19wc3Jfd2FpdF9mb3JfaWRsZV9sb2NrZWQgdG8gYXZv aWQKPiA+IMKgwqDCoMKgbmFtaW5nIGNvbmZsaWN0cyBhbmQgcHJvcGFnYXRlIGVyciAoaWYgYW55 KSB0byB0aGUgY2FsbGVyCj4gPiAoQ2hyaXMpCj4gPiAKPiA+IHY1OiBGb3JtIGEgc2VyaWVzIHdp dGggdGhlIG5leHQgcGF0Y2gKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVGFydW4gVnlhcyA8dGFy dW4udnlhc0BpbnRlbC5jb20+Cj4gPiAtLS0KPiA+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmggfMKgwqAxICsKPiA+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMg fCAyNSArKysrKysrKysrKysrKysrKysrKysrKy0tCj4gPiDCoDIgZmlsZXMgY2hhbmdlZCwgMjQg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rydi5oCj4gPiBpbmRleCA1NzgzNDZiOGQ3ZTIuLjljYjJiOGFmZGQzZSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gQEAgLTE5MjAsNiArMTkyMCw3IEBAIHZvaWQg aW50ZWxfcHNyX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcAo+ID4gKmludGVsX2RwLAo+ ID4gwqAJCQnCoMKgwqDCoMKgwqBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZQo+ID4gKmNydGNfc3Rh dGUpOwo+ID4gwqB2b2lkIGludGVsX3Bzcl9pcnFfY29udHJvbChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsIGJvb2wKPiA+IGRlYnVnKTsKPiA+IMKgdm9pZCBpbnRlbF9wc3JfaXJx X2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIKPiA+IHBzcl9p aXIpOwo+ID4gK2ludCBpbnRlbF9wc3Jfd2FpdF9mb3JfaWRsZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpOwo+ID4gwqAKPiA+IMKgLyogaW50ZWxfcnVudGltZV9wbS5jICovCj4g PiDCoGludCBpbnRlbF9wb3dlcl9kb21haW5zX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kik7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+ IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+IGluZGV4IGFlYTgxYWNlODU0 Yi4uNDFlNjk2MjkyM2FlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcHNyLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiBA QCAtNzU3LDcgKzc1NywyOCBAQCB2b2lkIGludGVsX3Bzcl9kaXNhYmxlKHN0cnVjdCBpbnRlbF9k cAo+ID4gKmludGVsX2RwLAo+ID4gwqAJY2FuY2VsX3dvcmtfc3luYygmZGV2X3ByaXYtPnBzci53 b3JrKTsKPiA+IMKgfQo+ID4gwqAKPiA+IC1zdGF0aWMgYm9vbCBwc3Jfd2FpdF9mb3JfaWRsZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAraW50IGludGVsX3Bzcl93YWl0 X2Zvcl9pZGxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICt7Cj4gPiAr CWk5MTVfcmVnX3QgcmVnOwo+ID4gKwl1MzIgbWFzazsKPiA+ICsKPiBJIHRoaW5rIGEgY29tbWVu dCBoZXJlIGV4cGxhaW5pbmcgd2h5IHRoZSBsb2NrbGVzcyBhY2Nlc3MgaXMgY29ycmVjdAo+IGlz Cj4ganVzdGlmaWVkIGhlcmUuCj4gCj4gPiAKPiA+ICsJaWYgKGRldl9wcml2LT5wc3IucHNyMl9l bmFibGVkKSB7Cj4gPiArCQlyZWcgPSBFRFBfUFNSMl9TVEFUVVM7Cj4gPiArCQltYXNrID0gRURQ X1BTUjJfU1RBVFVTX1NUQVRFX01BU0s7Cj4gPiArCX0gZWxzZSB7Cj4gPiArCQlyZWcgPSBFRFBf UFNSX1NUQVRVUzsKPiA+ICsJCW1hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9NQVNLOwo+ID4g Kwl9Cj4gPiArCj4gPiArCS8qCj4gPiArCcKgKiBUaGXCoMKgMjUgbXNlYyB0aW1lb3V0IGFjY291 bnRzIGZvciBhIGZyYW1lIEAgNjBIego+ID4gcmVmcmVzaCByYXRlLAo+ID4gKwnCoCogZXhpdCB0 cmFpbmluZyBhbiBhdXggaGFuZHNoYWtlIHRpbWUuCj4gPiArCcKgKi8KPiBTbyB0aGlzIGdvZXMg Ym9vbSBpZiB0aGUgcGFuZWwgaXMgcnVubmluZyBhdCBlLmcuIDUwSHo/IFBsZWFzZSBlaXRoZXIK PiBjYWxjdWxhdGUgdGhpcyBmcm9tIHRoZSBjdXJyZW50IG1vZGUgKGJ1dCB0aGF0J3MgYSBiaXQg dHJpY2t5LCBkdWUgdG8KPiBEUlJTKSwgb3IgZ28gd2l0aCBhIG1vcmUgZGVmZW5zaXZlIHRpbWVv dXQuIEFsc28gc21hbGwgdHlwbywKPiBzL2FuL2FuZC8uCj4gCj4gV291bGQgYWxzbyBiZSBnb29k IHRvIGhhdmUgbnVtYmVycyBmb3IgdGhlIGV4aXQgdHJhaW5pbmcvYXV4Cj4gaGFuZHNoYWtlCj4g dGltZS4KCmJzcGVjIHNheXMgZXhpdCBzaG91bGQgYmUgY29tcGVsZXRlIGluIMKgIm9uZSBmdWxs IGZyYW1lIHRpbWUgKDEvcmVmcmVzaApyYXRlKSwgcGx1cyBTUkQgZXhpdCB0cmFpbmluZyB0aW1l IChtYXggb2YgNm1zKSwgcGx1cyBTUkQgYXV4IGNoYW5uZWwKaGFuZHNoYWtlIChtYXggb2YgMS41 bXMpLiIKCgoKPiAtRGFuaWVsCj4gCj4gPiAKPiA+ICsJcmV0dXJuIGludGVsX3dhaXRfZm9yX3Jl Z2lzdGVyKGRldl9wcml2LCByZWcsIG1hc2ssCj4gPiArCQkJCcKgwqDCoMKgwqDCoMKgRURQX1BT Ul9TVEFUVVNfU1RBVEVfSURMRSwKPiA+IDI1KTsKPiA+ICt9Cj4gPiArCj4gPiArc3RhdGljIGJv b2wgX19wc3Jfd2FpdF9mb3JfaWRsZV9sb2NrZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ ICpkZXZfcHJpdikKPiA+IMKgewo+ID4gwqAJc3RydWN0IGludGVsX2RwICppbnRlbF9kcDsKPiA+ IMKgCWk5MTVfcmVnX3QgcmVnOwo+ID4gQEAgLTgwMyw3ICs4MjQsNyBAQCBzdGF0aWMgdm9pZCBp bnRlbF9wc3Jfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QKPiA+ICp3b3JrKQo+ID4gwqAJwqAqIFBT UiBtaWdodCB0YWtlIHNvbWUgdGltZSB0byBnZXQgZnVsbHkgZGlzYWJsZWQKPiA+IMKgCcKgKiBh bmQgYmUgcmVhZHkgZm9yIHJlLWVuYWJsZS4KPiA+IMKgCcKgKi8KPiA+IC0JaWYgKCFwc3Jfd2Fp dF9mb3JfaWRsZShkZXZfcHJpdikpCj4gPiArCWlmICghX19wc3Jfd2FpdF9mb3JfaWRsZV9sb2Nr ZWQoZGV2X3ByaXYpKQo+ID4gwqAJCWdvdG8gdW5sb2NrOwo+ID4gwqAKPiA+IMKgCS8qCj4gPiAt LcKgCj4gPiAyLjEzLjUKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=