From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: encourage BIT() macro usage in
 register definitions
Date: Thu, 28 Jun 2018 10:45:02 -0700
Message-ID: <1530207902.2636.11.camel@intel.com>
References: <20180627144113.6989-1-jani.nikula@intel.com>
 <op.zk9ycgfaxaggs7@mwajdecz-mobl1.ger.corp.intel.com>
 <153011517949.8693.5606799904077354457@mail.alporthouse.com>
 <87sh57rud8.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D523C6EDFA
 for <intel-gfx@lists.freedesktop.org>; Thu, 28 Jun 2018 17:45:03 +0000 (UTC)
In-Reply-To: <87sh57rud8.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@intel.com>, Chris Wilson <chris@chris-wilson.co.uk>, Michal Wajdeczko <michal.wajdeczko@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

RW0gUXVpLCAyMDE4LTA2LTI4IMOgcyAxNTowMyArMDMwMCwgSmFuaSBOaWt1bGEgZXNjcmV2ZXU6
Cj4gT24gV2VkLCAyNyBKdW4gMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u
Y28udWs+IHdyb3RlOgo+ID4gUXVvdGluZyBNaWNoYWwgV2FqZGVjemtvICgyMDE4LTA2LTI3IDE2
OjUxOjQyKQo+ID4gPiBPbiBXZWQsIDI3IEp1biAyMDE4IDE2OjQxOjEzICswMjAwLCBKYW5pIE5p
a3VsYSA8amFuaS5uaWt1bGFAaW50ZQo+ID4gPiBsLmNvbT4gIAo+ID4gPiB3cm90ZToKPiA+ID4g
Cj4gPiA+ID4gVGhlcmUncyBhbHJlYWR5IHNvbWUgQklUKCkgdXNhZ2UgaGVyZSBhbmQgdGhlcmUs
IGVtYnJhY2UgaXQuCj4gPiA+ID4gCj4gPiA+ID4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56
YW5vbmlAaW50ZWwuY29tPgoKU2luY2UgSSdtIENDJ2QgSSBndWVzcyBteSBvcGluaW9uIGNvdW50
cyBoZXJlIDopCgoKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1
bGFAaW50ZWwuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X3JlZy5oIHwgOSArKysrKy0tLS0KPiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0
aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCAgCj4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pOTE1X3JlZy5oCj4gPiA+ID4gaW5kZXggNDc2MTE4ZjQ2Y2YzLi42NGI5YzI3MDA0NWQg
MTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4g
PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4gPiBAQCAtNjUs
OSArNjUsMTAgQEAKPiA+ID4gPiAgICogYnV0IGRvIG5vdGUgdGhhdCB0aGUgbWFjcm9zIG1heSBi
ZSBuZWVkZWQgdG8gcmVhZCBhcyB3ZWxsCj4gPiA+ID4gYXMgd3JpdGUgIAo+ID4gPiA+IHRoZQo+
ID4gPiA+ICAgKiByZWdpc3RlciBjb250ZW50cy4KPiA+ID4gPiAgICoKPiA+ID4gPiAtICogRGVm
aW5lIGJpdHMgdXNpbmcgYGAoMSA8PCBOKWBgIGluc3RlYWQgb2YgYGBCSVQoTilgYC4gV2UKPiA+
ID4gPiBtYXkgY2hhbmdlICAKPiA+ID4gPiB0aGlzIGluCj4gPiA+ID4gLSAqIHRoZSBmdXR1cmUs
IGJ1dCB0aGlzIGlzIHRoZSBwcmV2YWlsaW5nIHN0eWxlLiBEbyAqKm5vdCoqCj4gPiA+ID4gYWRk
ICAKPiA+ID4gPiBgYF9CSVRgYCBzdWZmaXgKPiA+ID4gPiAtICogdG8gdGhlIG5hbWUuCj4gPiA+
ID4gKyAqIERlZmluZSBiaXRzIHVzaW5nIGBgQklUKE4pYGAgaW5zdGVhZCBvZiBgYCgxIDw8IE4p
YGAuIERvCj4gPiA+ID4gKipub3QqKiBhZGQgIAo+ID4gPiA+IGBgX0JJVGBgCj4gPiA+ID4gKyAq
IHN1ZmZpeCB0byB0aGUgbmFtZS4gRXhjZXB0aW9uIHRvIGBgQklUKClgYCB1c2FnZTogVmFsdWUg
MQo+ID4gPiA+IGZvciBhIGJpdCAgCj4gPiA+ID4gZmllbGQKPiA+ID4gPiArICogc2hvdWxkIGJl
IGRlZmluZWQgdXNpbmcgYGAoMSA8PCBOKWBgIHRvIGJlIGluIGxpbmUgd2l0aAo+ID4gPiA+IG90
aGVyIHZhbHVlcyAgCj4gPiA+ID4gc3VjaCBhcwo+ID4gPiA+ICsgKiBgYCgyIDw8IE4pYGAgZm9y
IHRoZSBzYW1lIGZpZWxkLgo+ID4gPiA+ICAgKgo+ID4gPiA+ICAgKiBHcm91cCB0aGUgcmVnaXN0
ZXIgYW5kIGl0cyBjb250ZW50cyB0b2dldGhlciB3aXRob3V0IGJsYW5rCj4gPiA+ID4gbGluZXMs
ICAKPiA+ID4gPiBzZXBhcmF0ZQo+ID4gPiA+ICAgKiBmcm9tIG90aGVyIHJlZ2lzdGVycyBhbmQg
dGhlaXIgY29udGVudHMgd2l0aCBvbmUgYmxhbmsKPiA+ID4gPiBsaW5lLgo+ID4gPiA+IEBAIC0x
MDUsNyArMTA2LDcgQEAKPiA+ID4gPiAgICogICNkZWZpbmUgX0ZPT19BICAgICAgICAgICAgICAg
ICAgICAgIDB4ZjAwMAo+ID4gPiA+ICAgKiAgI2RlZmluZSBfRk9PX0IgICAgICAgICAgICAgICAg
ICAgICAgMHhmMDAxCj4gPiA+ID4gICAqICAjZGVmaW5lIEZPTyhwaXBlKSAgICAgICAgICAgICAg
ICAgICBfTU1JT19QSVBFKHBpcGUsCj4gPiA+ID4gX0ZPT19BLCBfRk9PX0IpCj4gPiA+ID4gLSAq
ICAjZGVmaW5lICAgRk9PX0VOQUJMRSAgICAgICAgICAgICAgICAoMSA8PCAzMSkKPiA+ID4gPiAr
ICogICNkZWZpbmUgICBGT09fRU5BQkxFICAgICAgICAgICAgICAgIEJJVCgzMSkKPiA+ID4gCj4g
PiA+IGhtbSwgdGhpcyBicmVha3MgbmljZSBjb25zaXN0ZW5jeSBiZXR3ZWVuIG9uZS0gYW5kIG11
bHRpLWJpdAo+ID4gPiBmaWVsZHMgLi4KCkknbGwgYWdyZWUgd2l0aCBNaWNoYWwgYW5kIENocmlz
IGhlcmU6IEknbSBub3QgYSBodWdlIGZhbiBvZiBtaXhpbmcKQklUKCkgYW5kICh4IDw8IHkpLCBJ
IHdvdWxkIHByZWZlciB0byBrZWVwIHRoZSBjdXJyZW50IHN0YW5kYXJkLAplc3BlY2lhbGx5IHNp
bmNlIEJJVCgpIGlzIGVhc2lseSBibGFja2xpc3RhYmxlLiBPciBmdWxseSBlbWJyYWNlIHRoZQpo
ZWxwZXIgbWFjcm9zIGFuZCBhYm9saXNoIGFsbCBzb3J0cyBvZiAoeCA8PCB5KS4gQ29uc2lzdGVu
Y3kgd2lucyBJTUhPLgoKPiA+ID4gCj4gPiA+ID4gICAqICAjZGVmaW5lICAgRk9PX01PREVfTUFT
SyAgICAgICAgICAgICAoMHhmIDw8IDE2KQo+ID4gPiAKPiA+ID4gLi4gYnV0IGlmIHlvdSB3YW50
IHRvIHVzZSBtYWNybyBmb3Igc2luZ2xlIGJpdCwgdGhlbiBtYXliZSB5b3UKPiA+ID4gc2hvdWxk
Cj4gPiA+IGFsc28gY29uc2lkZXIgb3RoZXIgZXhpc3RpbmcgbWFjcm8gZm9yIHRoZSBtYXNrIGRl
ZmluaXRpb246Cj4gPiA+IAo+ID4gPiAgICAgICAgICNkZWZpbmUgICBGT09fTU9ERV9NQVNLICAg
ICAgICAgICAgIEdFTk1BU0soMTksIDE2KQo+ID4gPiAKPiA+ID4gPiAgICogICNkZWZpbmUgICBG
T09fTU9ERV9TSElGVCAgICAgICAgICAgIDE2Cj4gPiA+ID4gICAqICAjZGVmaW5lICAgRk9PX01P
REVfQkFSICAgICAgICAgICAgICAoMCA8PCAxNikKPiA+ID4gCj4gPiA+IC4uIGJ1dCB3ZSBzdGls
bCBkb24ndCBoYXZlIGFueSBtYWNybyBmb3IgZGVmaW5pbmcgbXVsdGktYml0Cj4gPiA+IHZhbHVl
cwo+ID4gPiBzbyBJJ20gbm90IHN1cmUgaWYgdGhpcyBjaGFuZ2Ugd2lsbCBtYWtlIGNvZGUgcmVh
bGx5IGVhc2llciB0bwo+ID4gPiByZWFkCj4gPiAKPiA+ICNpbmNsdWRlIDxsaW51eC9iaXRmaWVs
ZC5oPgo+ID4gCj4gPiBJJ20gbm90IHN1cmUgaWYgSSdtIHJlYWR5IHRvIGVtYnJhY2UgdGhhdCB5
ZXQsIGJ1dCBpdCBkb2VzIHNlZW0gdG8KPiA+IGJlCj4gPiB0aGUgZGlyZWN0aW9uIHdlIHNob3Vs
ZCBiZSBoZWFkaW5nIGluLiBQcmltYXJpbHkgdG8gY2hlY2sgdGhlCj4gPiBpbnZhbGlkCj4gPiBy
YW5nZSBjaGVja2luZyAmIHVzYWdlLgo+IAo+IEkgZ3Vlc3MgdGhlcmUgYXJlIHR3byB0aGluZ3Mg
aGVyZS4gVXNpbmcgYml0ZmllbGQuaCBtYWNyb3MgdG8gZGVmaW5lCj4gb3VyCj4gb3duIHN0dWZm
IGlzIG9uZSB0aGluZywgbGlrZSBzbzoKPiAKPiAjZGVmaW5lICAgRk9PX0VOQUJMRSAgICAgICAg
ICAgICAgICBCSVQoMzEpCj4gI2RlZmluZSAgIEZPT19NT0RFX01BU0sgICAgICAgICAgICAgR0VO
TUFTSygxOSwgMTYpCj4gI2RlZmluZSAgIEZPT19NT0RFX1NISUZUICAgICAgICAgICAgMTYKPiAj
ZGVmaW5lICAgRk9PX01PREVfQkFSICAgICAgICAgICAgICBGSUVMRF9QUkVQKEZPT19NT0RFX01B
U0ssIDApCj4gI2RlZmluZSAgIEZPT19NT0RFX0JBWiAgICAgICAgICAgICAgRklFTERfUFJFUChG
T09fTU9ERV9NQVNLLCAxKQo+ICNkZWZpbmUgICBGT09fTU9ERV9RVVhfU05CICAgICAgICAgIEZJ
RUxEX1BSRVAoRk9PX01PREVfTUFTSywgMikKPiAKPiBUaGUgcmFuZ2UgY2hlY2tpbmcgaXMgaW5k
ZWVkIGFuIGFkdmFudGFnZS4KPiAKPiBVc2luZyBGSUVMRF9QUkVQKCkgb3IgRklFTERfR0VUKCkg
aW4gY29kZSBpcyBhbm90aGVyLCBiZWNhdXNlIHdlCj4gY3VycmVudGx5IGRvbid0IGRlZmluZSB0
aGUgKnVuc2hpZnRlZCogZmllbGQgdmFsdWVzLiBFdmVyeXRoaW5nIGlzCj4gZGVmaW5lZCB3aXRo
IHRoZSBzaGlmdC4gRGVmaW5pbmcgZXZlcnl0aGluZyB1bnNoaWZ0ZWQgYW5kIHRoZW4gbW92aW5n
Cj4gdGhlIEZJRUxEX1BSRVAoKSBhbmQgRklFTERfR0VUKCkgaW4gY29kZSB3b3VsZCBiZSBxdWl0
ZSB0aGUgY2hhbmdlLgoKQ2FuJ3Qgd2UgY3JlYXRlIHNpbXBsZSBtYWNyb3MgdGhhdCBjb3ZlciBv
dXIgY2FzZXMgdGhlbj8KCih5ZXMsIHRoYXQgd291bGQgcGVyaGFwcyBiZSBtb3JlIGRpdmVyZ2Vu
Y2UgZnJvbSB0aGUgS2VybmVsIGNvZGluZwpzdGFuZGFyZHMsIHdoaWNoIGNvdWxkIGJlIHdvcnNl
IHRoYW4gdXNpbmcgKHggPDwgeSkgdGhhdCBhcmUgbm90IGhpZGRlbgpieSBub25zdGFuZGFyZCBt
YWNyb3MpCgoKPiAKPiBCUiwKPiBKYW5pLgo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s
aXN0aW5mby9pbnRlbC1nZngK