From: Johannes Berg <johannes@sipsolutions.net>
To: "Manikanta Pubbisetty" <mpubbise@codeaurora.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add stop/start logic for software TXQs
Date: Fri, 29 Jun 2018 09:58:00 +0200 [thread overview]
Message-ID: <1530259080.3481.7.camel@sipsolutions.net> (raw)
In-Reply-To: <5adc5faf-8af0-7af9-8261-784a7ec0e4f7@codeaurora.org>
On Tue, 2018-06-26 at 18:01 +0530, Manikanta Pubbisetty wrote:
>
> Valid point, txqs_paused is set in ieee80211_tx_dequeue; I was thinking
> a case where tx_dequeue is called without rcu_read_lock but seems that
> is not the case. All drivers using wake_tx_queue seems are using
> rcu_read_lock before tx_dequeue; can there be a case where tx_dequeue is
> called without rcu_read_lock?
FWIW, the rcu_read_lock() isn't relevant at all - multiple threads can
well (and will for sure!) enter it.
johannes
next prev parent reply other threads:[~2018-06-29 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 7:16 [PATCH] mac80211: add stop/start logic for software TXQs Manikanta Pubbisetty
2018-06-26 11:25 ` Toke Høiland-Jørgensen
2018-06-26 12:31 ` Manikanta Pubbisetty
2018-06-27 12:28 ` Toke Høiland-Jørgensen
2018-06-29 7:58 ` Johannes Berg [this message]
2018-06-29 7:57 ` Johannes Berg
2018-07-02 9:34 ` Manikanta Pubbisetty
2018-06-26 11:27 ` kbuild test robot
2018-06-29 9:09 ` Johannes Berg
2018-07-02 9:18 ` Manikanta Pubbisetty
2018-07-03 9:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530259080.3481.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mpubbise@codeaurora.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.