From: Johannes Berg <johannes@sipsolutions.net>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] mac80211: Implement functionality to monitor txrate cross event for a station
Date: Fri, 29 Jun 2018 11:47:57 +0200 [thread overview]
Message-ID: <1530265677.3481.56.camel@sipsolutions.net> (raw)
In-Reply-To: <1528887539-26821-5-git-send-email-tamizhr@codeaurora.org>
> +static void ieee80211_sta_mon_txrate_thold_check(struct sta_info *sta)
> +{
> + struct rate_info rinfo;
> + enum nl80211_sta_mon_txrate_threshold_event sta_txrate_event;
> + int txrate;
> +
> + if (!sta->txrate_high)
> + return;
> +
> + sta_set_rate_info_tx(sta, &sta->tx_stats.last_rate, &rinfo);
> + txrate = cfg80211_calculate_bitrate(&rinfo);
These are quite expensive calculations, I think this is far too much to
do on every packet.
You need to find a way to do most of the calculations at configure time,
e.g. build a table of MCS configurations this station might use, and
mark bits in there that fall above/below the threshold, or something
like that?
johannes
next prev parent reply other threads:[~2018-06-29 9:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 10:58 [PATCH 0/4] cfg80211/mac80211: Add support to configure and monitor txrate threshold Tamizh chelvam
2018-06-13 10:58 ` [PATCH 1/4] cfg80211: Add support to configure station specific " Tamizh chelvam
2018-06-29 9:44 ` Johannes Berg
2018-06-13 10:58 ` [PATCH 2/4] mac80211: Add api to configure low and high " Tamizh chelvam
2018-06-29 9:45 ` Johannes Berg
2018-06-13 10:58 ` [PATCH 3/4] cfg80211: Add support to notify station's txrate crossing event Tamizh chelvam
2018-06-29 9:46 ` Johannes Berg
2018-06-13 10:58 ` [PATCH 4/4] mac80211: Implement functionality to monitor txrate cross event for a station Tamizh chelvam
2018-06-29 9:47 ` Johannes Berg [this message]
2018-06-13 12:10 ` [PATCH 0/4] cfg80211/mac80211: Add support to configure and monitor txrate threshold Toke Høiland-Jørgensen
2018-06-13 14:24 ` Tamizh Chelvam Raja
2018-06-13 15:10 ` Toke Høiland-Jørgensen
2018-06-14 7:50 ` Arend van Spriel
2018-06-15 11:46 ` Janusz Dziedzic
2018-06-19 7:28 ` Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530265677.3481.56.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.