All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Guy Harris <guy-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: Simon Barber <simon-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>,
	radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org
Subject: Re: [RFC] 0-length PPDU reporting
Date: Fri, 29 Jun 2018 12:49:26 +0200	[thread overview]
Message-ID: <1530269366.3481.80.camel@sipsolutions.net> (raw)
In-Reply-To: <BC6DCA08-4049-4B7A-A7C0-9FC545173FE5-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>

On Tue, 2018-06-19 at 15:50 -0700, Guy Harris wrote:
> On Jun 19, 2018, at 2:20 PM, Guy Harris <guy-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> wrote:
> 
> > On Jun 18, 2018, at 12:20 PM, Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> > 
> > > A wireshark patch should be pretty simple, just don't call through to
> > > the 802.11 dissector?
> > 
> > Yes, although if it has radio information you should call through to
> > the "802.11 radio" dissector (so that it shows the radio information
> > in a pseudo-header-independent format) and pass along information to
> > let it know that *it* shouldn't call through to the 802.11 frame
> > dissector.
> 
> Tcpdump would also need to be changed not to call ieee802_11_print()
> at the end of ieee802_11_radio_print() in print-802_11.c - just return
> "len" for 0-length PPDUs.

Yes, both good points. Thanks!

johannes

  parent reply	other threads:[~2018-06-29 10:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 14:37 [RFC] 0-length PPDU reporting Johannes Berg
     [not found] ` <1529332670.3490.50.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-06-18 16:05   ` Simon Barber
     [not found]     ` <00986C20-9443-40FC-9A7E-DE636A743951-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org>
2018-06-18 19:20       ` Johannes Berg
     [not found]         ` <1529349637.3092.8.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-06-19 21:20           ` Guy Harris
     [not found]             ` <3028EC8F-6CFD-4F52-8349-D49B1F37AC22-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2018-06-19 22:50               ` Guy Harris
     [not found]                 ` <BC6DCA08-4049-4B7A-A7C0-9FC545173FE5-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2018-06-29 10:49                   ` Johannes Berg [this message]
2018-07-02 14:33   ` Johannes Berg
     [not found]     ` <1530542000.3117.4.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-07-03 12:13       ` Johannes Berg
2018-07-09  8:30   ` [RFA] 0-length PSDU reporting Johannes Berg
     [not found]     ` <1531125042.3298.5.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-08-09  1:53       ` Guy Harris
     [not found]         ` <AEBBAD8F-A779-4E0A-B40D-659D55DFE847-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
2018-08-13 10:35           ` Johannes Berg
     [not found]             ` <1534156537.3093.7.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-08-14  8:30               ` Johannes Berg
2018-09-04 12:10   ` [ADOPTION] " Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530269366.3481.80.camel@sipsolutions.net \
    --to=johannes-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
    --cc=guy-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org \
    --cc=radiotap-S783fYmB3Ccdnm+yROfE0A@public.gmane.org \
    --cc=simon-vp0mx6+5gkqFX2APIN6yfw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.