All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: "Miguel Rodríguez Pérez" <miguel@det.uvigo.gal>,
	linux-usb@vger.kernel.org
Subject: [1/2] cdc_ncm: Handle multicast Ethernet traffic
Date: Fri, 29 Jun 2018 22:37:58 +0200	[thread overview]
Message-ID: <1530304678.20408.1.camel@suse.com> (raw)

On Fr, 2018-06-29 at 16:45 +0200, Miguel Rodríguez Pérez  wrote:
> Subject: [PATCH 1/2] Hook into usbnet_change_mtu respecting usbnet
> driver_info
> 
> Change the way cdc_ncm_change_mtu hooks into the netdev_ops
> structure so that changes into usbnet driver_info operations
> can be respected. Without this, is was not possible to hook
> into usbnet_set_rx_mode.

Hi,

what is wrong with the existing hook?

static void __handle_set_rx_mode(struct usbnet *dev)
{
        if (dev->driver_info->set_rx_mode)
                (dev->driver_info->set_rx_mode)(dev);

        clear_bit(EVENT_SET_RX_MODE, &dev->flags);
}

If you cannot use it, I would prefer you to actually fix that.

	Regards
		Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-06-29 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-29 20:37 Oliver Neukum [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-06-30 14:24 [1/2] cdc_ncm: Handle multicast Ethernet traffic Miguel Rodríguez Pérez
2018-06-30 13:41 Miguel Rodríguez Pérez
2018-06-29 18:15 Greg KH
2018-06-29 14:47 Miguel Rodríguez Pérez
2018-06-29 14:45 Miguel Rodríguez Pérez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530304678.20408.1.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=miguel@det.uvigo.gal \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.