Re: [PATCH v2 1/3] drm/mtk: Remove impossible internal error

From: CK Hu <ck.hu@mediatek.com>
To: Daniel Stone <daniels@collabora.com>
Cc: Thierry Reding <treding@nvidia.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm/mtk: Remove impossible internal error
Date: Mon, 2 Jul 2018 09:46:50 +0800	[thread overview]
Message-ID: <1530496010.5161.1.camel@mtksdaap41> (raw)
In-Reply-To: <20180518134705.12533-1-daniels@collabora.com>

Hi, Daniel:

For the series, applied to mediatek-drm-next-4.19 [1].

[1]
https://github.com/ckhu-mediatek/linux.git-tags/commits/mediatek-drm-next-4.19

Regards,
CK

On Fri, 2018-05-18 at 14:47 +0100, Daniel Stone wrote:
> We cannot create a framebuffer with no objects, so there's no point
> testing for it.
> 
> v2: Remove the error entirely. (Sean, CK, Thierry)
> 
> Signed-off-by: Daniel Stone <daniels@collabora.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: CK Hu <ck.hu@mediatek.com>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_plane.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index 2f4b0ffee598..149fc4372917 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -95,11 +95,6 @@ static int mtk_plane_atomic_check(struct drm_plane *plane,
>  	if (!fb)
>  		return 0;
>  
> -	if (!mtk_fb_get_gem_obj(fb)) {
> -		DRM_DEBUG_KMS("buffer is null\n");
> -		return -EFAULT;
> -	}
> -
>  	if (!state->crtc)
>  		return 0;
>  

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel