All of lore.kernel.org
 help / color / mirror / Atom feed
From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map
Date: Mon, 02 Jul 2018 22:34:19 +0900	[thread overview]
Message-ID: <1530538459.13674.12.camel@gmail.com> (raw)
In-Reply-To: <20180702132704.3nwi4y6ex6fn5z67@linux-x5ow.site>

On Mon, 2018-07-02 at 15:27 +0200, Johannes Thumshirn wrote:
> On Mon, Jul 02, 2018 at 10:20:03PM +0900, Minwoo Im wrote:
> [...]
> > 
> > > 
> > > You could still evaluate if it isn't worth to make it:
> > > +static void blk_mq_clear_mq_map(struct blk_mq_tag_set *set)
> > > +{
> > > +	int cpu;
> > > +
> > > +	for_each_possible_cpu(cpu)
> > > +		set->mq_map[cpu] = 0;
> > > +}
> > > 
> > > and put it into 'include/linux/blk-mq.h'.
> > Do you mean this whole bunch of function should be moved into blk-mq.h with
> > 'inline' format?
> yes

Johannes,

I was wondering you did mean 'inline' or not because the function in the
previous mail only with 'static' without 'inline' keyword :)
That's why I asked it one more time to figure out what you really mean.

I really appreciate your kindly directives.

I'll make it up for v2 patch.

Thanks, really.

	Minwoo Im

  reply	other threads:[~2018-07-02 13:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-30 16:21 [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map Minwoo Im
2018-07-02  8:15 ` Johannes Thumshirn
2018-07-02 12:55   ` Minwoo Im
2018-07-02 13:02     ` Johannes Thumshirn
2018-07-02 13:20       ` Minwoo Im
2018-07-02 13:27         ` Johannes Thumshirn
2018-07-02 13:34           ` Minwoo Im [this message]
2018-07-02 13:41             ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530538459.13674.12.camel@gmail.com \
    --to=minwoo.im.dev@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=jthumshirn@suse.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.