From: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
To: apw@canonical.com, joe@perches.com
Cc: linux-kernel@vger.kernel.org, ckadabi@codeaurora.org,
tsoni@codeaurora.org, bryanh@codeaurora.org,
Israel Schlesinger <israels@codeaurora.org>,
Stepan Moskovchenko <stepanm@codeaurora.org>,
Prakruthi Deepak Heragu <pheragu@codeaurora.org>
Subject: [PATCH] checkpatch: Add warnings for use of mdelay()
Date: Wed, 4 Jul 2018 11:18:53 -0700 [thread overview]
Message-ID: <1530728333-31590-1-git-send-email-pheragu@codeaurora.org> (raw)
mdelay() is not a preferred API to be used to insert delay in the kernel
code unless the context is atomic. Instead, msleep() API can be used.
This patch introduces this warning.
Signed-off-by: Israel Schlesinger <israels@codeaurora.org>
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a9c0550..14bba3f 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5572,6 +5572,12 @@ sub process {
"Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
}
+# check the patch for use of mdelay
+ if ($line =~ /\bmdelay\s*\(/) {
+ WARN("MDELAY",
+ "use of mdelay() found: msleep() is the preferred API.\n" . $herecurr );
+ }
+
# warn about #ifdefs in C files
# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
# print "#ifdef in C files should be avoided\n";
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2018-07-04 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 18:18 Prakruthi Deepak Heragu [this message]
2018-07-04 18:30 ` [PATCH] checkpatch: Add warnings for use of mdelay() Joe Perches
2018-07-05 8:19 ` Dan Carpenter
2018-07-06 5:49 ` Julia Lawall
2018-07-07 12:09 ` Jia-Ju Bai
-- strict thread matches above, loose matches on Subject: below --
2010-07-27 17:11 Israel Schlesinger
2010-07-27 17:22 ` Joe Perches
2010-07-27 17:31 ` Jonathan Corbet
2010-07-27 17:32 ` Patrick Pannuto
2010-07-27 19:16 ` Andrew Morton
2010-07-28 9:44 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530728333-31590-1-git-send-email-pheragu@codeaurora.org \
--to=pheragu@codeaurora.org \
--cc=apw@canonical.com \
--cc=bryanh@codeaurora.org \
--cc=ckadabi@codeaurora.org \
--cc=israels@codeaurora.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stepanm@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.