From: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
To: apw@canonical.com, joe@perches.com
Cc: linux-kernel@vger.kernel.org, ckadabi@codeaurora.org,
tsoni@codeaurora.org, bryanh@codeaurora.org,
Prakruthi Deepak Heragu <pheragu@codeaurora.org>
Subject: [PATCH] checkpatch: Add exceptions for dsb keyword usage
Date: Thu, 5 Jul 2018 11:19:36 -0700 [thread overview]
Message-ID: <1530814776-16988-1-git-send-email-pheragu@codeaurora.org> (raw)
mb() API can relpace the dsb() API in the kernel code. So, dsb() usage
is discouraged. However, there are exceptions when dsb is used in a
variable or a function name. Exceptions are when 'dsb' is prefixed with
class [-_>*\.] and/or suffixed with class [-_\.;].
Signed-off-by: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a9c0550..978c752 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5372,6 +5372,12 @@ sub process {
"Avoid line continuations in quoted strings\n" . $herecurr);
}
+# dsb is too ARMish, and should usually be mb.
+ if ($line =~ /[^-_>*\.]\bdsb\b[^-_\.;]/) {
+ WARN("ARM_BARRIER",
+ "Use of dsb is discouranged: prefer mb.\n" .
+ $herecurr);
+ }
# warn about #if 0
if ($line =~ /^.\s*\#\s*if\s+0\b/) {
CHK("REDUNDANT_CODE",
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2018-07-05 18:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 18:19 Prakruthi Deepak Heragu [this message]
2018-07-05 21:14 ` [PATCH] checkpatch: Add exceptions for dsb keyword usage Joe Perches
2018-07-05 21:14 ` Joe Perches
2018-07-06 5:45 ` Mark Rutland
2018-07-06 5:45 ` Mark Rutland
2018-07-06 5:52 ` Joe Perches
2018-07-06 5:52 ` Joe Perches
2018-07-06 17:00 ` pheragu at codeaurora.org
2018-07-06 17:00 ` pheragu
2018-07-06 17:02 ` pheragu at codeaurora.org
2018-07-06 17:02 ` pheragu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530814776-16988-1-git-send-email-pheragu@codeaurora.org \
--to=pheragu@codeaurora.org \
--cc=apw@canonical.com \
--cc=bryanh@codeaurora.org \
--cc=ckadabi@codeaurora.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.