All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chee, Tien Fong <tien.fong.chee@intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] arm: dts: socfpga: stratix10: update pdma
Date: Tue, 10 Jul 2018 13:11:50 +0000	[thread overview]
Message-ID: <1531228309.9725.7.camel@intel.com> (raw)
In-Reply-To: <a9e5f694-5cbb-ff7e-5d30-f045d849a199@denx.de>

On Mon, 2018-07-09 at 22:28 +0200, Marek Vasut wrote:
> On 07/09/2018 08:03 PM, Dinh Nguyen wrote:
> > 
> > 
> > 
> > On 05/31/2018 03:08 AM, tien.fong.chee at intel.com wrote:
> > > 
> > > From: Tien Fong Chee <tien.fong.chee@intel.com>
> > > 
> > > Update pdma properties for Stratix 10
> > > 
> > > Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> > > ---
> > >  arch/arm/dts/socfpga_stratix10.dtsi | 20 ++++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/arch/arm/dts/socfpga_stratix10.dtsi
> > > b/arch/arm/dts/socfpga_stratix10.dtsi
> > > index ccd3f32..311ba09 100644
> > > --- a/arch/arm/dts/socfpga_stratix10.dtsi
> > > +++ b/arch/arm/dts/socfpga_stratix10.dtsi
> > > @@ -82,6 +82,26 @@
> > >  		ranges = <0 0 0 0xffffffff>;
> > >  		u-boot,dm-pre-reloc;
> > >  
> > > +		amba {
> > > +			u-boot,dm-pre-reloc;
> > > +			compatible = "arm,amba-bus";
> > > +			#address-cells = <1>;
> > > +			#size-cells = <1>;
> > > +			ranges;
> > > +
> > > +			pdma: pdma at ffda0000 {
> > > +					u-boot,dm-pre-reloc;
> > > +					compatible =
> > > "arm,pl330", "arm,dma330";
> > I think you got "arm,dma330" binding wrong. I don't see any binding
> > with
> > that name.
Here https://patchwork.ozlabs.org/patch/923234/ .
> I think the whole idea of using pl330 to scrub ECC DRAM is wrong. It
> adds massive amount of code while a CPU can do the same and faster,
> cfr
> arria10.
> 
I just measured the performance of initializing DRAM based on custodian
arria10_sdmmc, which is around 16sec with 1GB.

Using DMA to init the DDR, which is around 3-4sec for 2GB. I attached
screenshot for the print out based on arria10_sdmmc custodian.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sdram_ecc_timing.png
Type: image/png
Size: 119153 bytes
Desc: sdram_ecc_timing.png
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180710/bf2d3d41/attachment.png>

  reply	other threads:[~2018-07-10 13:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31  8:08 [U-Boot] [PATCH 0/5] Add DMA driver for DMA330 controller tien.fong.chee at intel.com
2018-05-31  8:08 ` [U-Boot] [PATCH 1/5] drivers: dma: Enable DMA-330 driver support tien.fong.chee at intel.com
2018-06-01 14:24   ` Simon Glass
2018-06-06  5:22     ` Chee, Tien Fong
2018-05-31  8:08 ` [U-Boot] [PATCH 2/5] drivers: dma: Add function to zeroes a range of destination such as memory tien.fong.chee at intel.com
2018-06-01 14:24   ` Simon Glass
2018-06-04  7:34     ` Chee, Tien Fong
2018-05-31  8:08 ` [U-Boot] [PATCH 3/5] drivers: dma: Factor out dma_get_device from DMA class function tien.fong.chee at intel.com
2018-06-01 14:25   ` Simon Glass
2018-05-31  8:08 ` [U-Boot] [PATCH 4/5] include: dma: Update the function description for dma_memcpy tien.fong.chee at intel.com
2018-06-01 14:25   ` Simon Glass
2018-06-04  7:14     ` Chee, Tien Fong
2018-06-08 21:59       ` Simon Glass
2018-06-11  5:05         ` Chee, Tien Fong
2018-05-31  8:08 ` [U-Boot] [PATCH 5/5] arm: dts: socfpga: stratix10: update pdma tien.fong.chee at intel.com
2018-06-01 14:25   ` Simon Glass
2018-06-04  7:01     ` Chee, Tien Fong
2018-07-09 18:03   ` Dinh Nguyen
2018-07-09 20:28     ` Marek Vasut
2018-07-10 13:11       ` Chee, Tien Fong [this message]
2018-07-10 13:37         ` Dinh Nguyen
2018-07-11  2:55           ` Chee, Tien Fong
2018-07-10 16:13         ` Marek Vasut
2018-05-31  9:24 ` [U-Boot] [PATCH 0/5] Add DMA driver for DMA330 controller Marek Vasut
2018-05-31  9:50   ` See, Chin Liang
2018-05-31  9:58     ` Marek Vasut
2018-06-04  6:47       ` Chee, Tien Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531228309.9725.7.camel@intel.com \
    --to=tien.fong.chee@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.