From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC From: Paul Cercueil Message-Id: <1531237286.17118.2@crapouillou.net> Date: Tue, 10 Jul 2018 17:41:26 +0200 To: Vinod Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org List-ID: TGUgbHVuLiA5IGp1aWwuIDIwMTggw6AgMTk6MTAsIFZpbm9kIDx2a291bEBrZXJuZWwub3JnPiBh IMOpY3JpdCA6Cj4gT24gMDMtMDctMTgsIDE0OjMyLCBQYXVsIENlcmN1ZWlsIHdyb3RlOgo+IAo+ PiAgK3N0YXRpYyBpbmxpbmUgdm9pZCBqejQ3ODBfZG1hX2NoYW5fZGlzYWJsZShzdHJ1Y3Qgano0 NzgwX2RtYV9kZXYgCj4+ICpqemRtYSwKPj4gICsJdW5zaWduZWQgaW50IGNobikKPj4gICt7Cj4+ ICArCWlmIChqemRtYS0+dmVyc2lvbiA9PSBJRF9KWjQ3NzApCj4+ICArCQlqejQ3ODBfZG1hX2N0 cmxfd3JpdGVsKGp6ZG1hLCBKWl9ETUFfUkVHX0RDS0VDLCBCSVQoY2huKSk7Cj4+ICArfQo+IAo+ IHRoaXMgc291bmRzIGFzIGhhcmR3YXJlIGJlaGF2aW91ciwgc28gd2h5IG5vdCBkZXNjcmliZSBh cyBhIHByb3BlcnR5IAo+IGluCj4gRFQ/CgpTZWUgbXkgcmVzcG9uc2UgdG8geW91ciBtZXNzYWdl IG9uIHBhdGNoIDEuCgo+PiAgKwo+PiAgIHN0YXRpYyBzdHJ1Y3Qgano0NzgwX2RtYV9kZXNjICpq ejQ3ODBfZG1hX2Rlc2NfYWxsb2MoCj4+ICAgCXN0cnVjdCBqejQ3ODBfZG1hX2NoYW4gKmp6Y2hh biwgdW5zaWduZWQgaW50IGNvdW50LAo+PiAgIAllbnVtIGRtYV90cmFuc2FjdGlvbl90eXBlIHR5 cGUpCj4+ICBAQCAtMjI4LDggKzI0NiwxNSBAQCBzdGF0aWMgdm9pZCBqejQ3ODBfZG1hX2Rlc2Nf ZnJlZShzdHJ1Y3QgCj4+IHZpcnRfZG1hX2Rlc2MgKnZkZXNjKQo+PiAgIAlrZnJlZShkZXNjKTsK Pj4gICB9Cj4+IAo+PiAgLXN0YXRpYyB1aW50MzJfdCBqejQ3ODBfZG1hX3RyYW5zZmVyX3NpemUo dW5zaWduZWQgbG9uZyB2YWwsIAo+PiB1aW50MzJfdCAqc2hpZnQpCj4+ICArc3RhdGljIGNvbnN0 IHVuc2lnbmVkIGludCBqejQ3ODBfZG1hX29yZF9tYXhbXSA9IHsKPj4gICsJW0lEX0paNDc3MF0g PSA2LAo+PiAgKwlbSURfSlo0NzgwXSA9IDcsCj4+ICArfTsKPiAKPiBTbyB0aGlzIGdpdmVzIHRo ZSB0cmFuc2ZlciBsZW5ndGggc3VwcG9ydGVkPwoKWWVzLCBleGFjdGx5LiBUaGUgbWF4aW11bSB0 cmFuc2ZlciBzaXplIGlzICgxIDw8IG9yZCkuCgo+IC0tCj4gflZpbm9kCi0tLQpUbyB1bnN1YnNj cmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgZG1hZW5naW5l IiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpN b3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1p bmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 10 Jul 2018 17:41:42 +0200 (CEST) Received: from outils.crapouillou.net ([89.234.176.41]:49570 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23994272AbeGJPlcCuMb- convert rfc822-to-8bit (ORCPT ); Tue, 10 Jul 2018 17:41:32 +0200 Date: Tue, 10 Jul 2018 17:41:26 +0200 From: Paul Cercueil Subject: Re: [PATCH 04/14] dmaengine: dma-jz4780: Add support for the JZ4770 SoC To: Vinod Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Message-Id: <1531237286.17118.2@crapouillou.net> In-Reply-To: <20180709171032.GJ22377@vkoul-mobl> References: <20180703123214.23090-1-paul@crapouillou.net> <20180703123214.23090-5-paul@crapouillou.net> <20180709171032.GJ22377@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1531237291; bh=d6WE7oAW3jTKnldJTv4nfQHOE3iDxU8Ba4ktfujz9hc=; h=Date:From:Subject:To:Cc:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; b=TtFbvyldGrWPA010Fu8NOoUy8G3lf4isV0/xHdwMbVgUeaOzenH/5dY+UbGhP7GjcBSXA/7Y4PWI1U82h5BjDYmH+u6YH1dgPyV7eJWZwYFG9ZpBGwbOsBidGK/0BrzPWJqoggaUzzrbSimfZ170hFxbXN7+vAT5p36iHk+NLPk= Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 64759 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul@crapouillou.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Le lun. 9 juil. 2018 à 19:10, Vinod a écrit : > On 03-07-18, 14:32, Paul Cercueil wrote: > >> +static inline void jz4780_dma_chan_disable(struct jz4780_dma_dev >> *jzdma, >> + unsigned int chn) >> +{ >> + if (jzdma->version == ID_JZ4770) >> + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKEC, BIT(chn)); >> +} > > this sounds as hardware behaviour, so why not describe as a property > in > DT? See my response to your message on patch 1. >> + >> static struct jz4780_dma_desc *jz4780_dma_desc_alloc( >> struct jz4780_dma_chan *jzchan, unsigned int count, >> enum dma_transaction_type type) >> @@ -228,8 +246,15 @@ static void jz4780_dma_desc_free(struct >> virt_dma_desc *vdesc) >> kfree(desc); >> } >> >> -static uint32_t jz4780_dma_transfer_size(unsigned long val, >> uint32_t *shift) >> +static const unsigned int jz4780_dma_ord_max[] = { >> + [ID_JZ4770] = 6, >> + [ID_JZ4780] = 7, >> +}; > > So this gives the transfer length supported? Yes, exactly. The maximum transfer size is (1 << ord). > -- > ~Vinod