diff for duplicates of <1531323638.13297.24.camel@intel.com> diff --git a/a/content_digest b/N1/content_digest index 9170d5e..3336256 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -27,7 +27,10 @@ Mike Kravetz <mike.kravetz@oracle.com> Nadav Amit <nadav.amit@gmail.com> Oleg Nesterov <oleg@redhat.com> - " Pavel Machek <pavel@ucw.cz>Peter\0" + Pavel Machek <pavel@ucw.cz> + Peter Zijlstra <peterz@infradead.org> + Ravi V. Shankar <ravi.v.shankar@intel.com> + " Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>\0" "\00:1\0" "b\0" "On Wed, 2018-07-11 at 12:20 +0200, Ingo Molnar wrote:\n" @@ -123,4 +126,4 @@ "Thanks,\n" Yu-cheng -5f23c90455d1eb0d219f1462dffe651b4052d344308767ba5c5935a46398d5c9 +db6e02be7b0ff1b6ede8362af457c565ce09f1d69280f1b5d966ea8f56806bf1
diff --git a/a/1.txt b/N2/1.txt index 25f774b..6a15dbe 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -90,3 +90,8 @@ I don't know if I can change that, will find out. Thanks, Yu-cheng + +-- +To unsubscribe from this list: send the line "unsubscribe linux-doc" in +the body of a message to majordomo@vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 9170d5e..3ef2f57 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -27,7 +27,10 @@ Mike Kravetz <mike.kravetz@oracle.com> Nadav Amit <nadav.amit@gmail.com> Oleg Nesterov <oleg@redhat.com> - " Pavel Machek <pavel@ucw.cz>Peter\0" + Pavel Machek <pavel@ucw.cz> + Peter Zijlstra <peterz@infradead.org> + Ravi V. Shankar <ravi.v.shankar@intel.com> + " Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>\0" "\00:1\0" "b\0" "On Wed, 2018-07-11 at 12:20 +0200, Ingo Molnar wrote:\n" @@ -121,6 +124,11 @@ "I don't know if I can change that, will find out.\n" "\n" "Thanks,\n" - Yu-cheng + "Yu-cheng\n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-doc\" in\n" + "the body of a message to majordomo@vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -5f23c90455d1eb0d219f1462dffe651b4052d344308767ba5c5935a46398d5c9 +19f288030957cd3cdf55c0a29efd170ffe6bdd6c09dd48b79e773176bc0fbecb
diff --git a/a/1.txt b/N3/1.txt index 25f774b..f716d21 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -4,7 +4,7 @@ On Wed, 2018-07-11 at 12:20 +0200, Ingo Molnar wrote: > > > > Add PTRACE interface for CET MSRs. > Please *always* describe new ABIs in the changelog, in a precise, -> well-documented +> well-documentedA > way. Ok! @@ -15,26 +15,26 @@ Ok! > > --- a/arch/x86/kernel/ptrace.c > > +++ b/arch/x86/kernel/ptrace.c > > @@ -49,7 +49,9 @@ enum x86_regset { -> > REGSET_IOPERM64 = REGSET_XFP, -> > REGSET_XSTATE, -> > REGSET_TLS, +> > A REGSET_IOPERM64 = REGSET_XFP, +> > A REGSET_XSTATE, +> > A REGSET_TLS, > > + REGSET_CET64 = REGSET_TLS, -> > REGSET_IOPERM32, +> > A REGSET_IOPERM32, > > + REGSET_CET32, -> > }; +> > A }; > Why does REGSET_CET64 alias on REGSET_TLS? -In x86_64_regsets[], there is no [REGSET_TLS]. The core dump code +In x86_64_regsets[], there is no [REGSET_TLS]. A The core dump code cannot handle holes in the array. > > > -> > struct pt_regs_offset { +> > A struct pt_regs_offset { > > @@ -1276,6 +1278,13 @@ static struct user_regset x86_64_regsets[] > > __ro_after_init = { -> > .size = sizeof(long), .align = sizeof(long), -> > .active = ioperm_active, .get = ioperm_get -> > }, +> > A .size = sizeof(long), .align = sizeof(long), +> > A .active = ioperm_active, .get = ioperm_get +> > A }, > > + [REGSET_CET64] = { > > + .core_note_type = NT_X86_CET, > > + .n = sizeof(struct cet_user_state) / sizeof(u64), @@ -43,9 +43,9 @@ cannot handle holes in the array. > > + .set = cetregs_set > > + }, > Ok, could we first please make this part of the regset code more -> readable and +> readable andA > start the series with a standalone clean-up patch that changes these -> initializers +> initializersA > to something more readable: > > [REGSET_CET64] = { @@ -60,7 +60,7 @@ cannot handle holes in the array. > }, > > ? (I'm demonstrating the cleanup based on REGSET_CET64, but this -> should be done on +> should be done onA > every other entry first.) > @@ -71,17 +71,17 @@ I will fix it. > > --- a/include/uapi/linux/elf.h > > +++ b/include/uapi/linux/elf.h > > @@ -401,6 +401,7 @@ typedef struct elf64_shdr { -> > #define NT_386_TLS 0x200 /* i386 TLS slots +> > A #define NT_386_TLS 0x200 /* i386 TLS slots > > (struct user_desc) */ -> > #define NT_386_IOPERM 0x201 /* x86 io +> > A #define NT_386_IOPERM 0x201 /* x86 io > > permission bitmap (1=deny) */ -> > #define NT_X86_XSTATE 0x202 /* x86 extended +> > A #define NT_X86_XSTATE 0x202 /* x86 extended > > state using xsave */ > > +#define NT_X86_CET 0x203 /* x86 cet state */ > Acronyms in comments should be in capital letters. > > Also, I think I asked this before: why does "Control Flow -> Enforcement" abbreviate +> Enforcement" abbreviateA > to "CET" (which is a well-known acronym for "Central European Time"), > not to CFE? > diff --git a/a/content_digest b/N3/content_digest index 9170d5e..fcdc24c 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -27,7 +27,10 @@ Mike Kravetz <mike.kravetz@oracle.com> Nadav Amit <nadav.amit@gmail.com> Oleg Nesterov <oleg@redhat.com> - " Pavel Machek <pavel@ucw.cz>Peter\0" + Pavel Machek <pavel@ucw.cz> + Peter Zijlstra <peterz@infradead.org> + Ravi V. Shankar <ravi.v.shankar@intel.com> + " Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>\0" "\00:1\0" "b\0" "On Wed, 2018-07-11 at 12:20 +0200, Ingo Molnar wrote:\n" @@ -36,7 +39,7 @@ "> > \n" "> > Add PTRACE interface for CET MSRs.\n" "> Please *always* describe new ABIs in the changelog, in a precise,\n" - "> well-documented\302\240\n" + "> well-documentedA \n" "> way.\n" "\n" "Ok!\n" @@ -47,26 +50,26 @@ "> > --- a/arch/x86/kernel/ptrace.c\n" "> > +++ b/arch/x86/kernel/ptrace.c\n" "> > @@ -49,7 +49,9 @@ enum x86_regset {\n" - "> > \302\240\tREGSET_IOPERM64 = REGSET_XFP,\n" - "> > \302\240\tREGSET_XSTATE,\n" - "> > \302\240\tREGSET_TLS,\n" + "> > A \tREGSET_IOPERM64 = REGSET_XFP,\n" + "> > A \tREGSET_XSTATE,\n" + "> > A \tREGSET_TLS,\n" "> > +\tREGSET_CET64 = REGSET_TLS,\n" - "> > \302\240\tREGSET_IOPERM32,\n" + "> > A \tREGSET_IOPERM32,\n" "> > +\tREGSET_CET32,\n" - "> > \302\240};\n" + "> > A };\n" "> Why does REGSET_CET64 alias on REGSET_TLS?\n" "\n" - "In x86_64_regsets[], there is no [REGSET_TLS]. \302\240The core dump code\n" + "In x86_64_regsets[], there is no [REGSET_TLS]. A The core dump code\n" "cannot handle holes in the array.\n" "\n" "> \n" "> > \n" - "> > \302\240struct pt_regs_offset {\n" + "> > A struct pt_regs_offset {\n" "> > @@ -1276,6 +1278,13 @@ static struct user_regset x86_64_regsets[]\n" "> > __ro_after_init = {\n" - "> > \302\240\t\t.size = sizeof(long), .align = sizeof(long),\n" - "> > \302\240\t\t.active = ioperm_active, .get = ioperm_get\n" - "> > \302\240\t},\n" + "> > A \t\t.size = sizeof(long), .align = sizeof(long),\n" + "> > A \t\t.active = ioperm_active, .get = ioperm_get\n" + "> > A \t},\n" "> > +\t[REGSET_CET64] = {\n" "> > +\t\t.core_note_type = NT_X86_CET,\n" "> > +\t\t.n = sizeof(struct cet_user_state) / sizeof(u64),\n" @@ -75,9 +78,9 @@ "> > +\t\t.set = cetregs_set\n" "> > +\t},\n" "> Ok, could we first please make this part of the regset code more\n" - "> readable and\302\240\n" + "> readable andA \n" "> start the series with a standalone clean-up patch that changes these\n" - "> initializers\302\240\n" + "> initializersA \n" "> to something more readable:\n" "> \n" "> \t[REGSET_CET64] = {\n" @@ -92,7 +95,7 @@ "> \t},\n" "> \n" "> ? (I'm demonstrating the cleanup based on REGSET_CET64, but this\n" - "> should be done on\302\240\n" + "> should be done onA \n" "> every other entry first.)\n" "> \n" "\n" @@ -103,17 +106,17 @@ "> > --- a/include/uapi/linux/elf.h\n" "> > +++ b/include/uapi/linux/elf.h\n" "> > @@ -401,6 +401,7 @@ typedef struct elf64_shdr {\n" - "> > \302\240#define NT_386_TLS\t0x200\t\t/* i386 TLS slots\n" + "> > A #define NT_386_TLS\t0x200\t\t/* i386 TLS slots\n" "> > (struct user_desc) */\n" - "> > \302\240#define NT_386_IOPERM\t0x201\t\t/* x86 io\n" + "> > A #define NT_386_IOPERM\t0x201\t\t/* x86 io\n" "> > permission bitmap (1=deny) */\n" - "> > \302\240#define NT_X86_XSTATE\t0x202\t\t/* x86 extended\n" + "> > A #define NT_X86_XSTATE\t0x202\t\t/* x86 extended\n" "> > state using xsave */\n" "> > +#define NT_X86_CET\t0x203\t\t/* x86 cet state */\n" "> Acronyms in comments should be in capital letters.\n" "> \n" "> Also, I think I asked this before: why does \"Control Flow\n" - "> Enforcement\" abbreviate\302\240\n" + "> Enforcement\" abbreviateA \n" "> to \"CET\" (which is a well-known acronym for \"Central European Time\"),\n" "> not to CFE?\n" "> \n" @@ -123,4 +126,4 @@ "Thanks,\n" Yu-cheng -5f23c90455d1eb0d219f1462dffe651b4052d344308767ba5c5935a46398d5c9 +914f3db132264842e1e17196c2501d89b2e57bdb8d0311469f1b8b4e858029ca
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.