From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC From: Paul Cercueil Message-Id: <1531350835.2021.1@smtp.crapouillou.net> Date: Thu, 12 Jul 2018 01:13:55 +0200 To: Vinod Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org List-ID: TGUgbWVyLiAxMSBqdWlsLiAyMDE4IMOgIDE0OjE4LCBWaW5vZCA8dmtvdWxAa2VybmVsLm9yZz4g YSDDqWNyaXQgOgo+IE9uIDEwLTA3LTE4LCAxNzo0NSwgUGF1bCBDZXJjdWVpbCB3cm90ZToKPj4g Cj4+IAo+PiAgTGUgbHVuLiA5IGp1aWwuIDIwMTggw6AgMTk6MTQsIFZpbm9kIDx2a291bEBrZXJu ZWwub3JnPiBhIMOpY3JpdCA6Cj4+ICA+IE9uIDAzLTA3LTE4LCAxNDozMiwgUGF1bCBDZXJjdWVp bCB3cm90ZToKPj4gID4gPiAgVGhlIEpaNDcyNUIgaGFzIG9uZSBETUEgY29yZSBzdGFycmluZyBz aXggRE1BIGNoYW5uZWxzLgo+PiAgPiA+ICBBcyBmb3IgdGhlIEpaNDc3MCwgZWFjaCBETUEgY2hh bm5lbCdzIGNsb2NrIGNhbiBiZSBlbmFibGVkIHdpdGgKPj4gID4gPiAgYSByZWdpc3RlciB3cml0 ZSwgdGhlIGRpZmZlcmVuY2UgaGVyZSBiZWluZyB0aGF0IG9uY2Ugc3RhcnRlZCwgCj4+IGl0Cj4+ ICA+ID4gIGlzIG5vdCBwb3NzaWJsZSB0byB0dXJuIGl0IG9mZi4KPj4gID4KPj4gID4gb2sgc28g ZGlzYWJsZSBmb3IgdGhpcywgcmlnaHQuLgo+PiAgPgo+PiAgPiA+ICBAQCAtMjA0LDYgKzIwNSw4 IEBAIHN0YXRpYyBpbmxpbmUgdm9pZAo+PiAgPiA+IGp6NDc4MF9kbWFfY2hhbl9lbmFibGUoc3Ry dWN0IGp6NDc4MF9kbWFfZGV2ICpqemRtYSwKPj4gID4gPiAgIHsKPj4gID4gPiAgIAlpZiAoanpk bWEtPnZlcnNpb24gPT0gSURfSlo0NzcwKQo+PiAgPiA+ICAgCQlqejQ3ODBfZG1hX2N0cmxfd3Jp dGVsKGp6ZG1hLCBKWl9ETUFfUkVHX0RDS0VTLCBCSVQoY2huKSk7Cj4+ICA+ID4gICsJZWxzZSBp ZiAoanpkbWEtPnZlcnNpb24gPT0gSURfSlo0NzI1QikKPj4gID4gPiAgKwkJano0NzgwX2RtYV9j dHJsX3dyaXRlbChqemRtYSwgSlpfRE1BX1JFR19EQ0tFLCBCSVQoY2huKSk7Cj4+ICA+Cj4+ICA+ IGJ1dCB5b3UgYXJlIHdyaXRpbmcgdG8gYSBkaWZmZXJlbnQgcmVnaXN0ZXIgaGVyZS4uCj4+IAo+ PiAgWWVzLiBTb0NzID49IEpaNDc3MCBoYXZlIHRoZSBEQ0tFIHJlYWQtb25seSByZWdpc3Rlciwg YW5kIAo+PiBEQ0tFUy9EQ0tFQyB0bwo+PiAgc2V0L2NsZWFyIGJpdHMgaW4gRENLRS4KPj4gIE9u IEpaNDcyNUIsIERDS0UgaXMgcmVhZC93cml0ZSwgYnV0IHRoZSB6ZXJvcyB3cml0dGVuIGFyZSBp Z25vcmVkIAo+PiAoYXQgbGVhc3QKPj4gIHRoYXQncyB3aGF0IHRoZQo+PiAgZG9jdW1lbnRhdGlv biBzYXlzKS4KPiAKPiBhbmQgdGhhdCB3YXMgbm90IGRvY3VtZW50ZWQgaW4gdGhlIGxvZy4uLiBz byBpIHRob3VnaCBpdCBtYXliZSBhIHR5cG8uCgpSaWdodCwgSSB3aWxsIGFkZCBhIGNvbW1lbnQg aW4tY29kZSB0byBleHBsYWluIHRoYXQgaXQncyBub3JtYWwuCgo+IC0tCj4gflZpbm9kCgpUaGFu a3MsCi1QYXVsCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGlu ZSAidW5zdWJzY3JpYmUgZG1hZW5naW5lIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFq b3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdl ci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 12 Jul 2018 01:14:08 +0200 (CEST) Received: from outils.crapouillou.net ([89.234.176.41]:60234 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993888AbeGKXOCHt037 convert rfc822-to-8bit (ORCPT ); Thu, 12 Jul 2018 01:14:02 +0200 Date: Thu, 12 Jul 2018 01:13:55 +0200 From: Paul Cercueil Subject: Re: [PATCH 06/14] dmaengine: dma-jz4780: Add support for the JZ4725B SoC To: Vinod Cc: Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , James Hogan , Zubair Lutfullah Kakakhel , Mathieu Malaterre , Daniel Silsby , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Message-Id: <1531350835.2021.1@smtp.crapouillou.net> In-Reply-To: <20180711121818.GT3219@vkoul-mobl> References: <20180703123214.23090-1-paul@crapouillou.net> <20180703123214.23090-7-paul@crapouillou.net> <20180709171458.GL22377@vkoul-mobl> <1531237502.17118.3@crapouillou.net> <20180711121818.GT3219@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 8BIT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1531350841; bh=3IQoraoleuUeQ63djCofqFXR2MJYkQlo2+8Sv8HIKRg=; h=Date:From:Subject:To:Cc:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; b=AHpNzfXC8Qk059jiK9VSb4qqtVv9cn4PV/OiNjjMZtH+MgFWRdRovTGD3EIgXI5RfqjWmjsEeSHeg+b7s3fgoOb49kJLnM3Iw2Q/22ADfMKPTcUvUWPSTGKTfEmuvep1GFHW3Y6HzrSLPLVVJbICtOjw/ymL4G/Q8JZedd4WmDw= Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 64807 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul@crapouillou.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Le mer. 11 juil. 2018 à 14:18, Vinod a écrit : > On 10-07-18, 17:45, Paul Cercueil wrote: >> >> >> Le lun. 9 juil. 2018 à 19:14, Vinod a écrit : >> > On 03-07-18, 14:32, Paul Cercueil wrote: >> > > The JZ4725B has one DMA core starring six DMA channels. >> > > As for the JZ4770, each DMA channel's clock can be enabled with >> > > a register write, the difference here being that once started, >> it >> > > is not possible to turn it off. >> > >> > ok so disable for this, right.. >> > >> > > @@ -204,6 +205,8 @@ static inline void >> > > jz4780_dma_chan_enable(struct jz4780_dma_dev *jzdma, >> > > { >> > > if (jzdma->version == ID_JZ4770) >> > > jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKES, BIT(chn)); >> > > + else if (jzdma->version == ID_JZ4725B) >> > > + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKE, BIT(chn)); >> > >> > but you are writing to a different register here.. >> >> Yes. SoCs >= JZ4770 have the DCKE read-only register, and >> DCKES/DCKEC to >> set/clear bits in DCKE. >> On JZ4725B, DCKE is read/write, but the zeros written are ignored >> (at least >> that's what the >> documentation says). > > and that was not documented in the log... so i though it maybe a typo. Right, I will add a comment in-code to explain that it's normal. > -- > ~Vinod Thanks, -Paul