From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "tszucs@protonmail.ch" <tszucs@protonmail.ch>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>
Cc: "jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [RESEND PATCH] mmc: tegra: enable ddr_signaling for MMC_TIMING_MMC_DDR52
Date: Thu, 12 Jul 2018 20:28:49 +0000 [thread overview]
Message-ID: <1531427327.5479.4.camel@toradex.com> (raw)
In-Reply-To: <20180712173837.2921-1-tszucs@protonmail.ch>
On Thu, 2018-07-12 at 19:38 +0200, Tamás Szűcs wrote:
> This fixes sampling errors with eMMC modules using DDR52 when host
> capabilities
> via setting NVQUIRK_ENABLE_DDR50 and NVQUIRK_ENABLE_SDHCI_SPEC_300
> are enabled.
>
> Signed-off-by: Tamás Szűcs <tszucs@protonmail.ch>
> ---
> drivers/mmc/host/sdhci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-
> tegra.c
> index 970d38f68939..a3bfaa7067c8 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -228,7 +228,7 @@ static void tegra_sdhci_set_uhs_signaling(struct
> sdhci_host *host,
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct sdhci_tegra *tegra_host =
> sdhci_pltfm_priv(pltfm_host);
>
> - if (timing == MMC_TIMING_UHS_DDR50)
> + if (timing == MMC_TIMING_UHS_DDR50 || timing ==
> MMC_TIMING_MMC_DDR52)
> tegra_host->ddr_signaling = true;
>
> sdhci_set_uhs_signaling(host, timing);
This is really a duplicate of Stefan's "[PATCH 2/3] mmc: tegra: fix eMMC DDR52
mode" [1] resp. Stefan's is a duplicate of Tamás'. We missed it as it somehow
bounced the tegra mailing list. We basically investigated this upon Tamás'
request (u-blox being our customer) more or less in parallel.
[1] https://lore.kernel.org/lkml/20180712073904.4705-2-stefan@agner.ch
prev parent reply other threads:[~2018-07-12 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 17:38 [RESEND PATCH] mmc: tegra: enable ddr_signaling for MMC_TIMING_MMC_DDR52 Tamás Szűcs
2018-07-12 20:28 ` Marcel Ziswiler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531427327.5479.4.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=adrian.hunter@intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tszucs@protonmail.ch \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.