From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 2/2] drm/i915/mst: Continue state updates even if AUX writes fail. Date: Thu, 19 Jul 2018 11:51:40 -0700 Message-ID: <1532026300.28553.81.camel@intel.com> References: <20180718171943.3246-1-dhinakaran.pandiyan@intel.com> <20180718171943.3246-2-dhinakaran.pandiyan@intel.com> <20180719054316.GN2146@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 686706E2F7 for ; Thu, 19 Jul 2018 18:26:31 +0000 (UTC) In-Reply-To: <20180719054316.GN2146@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTA3LTE4IGF0IDIyOjQzIC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4g T24gV2VkLCBKdWwgMTgsIDIwMTggYXQgMTA6MTk6NDNBTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiA+IAo+ID4gV2UgYXJlIHRvbyBsYXRlIGluIHRoZSBlbmFibGluZyBzZXF1 ZW5jZSB0byBiYWNrIG91dCBjbGVhbmx5LCBub3QKPiA+IHVwZGF0aW5nCj4gPiBzdGF0ZSB0cmFj a2luZyB2YXJpYWJsZXMsIGxpa2UgaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MgaW4gdGhpcwo+ ID4gaW5zdGFuY2UsIHJlc3VsdHMgaW4gaW5jb3JyZWN0IGJlaGF2aW91ciBmdXJ0aGVyIGFsb25n Lgo+IEkgYWdyZWUgd2l0aCB5b3UsIGFsdGhvdWdoIEknbSBub3QgZnVsbHkgY29udmluY2VkIHRo YXQgd2UgbmVlZCB0bwo+IGNhbGwgdGhlCj4gdXBkYXRlIHBheWxvYWQgaWYgdmNwaSBhbGxvY2F0 aW9uIGZhaWxlZC4uLgoKQnV0IHRoZXJlIGlzIG1vcmUgcGF5bG9hZCB1cGRhdGUgY29kZSBpbiBp bnRlbF9tc3RfZW5hYmxlX2RwKCksIHRoYXQKd291bGQgZ2V0IGV4ZWN1dGVkIHJlZ2FyZGxlc3Mg b2YgdGhpcyBkaWZmIGJlbG93LiBXZSdsbCBoYXZlIHRvIHJld3JpdGUKcHJlX2VuYWJsZSwgZW5h YmxlLCBkaXNhYmxlIGFuZCBwb3N0X2Rpc2FibGUgaWYgdGhlIGlkZWEgaXMgYXZvaWQgc2luawp0 cmFuc2FjdGlvbnMgYWZ0ZXIgdGhlIGZpcnN0IGZhaWx1cmUuIEl0IGRvZXMgbWFrZSBzZW5zZSB0 byBkbyBhbGwgb2YKdGhhdCBhcyBpdCBhdm9pZHMgcHJpbnRpbmcgZXJyb3IgbWVzc2FnZXMgaW4g ZG1lc2cgd2hlbiB3ZSB2ZXJ5IHdlbGwKa25vdyB0aGUgYnJhbmNoIGRldmljZSBpcyBkaXNjb25u ZWN0ZWQsIGJ1dCB0aGlzIHNob3VsZCBiZSBhIHNlcGFyYXRlCmNoYW5nZS4gTXkgaWRlYSB3YXMg dG8gYnJpbmcgcHJlX2VuYWJsZS9lbmFibGUgaW4gbGluZSB3aXRoCmRpc2FibGUvcG9zdF9kaXNh YmxlLgoKCj4gCj4gc28gaW1obyB0aGlzIGVudGlyZSBmdW5jdGlvbiBzaG91bGQgYmUgcmV3b3Jr ZWQgdG8gYmUgbGlrZSB0aGlzOgo+IAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwX21zdC5jCj4gQEAgLTIxNyw3ICsyMTcsNiBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tc3RfcHJl X2VuYWJsZV9kcChzdHJ1Y3QKPiBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+IMKgwqDCoMKgwqDC oMKgwqBlbnVtIHBvcnQgcG9ydCA9IGludGVsX2RpZ19wb3J0LT5iYXNlLnBvcnQ7Cj4gwqDCoMKg wqDCoMKgwqDCoHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciA9Cj4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB0b19pbnRlbF9jb25uZWN0b3IoY29ubl9zdGF0ZS0+Y29u bmVjdG9yKTsKPiAtwqDCoMKgwqDCoMKgwqBpbnQgcmV0Owo+IMKgwqDCoMKgwqDCoMKgwqB1aW50 MzJfdCB0ZW1wOwo+IMKgCj4gwqDCoMKgwqDCoMKgwqDCoC8qIE1TVCBlbmNvZGVycyBhcmUgYm91 bmQgdG8gYSBjcnRjLCBub3QgdG8gYSBjb25uZWN0b3IsCj4gQEAgLTIzMywyNSArMjMyLDE1IEBA IHN0YXRpYyB2b2lkIGludGVsX21zdF9wcmVfZW5hYmxlX2RwKHN0cnVjdAo+IGludGVsX2VuY29k ZXIgKmVuY29kZXIsCj4gwqAKPiDCoMKgwqDCoMKgwqDCoMKgZHJtX2RwX3NlbmRfcG93ZXJfdXBk b3duX3BoeSgmaW50ZWxfZHAtPm1zdF9tZ3IsIGNvbm5lY3Rvci0KPiA+cG9ydCwgdHJ1ZSk7Cj4g wqAKPiAtwqDCoMKgwqDCoMKgwqBpZiAoaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MgPT0gMCkK PiArwqDCoMKgwqDCoMKgwqBpZiAoaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MrKyA9PSAwKQo+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaW50ZWxfZGlnX3BvcnQtPmJhc2UucHJl X2VuYWJsZSgmaW50ZWxfZGlnX3BvcnQtCj4gPmJhc2UsCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgcGlwZV9jb25maWcsIE5VTEwpOwo+IMKgCj4gLcKgwqDCoMKgwqDC oMKgcmV0ID0gZHJtX2RwX21zdF9hbGxvY2F0ZV92Y3BpKCZpbnRlbF9kcC0+bXN0X21nciwKPiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoGNvbm5lY3Rvci0+cG9ydCwKPiAtwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oHBpcGVfY29uZmlnLT5wYm4sCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBwaXBlX2NvbmZpZy0+ZHBf bV9uLnR1KTsKPiAtwqDCoMKgwqDCoMKgwqBpZiAocmV0ID09IGZhbHNlKSB7Cj4gK8KgwqDCoMKg wqDCoMKgaWYgKGRybV9kcF9tc3RfYWxsb2NhdGVfdmNwaSgmaW50ZWxfZHAtPm1zdF9tZ3IsIGNv bm5lY3Rvci0KPiA+cG9ydCwKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcGlwZV9jb25maWctPnBibiwgcGlw ZV9jb25maWctCj4gPmRwX21fbi50dSkpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oGRybV9kcF91cGRhdGVfcGF5bG9hZF9wYXJ0MSgmaW50ZWxfZHAtPm1zdF9tZ3IpOwo+ICvCoMKg wqDCoMKgwqDCoGVsc2UKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoERSTV9FUlJP UigiZmFpbGVkIHRvIGFsbG9jYXRlIHZjcGlcbiIpOwo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqByZXR1cm47Cj4gLcKgwqDCoMKgwqDCoMKgfQo+IC0KPiAtCj4gLcKgwqDCoMKgwqDC oMKgaW50ZWxfZHAtPmFjdGl2ZV9tc3RfbGlua3MrKzsKPiAtwqDCoMKgwqDCoMKgwqB0ZW1wID0g STkxNV9SRUFEKERQX1RQX1NUQVRVUyhwb3J0KSk7Cj4gLcKgwqDCoMKgwqDCoMKgSTkxNV9XUklU RShEUF9UUF9TVEFUVVMocG9ydCksIHRlbXApOwo+IC0KPiAtwqDCoMKgwqDCoMKgwqByZXQgPSBk cm1fZHBfdXBkYXRlX3BheWxvYWRfcGFydDEoJmludGVsX2RwLT5tc3RfbWdyKTsKPiAKPiAKPiBw cm9iYWJseSB3aXRoCj4gLcKgwqDCoMKgwqDCoMKgdGVtcCA9IEk5MTVfUkVBRChEUF9UUF9TVEFU VVMocG9ydCkpOwo+IC3CoMKgwqDCoMKgwqDCoEk5MTVfV1JJVEUoRFBfVFBfU1RBVFVTKHBvcnQp LCB0ZW1wKTsKPiAKPiBpbiBhIHNlcGFyYXRlZCBwYXRjaC4gTm8gaWRlYSB3aHkgd2UgcmVhZCB0 aGlzIHN0YXVzIHJlZyBhbmQgd3JpdGUKPiBiYWNrLgpJdCBpcyBjbGVhcmluZyB0aGUgQUNUIHN0 YXR1cyBiaXQgYnkgd3JpdGluZyBhIDEuIEJzcGVjIGhhcyB0aGlzCnVuZGVywqBEUF9UUF9TVEFU VVM6MjQKCi1ESwoKPiBJIGRpZG4ndCBzZWUgb24gc3BlYyBhbnkgaW5kaWNhdGlvbiB0aGF0IHRo aXMgY2xlYW5zIGl0IG9yIHRoYXQgd2UKPiBuZWVkIHRoYXQKPiBmb3IgY2xlYW5pbmcgb3IgYW55 dGhpbmcgZWxzZS4KPiAKPiA+IAo+ID4gCj4gPiB2MjogRml4ZWQgaW50IHYvcyBib29sIGNvbXBh cmlzb24KPiA+IAo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ ID4gQ2M6IE5hdGhhbiBDaW9iYW51IDxuYXRoYW4uZC5jaW9iYW51QGxpbnV4LmludGVsLmNvbT4K PiA+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5 YW5AaW50ZWwuY29tPgo+ID4gLS0tCj4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw X21zdC5jIHwgNSArLS0tLQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDQg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcF9tc3QuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ ID4gaW5kZXggN2UzZTAxNjA3NjQzLi4xMTBlN2ZmMjJlZjcgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9tc3QuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHBfbXN0LmMKPiA+IEBAIC0yNDEsMTEgKzI0MSw4IEBAIHN0YXRpYyB2b2lk IGludGVsX21zdF9wcmVfZW5hYmxlX2RwKHN0cnVjdAo+ID4gaW50ZWxfZW5jb2RlciAqZW5jb2Rl ciwKPiA+IMKgCQkJCcKgwqDCoMKgwqDCoMKgY29ubmVjdG9yLT5wb3J0LAo+ID4gwqAJCQkJwqDC oMKgwqDCoMKgwqBwaXBlX2NvbmZpZy0+cGJuLAo+ID4gwqAJCQkJwqDCoMKgwqDCoMKgwqBwaXBl X2NvbmZpZy0+ZHBfbV9uLnR1KTsKPiA+IC0JaWYgKHJldCA9PSBmYWxzZSkgewo+ID4gKwlpZiAo IXJldCkKPiA+IMKgCQlEUk1fRVJST1IoImZhaWxlZCB0byBhbGxvY2F0ZSB2Y3BpXG4iKTsKPiA+ IC0JCXJldHVybjsKPiA+IC0JfQo+ID4gLQo+ID4gwqAKPiA+IMKgCWludGVsX2RwLT5hY3RpdmVf bXN0X2xpbmtzKys7Cj4gPiDCoAl0ZW1wID0gSTkxNV9SRUFEKERQX1RQX1NUQVRVUyhwb3J0KSk7 Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=