From mboxrd@z Thu Jan 1 00:00:00 1970 From: zohar@linux.ibm.com (Mimi Zohar) Date: Thu, 19 Jul 2018 18:39:17 -0400 Subject: [PATCH] security: export security_kernel_load_data to fix firmware_loader build In-Reply-To: <7a8dd892-39ec-3973-5f41-5ec23f1feb3f@infradead.org> References: <7a8dd892-39ec-3973-5f41-5ec23f1feb3f@infradead.org> Message-ID: <1532039957.4196.2.camel@linux.ibm.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org Thanks, Randy. On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y, > CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y: > > ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined! > > Signed-off-by: Randy Dunlap > Cc: James Morris > Cc: "Serge E. Hallyn" > Cc: linux-security-module at vger.kernel.org > Cc: Luis R. Rodriguez > --- > security/security.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20180717.orig/security/security.c > +++ linux-next-20180717/security/security.c > @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne > return ret; > return ima_load_data(id); > } > +EXPORT_SYMBOL_GPL(security_kernel_load_data); Arnd Bergmann already posted a similar patch, which is now staged in James' tree. Mimi > > int security_task_fix_setuid(struct cred *new, const struct cred *old, > int flags) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD9D2ECDE5F for ; Thu, 19 Jul 2018 22:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66C4220673 for ; Thu, 19 Jul 2018 22:39:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66C4220673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731443AbeGSXYh (ORCPT ); Thu, 19 Jul 2018 19:24:37 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55126 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731289AbeGSXYh (ORCPT ); Thu, 19 Jul 2018 19:24:37 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6JMY53G077646 for ; Thu, 19 Jul 2018 18:39:25 -0400 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2kb21kk8j5-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 19 Jul 2018 18:39:25 -0400 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Jul 2018 23:39:23 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 19 Jul 2018 23:39:20 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6JMdJil41877632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 19 Jul 2018 22:39:19 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8903742041; Fri, 20 Jul 2018 01:39:36 +0100 (BST) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB7AD4203F; Fri, 20 Jul 2018 01:39:35 +0100 (BST) Received: from dhcp-9-31-103-18.watson.ibm.com (unknown [9.31.103.18]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 20 Jul 2018 01:39:35 +0100 (BST) Subject: Re: [PATCH] security: export security_kernel_load_data to fix firmware_loader build From: Mimi Zohar To: Randy Dunlap , LKML , linux-security-module , James Morris , "Serge E. Hallyn" , "Luis R. Rodriguez" Cc: Greg Kroah-Hartman Date: Thu, 19 Jul 2018 18:39:17 -0400 In-Reply-To: <7a8dd892-39ec-3973-5f41-5ec23f1feb3f@infradead.org> References: <7a8dd892-39ec-3973-5f41-5ec23f1feb3f@infradead.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 18071922-0016-0000-0000-000001E8F5E8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071922-0017-0000-0000-0000323DB79B Message-Id: <1532039957.4196.2.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-19_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=15 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807190235 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, Randy. On Thu, 2018-07-19 at 13:15 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build error when CONFIG_FW_LOADER=m, CONFIG_FW_LOADER_USER_HELPER=y, > CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y, and CONFIG_SECURITY=y: > > ERROR: "security_kernel_load_data" [drivers/base/firmware_loader/firmware_class.ko] undefined! > > Signed-off-by: Randy Dunlap > Cc: James Morris > Cc: "Serge E. Hallyn" > Cc: linux-security-module@vger.kernel.org > Cc: Luis R. Rodriguez > --- > security/security.c | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20180717.orig/security/security.c > +++ linux-next-20180717/security/security.c > @@ -1121,6 +1121,7 @@ int security_kernel_load_data(enum kerne > return ret; > return ima_load_data(id); > } > +EXPORT_SYMBOL_GPL(security_kernel_load_data); Arnd Bergmann already posted a similar patch, which is now staged in James' tree. Mimi > > int security_task_fix_setuid(struct cred *new, const struct cred *old, > int flags) > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >