From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 735202096F34B for ; Fri, 20 Jul 2018 16:17:09 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [PATCHv3 1/2] libnvdimm: Use max contiguous area for namespace size Date: Fri, 20 Jul 2018 23:17:04 +0000 Message-ID: <1532128622.10343.28.camel@intel.com> References: <20180712154709.16444-1-keith.busch@intel.com> <1532119565.10343.15.camel@intel.com> <20180720214838.GB4864@localhost.localdomain> In-Reply-To: <20180720214838.GB4864@localhost.localdomain> Content-Language: en-US Content-ID: <6111878D459B934E9CA31AC472BA44D8@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Busch, Keith" Cc: "stable@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: On Fri, 2018-07-20 at 15:48 -0600, Keith Busch wrote: > On Fri, Jul 20, 2018 at 01:46:06PM -0700, Verma, Vishal L wrote: > > $ cat /sys/bus/nd/devices/region1/max_available_extent > > 17045651456 > > > > $ ndctl list -BNR --region=region1 > > [ > > { > > "provider":"ACPI.NFIT", > > "dev":"ndbus1", > > "regions":[ > > { > > "dev":"region1", > > "size":17045651456, > > "available_size":0, > > "type":"pmem", > > "numa_node":0, > > "persistence_domain":"unknown", > > "namespaces":[ > > { > > "dev":"namespace1.0", > > "mode":"raw", > > "size":17045651456, > > "sector_size":512, > > "blockdev":"pmem1", > > "numa_node":0 > > } > > ... > > > > As we saw, getting the "available_size" directly from the the > region's > sysfs entry also returned the same as max extent: > > $ cat /sys/bus/nd/devices/region1/available_size > 17045651456 > > The reason ndctl shows available_size as '0' is because the nstype is > neither of type PMEM nor BLK. > > So I think max_available_extent is doing the right thing. Yep, I agree. I did however see another potential breakage (the blk- exhaust unit test fails due to this) ndctl create-namespace --bus=nfit_test.0 creates a namespace on say region 3. That makes available_size for region3 zero (as reported by ndctl-list as well as directly from sysfs), but max_available_extent still shows the full size available. $ sudo ndctl create-namespace --bus=nfit_test.0 { "dev":"namespace3.0", "mode":"fsdax", "map":"dev", "size":"28.50 MiB (29.89 MB)", "uuid":"592071ed-0928-4be8-96fb-4be944e4c6f4", "raw_uuid":"c4ac44fa-d3bd-43ea-9a1a-3a083d9fed1d", "sector_size":512, "blockdev":"pmem3" } $ cat /sys/bus/nd/devices/region3/max_available_extent 33554432 $ cat /sys/bus/nd/devices/region3/available_size 0 And then a subsequent ndctl create-namespace --bus=nfit_test.0 sees the max_available extent on region 3 (with the corresponding ndctl patches for this applied), tries to create a namespace again there, and obviously fails. As a side note, I think it may be useful to include in the related ndctl patch, a json entry for the max_available_extent for region listings. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com ([134.134.136.24]:2319 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727571AbeGUAHe (ORCPT ); Fri, 20 Jul 2018 20:07:34 -0400 From: "Verma, Vishal L" To: "Busch, Keith" CC: "Williams, Dan J" , "ross.zwisler@linux.intel.com" , "linux-nvdimm@lists.01.org" , "Jiang, Dave" , "stable@vger.kernel.org" Subject: Re: [PATCHv3 1/2] libnvdimm: Use max contiguous area for namespace size Date: Fri, 20 Jul 2018 23:17:04 +0000 Message-ID: <1532128622.10343.28.camel@intel.com> References: <20180712154709.16444-1-keith.busch@intel.com> <1532119565.10343.15.camel@intel.com> <20180720214838.GB4864@localhost.localdomain> In-Reply-To: <20180720214838.GB4864@localhost.localdomain> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <6111878D459B934E9CA31AC472BA44D8@intel.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: DQpPbiBGcmksIDIwMTgtMDctMjAgYXQgMTU6NDggLTA2MDAsIEtlaXRoIEJ1c2NoIHdyb3RlOg0K PiBPbiBGcmksIEp1bCAyMCwgMjAxOCBhdCAwMTo0NjowNlBNIC0wNzAwLCBWZXJtYSwgVmlzaGFs IEwgd3JvdGU6DQo+ID4gJCBjYXQgL3N5cy9idXMvbmQvZGV2aWNlcy9yZWdpb24xL21heF9hdmFp bGFibGVfZXh0ZW50DQo+ID4gMTcwNDU2NTE0NTYNCj4gPiANCj4gPiAkIG5kY3RsIGxpc3QgLUJO UiAtLXJlZ2lvbj1yZWdpb24xDQo+ID4gWw0KPiA+ICAgew0KPiA+ICAgICAicHJvdmlkZXIiOiJB Q1BJLk5GSVQiLA0KPiA+ICAgICAiZGV2IjoibmRidXMxIiwNCj4gPiAgICAgInJlZ2lvbnMiOlsN Cj4gPiAgICAgICB7DQo+ID4gICAgICAgICAiZGV2IjoicmVnaW9uMSIsDQo+ID4gICAgICAgICAi c2l6ZSI6MTcwNDU2NTE0NTYsDQo+ID4gICAgICAgICAiYXZhaWxhYmxlX3NpemUiOjAsDQo+ID4g ICAgICAgICAidHlwZSI6InBtZW0iLA0KPiA+ICAgICAgICAgIm51bWFfbm9kZSI6MCwNCj4gPiAg ICAgICAgICJwZXJzaXN0ZW5jZV9kb21haW4iOiJ1bmtub3duIiwNCj4gPiAgICAgICAgICJuYW1l c3BhY2VzIjpbDQo+ID4gICAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICAiZGV2IjoibmFtZXNw YWNlMS4wIiwNCj4gPiAgICAgICAgICAgICAibW9kZSI6InJhdyIsDQo+ID4gICAgICAgICAgICAg InNpemUiOjE3MDQ1NjUxNDU2LA0KPiA+ICAgICAgICAgICAgICJzZWN0b3Jfc2l6ZSI6NTEyLA0K PiA+ICAgICAgICAgICAgICJibG9ja2RldiI6InBtZW0xIiwNCj4gPiAgICAgICAgICAgICAibnVt YV9ub2RlIjowDQo+ID4gICAgICAgICAgIH0NCj4gPiAJLi4uDQo+ID4gDQo+IA0KPiBBcyB3ZSBz YXcsIGdldHRpbmcgdGhlICJhdmFpbGFibGVfc2l6ZSIgZGlyZWN0bHkgZnJvbSB0aGUgdGhlDQo+ IHJlZ2lvbidzDQo+IHN5c2ZzIGVudHJ5IGFsc28gcmV0dXJuZWQgIHRoZSBzYW1lIGFzIG1heCBl eHRlbnQ6DQo+IA0KPiAgJCBjYXQgL3N5cy9idXMvbmQvZGV2aWNlcy9yZWdpb24xL2F2YWlsYWJs ZV9zaXplDQo+ICAxNzA0NTY1MTQ1Ng0KPiANCj4gVGhlIHJlYXNvbiBuZGN0bCBzaG93cyBhdmFp bGFibGVfc2l6ZSBhcyAnMCcgaXMgYmVjYXVzZSB0aGUgbnN0eXBlIGlzDQo+IG5laXRoZXIgb2Yg dHlwZSBQTUVNIG5vciBCTEsuDQo+IA0KPiBTbyBJIHRoaW5rIG1heF9hdmFpbGFibGVfZXh0ZW50 IGlzIGRvaW5nIHRoZSByaWdodCB0aGluZy4NCg0KWWVwLCBJIGFncmVlLiBJIGRpZCBob3dldmVy IHNlZSBhbm90aGVyIHBvdGVudGlhbCBicmVha2FnZSAodGhlIGJsay0NCmV4aGF1c3QgdW5pdCB0 ZXN0IGZhaWxzIGR1ZSB0byB0aGlzKQ0KDQoJbmRjdGwgY3JlYXRlLW5hbWVzcGFjZSAtLWJ1cz1u Zml0X3Rlc3QuMA0KDQpjcmVhdGVzIGEgbmFtZXNwYWNlIG9uIHNheSByZWdpb24gMy4gVGhhdCBt YWtlcyBhdmFpbGFibGVfc2l6ZSBmb3INCnJlZ2lvbjMgemVybyAoYXMgcmVwb3J0ZWQgYnkgbmRj dGwtbGlzdCBhcyB3ZWxsIGFzIGRpcmVjdGx5IGZyb20NCnN5c2ZzKSwgYnV0IG1heF9hdmFpbGFi bGVfZXh0ZW50IHN0aWxsIHNob3dzIHRoZSBmdWxsIHNpemUgYXZhaWxhYmxlLg0KDQogICAkIHN1 ZG8gbmRjdGwgY3JlYXRlLW5hbWVzcGFjZSAtLWJ1cz1uZml0X3Rlc3QuMCANCiAgIHsNCiAgICAg ImRldiI6Im5hbWVzcGFjZTMuMCIsDQogICAgICJtb2RlIjoiZnNkYXgiLA0KICAgICAibWFwIjoi ZGV2IiwNCiAgICAgInNpemUiOiIyOC41MCBNaUIgKDI5Ljg5IE1CKSIsDQogICAgICJ1dWlkIjoi NTkyMDcxZWQtMDkyOC00YmU4LTk2ZmItNGJlOTQ0ZTRjNmY0IiwNCiAgICAgInJhd191dWlkIjoi YzRhYzQ0ZmEtZDNiZC00M2VhLTlhMWEtM2EwODNkOWZlZDFkIiwNCiAgICAgInNlY3Rvcl9zaXpl Ijo1MTIsDQogICAgICJibG9ja2RldiI6InBtZW0zIg0KICAgfQ0KDQogICAkIGNhdCAvc3lzL2J1 cy9uZC9kZXZpY2VzL3JlZ2lvbjMvbWF4X2F2YWlsYWJsZV9leHRlbnQNCiAgIDMzNTU0NDMyDQoN CiAgICQgY2F0IC9zeXMvYnVzL25kL2RldmljZXMvcmVnaW9uMy9hdmFpbGFibGVfc2l6ZQ0KICAg MA0KDQpBbmQgdGhlbiBhIHN1YnNlcXVlbnQNCg0KCW5kY3RsIGNyZWF0ZS1uYW1lc3BhY2UgLS1i dXM9bmZpdF90ZXN0LjANCg0Kc2VlcyB0aGUgbWF4X2F2YWlsYWJsZSBleHRlbnQgb24gcmVnaW9u IDMgKHdpdGggdGhlIGNvcnJlc3BvbmRpbmcgbmRjdGwNCnBhdGNoZXMgZm9yIHRoaXMgYXBwbGll ZCksIHRyaWVzIHRvIGNyZWF0ZSBhIG5hbWVzcGFjZSBhZ2FpbiB0aGVyZSwgYW5kDQogb2J2aW91 c2x5IGZhaWxzLg0KDQpBcyBhIHNpZGUgbm90ZSwgSSB0aGluayBpdCBtYXkgYmUgdXNlZnVsIHRv IGluY2x1ZGUgaW4gdGhlIHJlbGF0ZWQNCm5kY3RsIHBhdGNoLCBhIGpzb24gZW50cnkgZm9yIHRo ZSBtYXhfYXZhaWxhYmxlX2V4dGVudCBmb3IgcmVnaW9uDQpsaXN0aW5ncy4NCg==