diff for duplicates of <1532424136.32306.3.camel@pengutronix.de> diff --git a/a/1.txt b/N1/1.txt index c3a98ed..7327df6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,13 @@ Am Montag, den 23.07.2018, 13:55 +0000 schrieb Robin Gong: > > -----Original Message----- -> > From: Lucas Stach [mailto:l.stach@pengutronix.de] -> > Sent: 2018年7月23日 18:54 -> > To: Robin Gong <yibin.gong@nxp.com>; vkoul@kernel.org; -> > dan.j.williams@intel.com; s.hauer@pengutronix.de; linux@armlinux.or +> > From: Lucas Stach [mailto:l.stach at pengutronix.de] +> > Sent: 2018?7?23? 18:54 +> > To: Robin Gong <yibin.gong@nxp.com>; vkoul at kernel.org; +> > dan.j.williams at intel.com; s.hauer at pengutronix.de; linux at armlinux.or > > g.uk -> > Cc: dmaengine@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; -> > kernel@pengutronix.de; linux-arm-kernel@lists.infradead.org; -> > linux-kernel@vger.kernel.org +> > Cc: dmaengine at vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>; +> > kernel at pengutronix.de; linux-arm-kernel at lists.infradead.org; +> > linux-kernel at vger.kernel.org > > Subject: Re: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 > > bds for one > > transfer @@ -29,7 +29,7 @@ Am Montag, den 23.07.2018, 13:55 +0000 schrieb Robin Gong: > > does "consisten" mean? Do you mean BDs should be contiguous in > > memory? > -> Yes, BDs should be contiguous one by one in memory. +> Yes, BDs should be contiguous??one by one in memory. Okay, but this isn't what the code change does. By increasing the size parameter of the dma pool you just allocate 20 times as much memory as @@ -54,8 +54,8 @@ Lucas > > > > > Signed-off-by: Robin Gong <yibin.gong@nxp.com> > > > --- -> > > drivers/dma/imx-sdma.c | 17 ++++++++++++++++- -> > > 1 file changed, 16 insertions(+), 1 deletion(-) +> > > ?drivers/dma/imx-sdma.c | 17 ++++++++++++++++- +> > > ?1 file changed, 16 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > > > index @@ -63,9 +63,9 @@ Lucas > > > --- a/drivers/dma/imx-sdma.c > > > +++ b/drivers/dma/imx-sdma.c > > > @@ -298,6 +298,15 @@ struct sdma_context_data { -> > > > u32 scratch7; +> > > > ? u32??scratch7; > > > -> > > } __attribute__ ((packed)); +> > > ?} __attribute__ ((packed)); > > > > > > +/* > > > + * All bds in one transfer should be consitent on SDMA. To @@ -86,24 +86,24 @@ Lucas > > > + */ > > > +#define NUM_BD 20 > > > -> > > struct sdma_engine; +> > > ?struct sdma_engine; > > > > > > @@ -1273,7 +1282,7 @@ static int sdma_alloc_chan_resources(struct > > > dma_chan *chan) -> > > > goto disable_clk_ahb; -> > > > sdmac->bd_pool = dma_pool_create("bd_pool", chan- +> > > > ? goto disable_clk_ahb; +> > > > ? sdmac->bd_pool = dma_pool_create("bd_pool", chan- > > > > >device->dev, > > > > - sizeof(struct > > > > sdma_buffer_descriptor), > > > > + NUM_BD * sizeof(struct > > > > sdma_buffer_descriptor), -> > > > 32, 0); -> > > > return 0; +> > > > ? 32, 0); +> > > > ? return 0; > > > > > > @@ -1314,6 +1323,12 @@ static struct sdma_desc > > > *sdma_transfer_init(struct sdma_channel *sdmac, -> > > { -> > > > struct sdma_desc *desc; +> > > ?{ +> > > > ? struct sdma_desc *desc; > > > > + if (bds > NUM_BD) { > > > > + dev_err(sdmac->sdma->dev, "%d bds exceed the > > > > max %d\n", @@ -112,10 +112,6 @@ Lucas > > > > + } > > > > > > + -> > > > desc = kzalloc((sizeof(*desc)), GFP_NOWAIT); -> > > > if (!desc) -> > > > goto err_out; ---- -To unsubscribe from this list: send the line "unsubscribe dmaengine" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html +> > > > ? desc = kzalloc((sizeof(*desc)), GFP_NOWAIT); +> > > > ? if (!desc) +> > > > ? goto err_out; diff --git a/a/content_digest b/N1/content_digest index 11b8c74..b2c1078 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,28 +1,23 @@ - "From\0Lucas Stach <l.stach@pengutronix.de>\0" - "Subject\0[v3,3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer\0" + "ref\01532367972-29707-1-git-send-email-yibin.gong@nxp.com\0" + "ref\01532367972-29707-4-git-send-email-yibin.gong@nxp.com\0" + "ref\01532343252.3163.99.camel@pengutronix.de\0" + "ref\0DB6PR04MB322323354B2184421502FC5889560@DB6PR04MB3223.eurprd04.prod.outlook.com\0" + "From\0l.stach@pengutronix.de (Lucas Stach)\0" + "Subject\0[PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer\0" "Date\0Tue, 24 Jul 2018 11:22:16 +0200\0" - "To\0Robin Gong <yibin.gong@nxp.com>" - vkoul@kernel.org <vkoul@kernel.org> - dan.j.williams@intel.com <dan.j.williams@intel.com> - s.hauer@pengutronix.de <s.hauer@pengutronix.de> - " linux@armlinux.org.uk <linux@armlinux.org.uk>\0" - "Cc\0dmaengine@vger.kernel.org <dmaengine@vger.kernel.org>" - dl-linux-imx <linux-imx@nxp.com> - kernel@pengutronix.de <kernel@pengutronix.de> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - " linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Am Montag, den 23.07.2018, 13:55 +0000 schrieb Robin Gong:\n" "> > -----Original Message-----\n" - "> > From: Lucas Stach [mailto:l.stach@pengutronix.de]\n" - "> > Sent: 2018\345\271\2647\346\234\21023\346\227\245 18:54\n" - "> > To: Robin Gong <yibin.gong@nxp.com>; vkoul@kernel.org;\n" - "> > dan.j.williams@intel.com; s.hauer@pengutronix.de; linux@armlinux.or\n" + "> > From: Lucas Stach [mailto:l.stach at pengutronix.de]\n" + "> > Sent: 2018?7?23? 18:54\n" + "> > To: Robin Gong <yibin.gong@nxp.com>; vkoul at kernel.org;\n" + "> > dan.j.williams at intel.com; s.hauer at pengutronix.de; linux at armlinux.or\n" "> > g.uk\n" - "> > Cc: dmaengine@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;\n" - "> > kernel@pengutronix.de; linux-arm-kernel@lists.infradead.org;\n" - "> > linux-kernel@vger.kernel.org\n" + "> > Cc: dmaengine at vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;\n" + "> > kernel at pengutronix.de; linux-arm-kernel at lists.infradead.org;\n" + "> > linux-kernel at vger.kernel.org\n" "> > Subject: Re: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20\n" "> > bds for one\n" "> > transfer\n" @@ -44,7 +39,7 @@ "> > does \"consisten\" mean? Do you mean BDs should be contiguous in\n" "> > memory?\n" "> \n" - "> Yes, BDs should be contiguous\302\240\302\240one by one in memory.\n" + "> Yes, BDs should be contiguous??one by one in memory.\n" "\n" "Okay, but this isn't what the code change does. By increasing the size\n" "parameter of the dma pool you just allocate 20 times as much memory as\n" @@ -69,8 +64,8 @@ "> > \n" "> > > Signed-off-by: Robin Gong <yibin.gong@nxp.com>\n" "> > > ---\n" - "> > > \302\240drivers/dma/imx-sdma.c | 17 ++++++++++++++++-\n" - "> > > \302\2401 file changed, 16 insertions(+), 1 deletion(-)\n" + "> > > ?drivers/dma/imx-sdma.c | 17 ++++++++++++++++-\n" + "> > > ?1 file changed, 16 insertions(+), 1 deletion(-)\n" "> > > \n" "> > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c\n" "> > > index\n" @@ -78,9 +73,9 @@ "> > > --- a/drivers/dma/imx-sdma.c\n" "> > > +++ b/drivers/dma/imx-sdma.c\n" "> > > @@ -298,6 +298,15 @@ struct sdma_context_data {\n" - "> > > > \302\240\tu32\302\240\302\240scratch7;\n" + "> > > > ?\tu32??scratch7;\n" "> > > \n" - "> > > \302\240} __attribute__ ((packed));\n" + "> > > ?} __attribute__ ((packed));\n" "> > > \n" "> > > +/*\n" "> > > + * All bds in one transfer should be consitent on SDMA. To\n" @@ -101,24 +96,24 @@ "> > > + */\n" "> > > +#define NUM_BD 20\n" "> > > \n" - "> > > \302\240struct sdma_engine;\n" + "> > > ?struct sdma_engine;\n" "> > > \n" "> > > @@ -1273,7 +1282,7 @@ static int sdma_alloc_chan_resources(struct\n" "> > > dma_chan *chan)\n" - "> > > > \302\240\t\tgoto disable_clk_ahb;\n" - "> > > > \302\240\tsdmac->bd_pool = dma_pool_create(\"bd_pool\", chan-\n" + "> > > > ?\t\tgoto disable_clk_ahb;\n" + "> > > > ?\tsdmac->bd_pool = dma_pool_create(\"bd_pool\", chan-\n" "> > > > >device->dev,\n" "> > > > -\t\t\t\tsizeof(struct\n" "> > > > sdma_buffer_descriptor),\n" "> > > > +\t\t\t\tNUM_BD * sizeof(struct\n" "> > > > sdma_buffer_descriptor),\n" - "> > > > \302\240\t\t\t\t32, 0);\n" - "> > > > \302\240\treturn 0;\n" + "> > > > ?\t\t\t\t32, 0);\n" + "> > > > ?\treturn 0;\n" "> > > \n" "> > > @@ -1314,6 +1323,12 @@ static struct sdma_desc\n" "> > > *sdma_transfer_init(struct sdma_channel *sdmac,\n" - "> > > \302\240{\n" - "> > > > \302\240\tstruct sdma_desc *desc;\n" + "> > > ?{\n" + "> > > > ?\tstruct sdma_desc *desc;\n" "> > > > +\tif (bds > NUM_BD) {\n" "> > > > +\t\tdev_err(sdmac->sdma->dev, \"%d bds exceed the\n" "> > > > max %d\\n\",\n" @@ -127,12 +122,8 @@ "> > > > +\t}\n" "> > > \n" "> > > +\n" - "> > > > \302\240\tdesc = kzalloc((sizeof(*desc)), GFP_NOWAIT);\n" - "> > > > \302\240\tif (!desc)\n" - "> > > > \302\240\t\tgoto err_out;\n" - "---\n" - "To unsubscribe from this list: send the line \"unsubscribe dmaengine\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "> > > > ?\tdesc = kzalloc((sizeof(*desc)), GFP_NOWAIT);\n" + "> > > > ?\tif (!desc)\n" + "> > > > ?\t\tgoto err_out;" -e5710246d3826b3ab96de2d3c2be5ab2bf70e128b4dc3beb75a04c73b39e4952 +1b24edfed2041b0e27e31b863fe68cc9eadbba5ecf678db61d86097efc1254e8
diff --git a/a/1.txt b/N2/1.txt index c3a98ed..98f4958 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -115,7 +115,3 @@ Lucas > > > > desc = kzalloc((sizeof(*desc)), GFP_NOWAIT); > > > > if (!desc) > > > > goto err_out; ---- -To unsubscribe from this list: send the line "unsubscribe dmaengine" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 11b8c74..426f27b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,5 +1,9 @@ + "ref\01532367972-29707-1-git-send-email-yibin.gong@nxp.com\0" + "ref\01532367972-29707-4-git-send-email-yibin.gong@nxp.com\0" + "ref\01532343252.3163.99.camel@pengutronix.de\0" + "ref\0DB6PR04MB322323354B2184421502FC5889560@DB6PR04MB3223.eurprd04.prod.outlook.com\0" "From\0Lucas Stach <l.stach@pengutronix.de>\0" - "Subject\0[v3,3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer\0" + "Subject\0Re: [PATCH v3 3/3] dmaengine: imx-sdma: allocate max 20 bds for one transfer\0" "Date\0Tue, 24 Jul 2018 11:22:16 +0200\0" "To\0Robin Gong <yibin.gong@nxp.com>" vkoul@kernel.org <vkoul@kernel.org> @@ -129,10 +133,6 @@ "> > > +\n" "> > > > \302\240\tdesc = kzalloc((sizeof(*desc)), GFP_NOWAIT);\n" "> > > > \302\240\tif (!desc)\n" - "> > > > \302\240\t\tgoto err_out;\n" - "---\n" - "To unsubscribe from this list: send the line \"unsubscribe dmaengine\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "> > > > \302\240\t\tgoto err_out;" -e5710246d3826b3ab96de2d3c2be5ab2bf70e128b4dc3beb75a04c73b39e4952 +0535256f0cab580eff7553c0ec4c78c1e613f281c0891776290b0c840cc98c93
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.