From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 57B15210C1B79 for ; Tue, 24 Jul 2018 14:39:01 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [PATCHv4 1/2] libnvdimm: Use max contiguous area for namespace size Date: Tue, 24 Jul 2018 21:38:59 +0000 Message-ID: <1532468337.8557.22.camel@intel.com> References: <20180724210758.14098-1-keith.busch@intel.com> In-Reply-To: <20180724210758.14098-1-keith.busch@intel.com> Content-Language: en-US Content-ID: <8405E8877322404CBFED518FFDB3F98E@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Busch, Keith" , "Jiang, Dave" , "linux-nvdimm@lists.01.org" Cc: "zwisler@kernel.org" , "stable@vger.kernel.org" , "gustavo@embeddedor.com" List-ID: On Tue, 2018-07-24 at 15:07 -0600, Keith Busch wrote: > This patch will find the max contiguous area to determine the largest > pmem namespace size that can be created. If the requested size exceeds > the largest available, ENOSPC error will be returned. > > This fixes the allocation underrun error and wrong error return code > that have otherwise been observed as the following kernel warning: > > WARNING: CPU: PID: at drivers/nvdimm/namespace_devs.c:913 size_store > > Fixes: a1f3e4d6a0c3 ("libnvdimm, region: update nd_region_available_dpa() for multi-pmem support") > Cc: > Signed-off-by: Keith Busch > --- > v3 -> v4: > > Actually constrain the reserved pmem to the region under consideration > rather than the mapping's dimm. This is done by directly calling > __reserve_free_pmem with the region's device instead of walking the > parent devices children. Thanks to Vishal Verma for reporting how > to trigger the incorrect reportings. > > Fixed a possible NULL deref, from Gustavo A. R. Silva. Looks good to me. Feel free to add: Reviewed-by: Vishal Verma > > drivers/nvdimm/dimm_devs.c | 31 +++++++++++++++++++++++++++++++ > drivers/nvdimm/namespace_devs.c | 6 +++--- > drivers/nvdimm/nd-core.h | 8 ++++++++ > drivers/nvdimm/region_devs.c | 24 ++++++++++++++++++++++++ > 4 files changed, 66 insertions(+), 3 deletions(-) > > diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c > index 8d348b22ba45..863cabc35215 100644 > --- a/drivers/nvdimm/dimm_devs.c > +++ b/drivers/nvdimm/dimm_devs.c > @@ -536,6 +536,37 @@ resource_size_t nd_blk_available_dpa(struct nd_region *nd_region) > return info.available; > } > > +/** > + * nd_pmem_max_contiguous_dpa - For the given dimm+region, return the max > + * contiguous unallocated dpa range. > + * @nd_region: constrain available space check to this reference region > + * @nd_mapping: container of dpa-resource-root + labels > + */ > +resource_size_t nd_pmem_max_contiguous_dpa(struct nd_region *nd_region, > + struct nd_mapping *nd_mapping) > +{ > + struct nvdimm_drvdata *ndd = to_ndd(nd_mapping); > + struct nvdimm_bus *nvdimm_bus; > + resource_size_t max = 0; > + struct resource *res; > + > + /* if a dimm is disabled the available capacity is zero */ > + if (!ndd) > + return 0; > + > + nvdimm_bus = walk_to_nvdimm_bus(ndd->dev); > + if (__reserve_free_pmem(&nd_region->dev, nd_mapping->nvdimm)) > + return 0; > + for_each_dpa_resource(ndd, res) { > + if (strcmp(res->name, "pmem-reserve") != 0) > + continue; > + if (resource_size(res) > max) > + max = resource_size(res); > + } > + release_free_pmem(nvdimm_bus, nd_mapping); > + return max; > +} > + > /** > * nd_pmem_available_dpa - for the given dimm+region account unallocated dpa > * @nd_mapping: container of dpa-resource-root + labels > diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c > index cb322f2bc605..4a4266250c28 100644 > --- a/drivers/nvdimm/namespace_devs.c > +++ b/drivers/nvdimm/namespace_devs.c > @@ -799,7 +799,7 @@ static int merge_dpa(struct nd_region *nd_region, > return 0; > } > > -static int __reserve_free_pmem(struct device *dev, void *data) > +int __reserve_free_pmem(struct device *dev, void *data) > { > struct nvdimm *nvdimm = data; > struct nd_region *nd_region; > @@ -836,7 +836,7 @@ static int __reserve_free_pmem(struct device *dev, void *data) > return 0; > } > > -static void release_free_pmem(struct nvdimm_bus *nvdimm_bus, > +void release_free_pmem(struct nvdimm_bus *nvdimm_bus, > struct nd_mapping *nd_mapping) > { > struct nvdimm_drvdata *ndd = to_ndd(nd_mapping); > @@ -1032,7 +1032,7 @@ static ssize_t __size_store(struct device *dev, unsigned long long val) > > allocated += nvdimm_allocated_dpa(ndd, &label_id); > } > - available = nd_region_available_dpa(nd_region); > + available = nd_region_allocatable_dpa(nd_region); > > if (val > available + allocated) > return -ENOSPC; > diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h > index 79274ead54fb..ac68072fb8cd 100644 > --- a/drivers/nvdimm/nd-core.h > +++ b/drivers/nvdimm/nd-core.h > @@ -100,6 +100,14 @@ struct nd_region; > struct nvdimm_drvdata; > struct nd_mapping; > void nd_mapping_free_labels(struct nd_mapping *nd_mapping); > + > +int __reserve_free_pmem(struct device *dev, void *data); > +void release_free_pmem(struct nvdimm_bus *nvdimm_bus, > + struct nd_mapping *nd_mapping); > + > +resource_size_t nd_pmem_max_contiguous_dpa(struct nd_region *nd_region, > + struct nd_mapping *nd_mapping); > +resource_size_t nd_region_allocatable_dpa(struct nd_region *nd_region); > resource_size_t nd_pmem_available_dpa(struct nd_region *nd_region, > struct nd_mapping *nd_mapping, resource_size_t *overlap); > resource_size_t nd_blk_available_dpa(struct nd_region *nd_region); > diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c > index ec3543b83330..c30d5af02cc2 100644 > --- a/drivers/nvdimm/region_devs.c > +++ b/drivers/nvdimm/region_devs.c > @@ -389,6 +389,30 @@ resource_size_t nd_region_available_dpa(struct nd_region *nd_region) > return available; > } > > +resource_size_t nd_region_allocatable_dpa(struct nd_region *nd_region) > +{ > + resource_size_t available = 0; > + int i; > + > + if (is_memory(&nd_region->dev)) > + available = PHYS_ADDR_MAX; > + > + WARN_ON(!is_nvdimm_bus_locked(&nd_region->dev)); > + for (i = 0; i < nd_region->ndr_mappings; i++) { > + struct nd_mapping *nd_mapping = &nd_region->mapping[i]; > + > + if (is_memory(&nd_region->dev)) > + available = min(available, > + nd_pmem_max_contiguous_dpa(nd_region, > + nd_mapping)); > + else if (is_nd_blk(&nd_region->dev)) > + available += nd_blk_available_dpa(nd_region); > + } > + if (is_memory(&nd_region->dev)) > + return available * nd_region->ndr_mappings; > + return available; > +} > + > static ssize_t available_size_show(struct device *dev, > struct device_attribute *attr, char *buf) > { _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com ([134.134.136.31]:15702 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbeGXWr1 (ORCPT ); Tue, 24 Jul 2018 18:47:27 -0400 From: "Verma, Vishal L" To: "Busch, Keith" , "Jiang, Dave" , "linux-nvdimm@lists.01.org" CC: "Williams, Dan J" , "gustavo@embeddedor.com" , "stable@vger.kernel.org" , "zwisler@kernel.org" Subject: Re: [PATCHv4 1/2] libnvdimm: Use max contiguous area for namespace size Date: Tue, 24 Jul 2018 21:38:59 +0000 Message-ID: <1532468337.8557.22.camel@intel.com> References: <20180724210758.14098-1-keith.busch@intel.com> In-Reply-To: <20180724210758.14098-1-keith.busch@intel.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <8405E8877322404CBFED518FFDB3F98E@intel.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: DQpPbiBUdWUsIDIwMTgtMDctMjQgYXQgMTU6MDcgLTA2MDAsIEtlaXRoIEJ1c2NoIHdyb3RlOg0K PiBUaGlzIHBhdGNoIHdpbGwgZmluZCB0aGUgbWF4IGNvbnRpZ3VvdXMgYXJlYSB0byBkZXRlcm1p bmUgdGhlIGxhcmdlc3QNCj4gcG1lbSBuYW1lc3BhY2Ugc2l6ZSB0aGF0IGNhbiBiZSBjcmVhdGVk LiBJZiB0aGUgcmVxdWVzdGVkIHNpemUgZXhjZWVkcw0KPiB0aGUgbGFyZ2VzdCBhdmFpbGFibGUs IEVOT1NQQyBlcnJvciB3aWxsIGJlIHJldHVybmVkLg0KPiANCj4gVGhpcyBmaXhlcyB0aGUgYWxs b2NhdGlvbiB1bmRlcnJ1biBlcnJvciBhbmQgd3JvbmcgZXJyb3IgcmV0dXJuIGNvZGUNCj4gdGhh dCBoYXZlIG90aGVyd2lzZSBiZWVuIG9ic2VydmVkIGFzIHRoZSBmb2xsb3dpbmcga2VybmVsIHdh cm5pbmc6DQo+IA0KPiAgIFdBUk5JTkc6IENQVTogPENQVT4gUElEOiA8UElEPiBhdCBkcml2ZXJz L252ZGltbS9uYW1lc3BhY2VfZGV2cy5jOjkxMyBzaXplX3N0b3JlDQo+IA0KPiBGaXhlczogYTFm M2U0ZDZhMGMzICgibGlibnZkaW1tLCByZWdpb246IHVwZGF0ZSBuZF9yZWdpb25fYXZhaWxhYmxl X2RwYSgpIGZvciBtdWx0aS1wbWVtIHN1cHBvcnQiKQ0KPiBDYzogPHN0YWJsZUB2Z2VyLmtlcm5l bC5vcmc+DQo+IFNpZ25lZC1vZmYtYnk6IEtlaXRoIEJ1c2NoIDxrZWl0aC5idXNjaEBpbnRlbC5j b20+DQo+IC0tLQ0KPiB2MyAtPiB2NDoNCj4gDQo+ICAgQWN0dWFsbHkgY29uc3RyYWluIHRoZSBy ZXNlcnZlZCBwbWVtIHRvIHRoZSByZWdpb24gdW5kZXIgY29uc2lkZXJhdGlvbg0KPiAgIHJhdGhl ciB0aGFuIHRoZSBtYXBwaW5nJ3MgZGltbS4gVGhpcyBpcyBkb25lIGJ5IGRpcmVjdGx5IGNhbGxp bmcNCj4gICBfX3Jlc2VydmVfZnJlZV9wbWVtIHdpdGggdGhlIHJlZ2lvbidzIGRldmljZSBpbnN0 ZWFkIG9mIHdhbGtpbmcgdGhlDQo+ICAgcGFyZW50IGRldmljZXMgY2hpbGRyZW4uIFRoYW5rcyB0 byBWaXNoYWwgVmVybWEgZm9yIHJlcG9ydGluZyBob3cNCj4gICB0byB0cmlnZ2VyIHRoZSBpbmNv cnJlY3QgcmVwb3J0aW5ncy4NCj4gDQo+ICAgRml4ZWQgYSBwb3NzaWJsZSBOVUxMIGRlcmVmLCBm cm9tIEd1c3Rhdm8gQS4gUi4gU2lsdmEuDQoNCkxvb2tzIGdvb2QgdG8gbWUuIEZlZWwgZnJlZSB0 byBhZGQ6DQpSZXZpZXdlZC1ieTogVmlzaGFsIFZlcm1hIDx2aXNoYWwubC52ZXJtYUBpbnRlbC5j b20+DQoNCj4gDQo+ICBkcml2ZXJzL252ZGltbS9kaW1tX2RldnMuYyAgICAgIHwgMzEgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKw0KPiAgZHJpdmVycy9udmRpbW0vbmFtZXNwYWNlX2Rl dnMuYyB8ICA2ICsrKy0tLQ0KPiAgZHJpdmVycy9udmRpbW0vbmQtY29yZS5oICAgICAgICB8ICA4 ICsrKysrKysrDQo+ICBkcml2ZXJzL252ZGltbS9yZWdpb25fZGV2cy5jICAgIHwgMjQgKysrKysr KysrKysrKysrKysrKysrKysrDQo+ICA0IGZpbGVzIGNoYW5nZWQsIDY2IGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9udmRpbW0vZGltbV9k ZXZzLmMgYi9kcml2ZXJzL252ZGltbS9kaW1tX2RldnMuYw0KPiBpbmRleCA4ZDM0OGIyMmJhNDUu Ljg2M2NhYmMzNTIxNSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9udmRpbW0vZGltbV9kZXZzLmMN Cj4gKysrIGIvZHJpdmVycy9udmRpbW0vZGltbV9kZXZzLmMNCj4gQEAgLTUzNiw2ICs1MzYsMzcg QEAgcmVzb3VyY2Vfc2l6ZV90IG5kX2Jsa19hdmFpbGFibGVfZHBhKHN0cnVjdCBuZF9yZWdpb24g Km5kX3JlZ2lvbikNCj4gIAlyZXR1cm4gaW5mby5hdmFpbGFibGU7DQo+ICB9DQo+ICANCj4gKy8q Kg0KPiArICogbmRfcG1lbV9tYXhfY29udGlndW91c19kcGEgLSBGb3IgdGhlIGdpdmVuIGRpbW0r cmVnaW9uLCByZXR1cm4gdGhlIG1heA0KPiArICoJCQkgICBjb250aWd1b3VzIHVuYWxsb2NhdGVk IGRwYSByYW5nZS4NCj4gKyAqIEBuZF9yZWdpb246IGNvbnN0cmFpbiBhdmFpbGFibGUgc3BhY2Ug Y2hlY2sgdG8gdGhpcyByZWZlcmVuY2UgcmVnaW9uDQo+ICsgKiBAbmRfbWFwcGluZzogY29udGFp bmVyIG9mIGRwYS1yZXNvdXJjZS1yb290ICsgbGFiZWxzDQo+ICsgKi8NCj4gK3Jlc291cmNlX3Np emVfdCBuZF9wbWVtX21heF9jb250aWd1b3VzX2RwYShzdHJ1Y3QgbmRfcmVnaW9uICpuZF9yZWdp b24sDQo+ICsJCQkJCSAgIHN0cnVjdCBuZF9tYXBwaW5nICpuZF9tYXBwaW5nKQ0KPiArew0KPiAr CXN0cnVjdCBudmRpbW1fZHJ2ZGF0YSAqbmRkID0gdG9fbmRkKG5kX21hcHBpbmcpOw0KPiArCXN0 cnVjdCBudmRpbW1fYnVzICpudmRpbW1fYnVzOw0KPiArCXJlc291cmNlX3NpemVfdCBtYXggPSAw Ow0KPiArCXN0cnVjdCByZXNvdXJjZSAqcmVzOw0KPiArDQo+ICsJLyogaWYgYSBkaW1tIGlzIGRp c2FibGVkIHRoZSBhdmFpbGFibGUgY2FwYWNpdHkgaXMgemVybyAqLw0KPiArCWlmICghbmRkKQ0K PiArCQlyZXR1cm4gMDsNCj4gKw0KPiArCW52ZGltbV9idXMgPSB3YWxrX3RvX252ZGltbV9idXMo bmRkLT5kZXYpOw0KPiArCWlmIChfX3Jlc2VydmVfZnJlZV9wbWVtKCZuZF9yZWdpb24tPmRldiwg bmRfbWFwcGluZy0+bnZkaW1tKSkNCj4gKwkJcmV0dXJuIDA7DQo+ICsJZm9yX2VhY2hfZHBhX3Jl c291cmNlKG5kZCwgcmVzKSB7DQo+ICsJCWlmIChzdHJjbXAocmVzLT5uYW1lLCAicG1lbS1yZXNl cnZlIikgIT0gMCkNCj4gKwkJCWNvbnRpbnVlOw0KPiArCQlpZiAocmVzb3VyY2Vfc2l6ZShyZXMp ID4gbWF4KQ0KPiArCQkJbWF4ID0gcmVzb3VyY2Vfc2l6ZShyZXMpOw0KPiArCX0NCj4gKwlyZWxl YXNlX2ZyZWVfcG1lbShudmRpbW1fYnVzLCBuZF9tYXBwaW5nKTsNCj4gKwlyZXR1cm4gbWF4Ow0K PiArfQ0KPiArDQo+ICAvKioNCj4gICAqIG5kX3BtZW1fYXZhaWxhYmxlX2RwYSAtIGZvciB0aGUg Z2l2ZW4gZGltbStyZWdpb24gYWNjb3VudCB1bmFsbG9jYXRlZCBkcGENCj4gICAqIEBuZF9tYXBw aW5nOiBjb250YWluZXIgb2YgZHBhLXJlc291cmNlLXJvb3QgKyBsYWJlbHMNCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvbnZkaW1tL25hbWVzcGFjZV9kZXZzLmMgYi9kcml2ZXJzL252ZGltbS9uYW1l c3BhY2VfZGV2cy5jDQo+IGluZGV4IGNiMzIyZjJiYzYwNS4uNGE0MjY2MjUwYzI4IDEwMDY0NA0K PiAtLS0gYS9kcml2ZXJzL252ZGltbS9uYW1lc3BhY2VfZGV2cy5jDQo+ICsrKyBiL2RyaXZlcnMv bnZkaW1tL25hbWVzcGFjZV9kZXZzLmMNCj4gQEAgLTc5OSw3ICs3OTksNyBAQCBzdGF0aWMgaW50 IG1lcmdlX2RwYShzdHJ1Y3QgbmRfcmVnaW9uICpuZF9yZWdpb24sDQo+ICAJcmV0dXJuIDA7DQo+ ICB9DQo+ICANCj4gLXN0YXRpYyBpbnQgX19yZXNlcnZlX2ZyZWVfcG1lbShzdHJ1Y3QgZGV2aWNl ICpkZXYsIHZvaWQgKmRhdGEpDQo+ICtpbnQgX19yZXNlcnZlX2ZyZWVfcG1lbShzdHJ1Y3QgZGV2 aWNlICpkZXYsIHZvaWQgKmRhdGEpDQo+ICB7DQo+ICAJc3RydWN0IG52ZGltbSAqbnZkaW1tID0g ZGF0YTsNCj4gIAlzdHJ1Y3QgbmRfcmVnaW9uICpuZF9yZWdpb247DQo+IEBAIC04MzYsNyArODM2 LDcgQEAgc3RhdGljIGludCBfX3Jlc2VydmVfZnJlZV9wbWVtKHN0cnVjdCBkZXZpY2UgKmRldiwg dm9pZCAqZGF0YSkNCj4gIAlyZXR1cm4gMDsNCj4gIH0NCj4gIA0KPiAtc3RhdGljIHZvaWQgcmVs ZWFzZV9mcmVlX3BtZW0oc3RydWN0IG52ZGltbV9idXMgKm52ZGltbV9idXMsDQo+ICt2b2lkIHJl bGVhc2VfZnJlZV9wbWVtKHN0cnVjdCBudmRpbW1fYnVzICpudmRpbW1fYnVzLA0KPiAgCQlzdHJ1 Y3QgbmRfbWFwcGluZyAqbmRfbWFwcGluZykNCj4gIHsNCj4gIAlzdHJ1Y3QgbnZkaW1tX2RydmRh dGEgKm5kZCA9IHRvX25kZChuZF9tYXBwaW5nKTsNCj4gQEAgLTEwMzIsNyArMTAzMiw3IEBAIHN0 YXRpYyBzc2l6ZV90IF9fc2l6ZV9zdG9yZShzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVkIGxv bmcgbG9uZyB2YWwpDQo+ICANCj4gIAkJYWxsb2NhdGVkICs9IG52ZGltbV9hbGxvY2F0ZWRfZHBh KG5kZCwgJmxhYmVsX2lkKTsNCj4gIAl9DQo+IC0JYXZhaWxhYmxlID0gbmRfcmVnaW9uX2F2YWls YWJsZV9kcGEobmRfcmVnaW9uKTsNCj4gKwlhdmFpbGFibGUgPSBuZF9yZWdpb25fYWxsb2NhdGFi bGVfZHBhKG5kX3JlZ2lvbik7DQo+ICANCj4gIAlpZiAodmFsID4gYXZhaWxhYmxlICsgYWxsb2Nh dGVkKQ0KPiAgCQlyZXR1cm4gLUVOT1NQQzsNCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbnZkaW1t L25kLWNvcmUuaCBiL2RyaXZlcnMvbnZkaW1tL25kLWNvcmUuaA0KPiBpbmRleCA3OTI3NGVhZDU0 ZmIuLmFjNjgwNzJmYjhjZCAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9udmRpbW0vbmQtY29yZS5o DQo+ICsrKyBiL2RyaXZlcnMvbnZkaW1tL25kLWNvcmUuaA0KPiBAQCAtMTAwLDYgKzEwMCwxNCBA QCBzdHJ1Y3QgbmRfcmVnaW9uOw0KPiAgc3RydWN0IG52ZGltbV9kcnZkYXRhOw0KPiAgc3RydWN0 IG5kX21hcHBpbmc7DQo+ICB2b2lkIG5kX21hcHBpbmdfZnJlZV9sYWJlbHMoc3RydWN0IG5kX21h cHBpbmcgKm5kX21hcHBpbmcpOw0KPiArDQo+ICtpbnQgX19yZXNlcnZlX2ZyZWVfcG1lbShzdHJ1 Y3QgZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEpOw0KPiArdm9pZCByZWxlYXNlX2ZyZWVfcG1lbShz dHJ1Y3QgbnZkaW1tX2J1cyAqbnZkaW1tX2J1cywNCj4gKwkJICAgICAgIHN0cnVjdCBuZF9tYXBw aW5nICpuZF9tYXBwaW5nKTsNCj4gKw0KPiArcmVzb3VyY2Vfc2l6ZV90IG5kX3BtZW1fbWF4X2Nv bnRpZ3VvdXNfZHBhKHN0cnVjdCBuZF9yZWdpb24gKm5kX3JlZ2lvbiwNCj4gKwkJCQkJICAgc3Ry dWN0IG5kX21hcHBpbmcgKm5kX21hcHBpbmcpOw0KPiArcmVzb3VyY2Vfc2l6ZV90IG5kX3JlZ2lv bl9hbGxvY2F0YWJsZV9kcGEoc3RydWN0IG5kX3JlZ2lvbiAqbmRfcmVnaW9uKTsNCj4gIHJlc291 cmNlX3NpemVfdCBuZF9wbWVtX2F2YWlsYWJsZV9kcGEoc3RydWN0IG5kX3JlZ2lvbiAqbmRfcmVn aW9uLA0KPiAgCQlzdHJ1Y3QgbmRfbWFwcGluZyAqbmRfbWFwcGluZywgcmVzb3VyY2Vfc2l6ZV90 ICpvdmVybGFwKTsNCj4gIHJlc291cmNlX3NpemVfdCBuZF9ibGtfYXZhaWxhYmxlX2RwYShzdHJ1 Y3QgbmRfcmVnaW9uICpuZF9yZWdpb24pOw0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9udmRpbW0v cmVnaW9uX2RldnMuYyBiL2RyaXZlcnMvbnZkaW1tL3JlZ2lvbl9kZXZzLmMNCj4gaW5kZXggZWMz NTQzYjgzMzMwLi5jMzBkNWFmMDJjYzIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbnZkaW1tL3Jl Z2lvbl9kZXZzLmMNCj4gKysrIGIvZHJpdmVycy9udmRpbW0vcmVnaW9uX2RldnMuYw0KPiBAQCAt Mzg5LDYgKzM4OSwzMCBAQCByZXNvdXJjZV9zaXplX3QgbmRfcmVnaW9uX2F2YWlsYWJsZV9kcGEo c3RydWN0IG5kX3JlZ2lvbiAqbmRfcmVnaW9uKQ0KPiAgCXJldHVybiBhdmFpbGFibGU7DQo+ICB9 DQo+ICANCj4gK3Jlc291cmNlX3NpemVfdCBuZF9yZWdpb25fYWxsb2NhdGFibGVfZHBhKHN0cnVj dCBuZF9yZWdpb24gKm5kX3JlZ2lvbikNCj4gK3sNCj4gKwlyZXNvdXJjZV9zaXplX3QgYXZhaWxh YmxlID0gMDsNCj4gKwlpbnQgaTsNCj4gKw0KPiArCWlmIChpc19tZW1vcnkoJm5kX3JlZ2lvbi0+ ZGV2KSkNCj4gKwkJYXZhaWxhYmxlID0gUEhZU19BRERSX01BWDsNCj4gKw0KPiArCVdBUk5fT04o IWlzX252ZGltbV9idXNfbG9ja2VkKCZuZF9yZWdpb24tPmRldikpOw0KPiArCWZvciAoaSA9IDA7 IGkgPCBuZF9yZWdpb24tPm5kcl9tYXBwaW5nczsgaSsrKSB7DQo+ICsJCXN0cnVjdCBuZF9tYXBw aW5nICpuZF9tYXBwaW5nID0gJm5kX3JlZ2lvbi0+bWFwcGluZ1tpXTsNCj4gKw0KPiArCQlpZiAo aXNfbWVtb3J5KCZuZF9yZWdpb24tPmRldikpDQo+ICsJCQlhdmFpbGFibGUgPSBtaW4oYXZhaWxh YmxlLA0KPiArCQkJCQluZF9wbWVtX21heF9jb250aWd1b3VzX2RwYShuZF9yZWdpb24sDQo+ICsJ CQkJCQkJCSAgIG5kX21hcHBpbmcpKTsNCj4gKwkJZWxzZSBpZiAoaXNfbmRfYmxrKCZuZF9yZWdp b24tPmRldikpDQo+ICsJCQlhdmFpbGFibGUgKz0gbmRfYmxrX2F2YWlsYWJsZV9kcGEobmRfcmVn aW9uKTsNCj4gKwl9DQo+ICsJaWYgKGlzX21lbW9yeSgmbmRfcmVnaW9uLT5kZXYpKQ0KPiArCQly ZXR1cm4gYXZhaWxhYmxlICogbmRfcmVnaW9uLT5uZHJfbWFwcGluZ3M7DQo+ICsJcmV0dXJuIGF2 YWlsYWJsZTsNCj4gK30NCj4gKw0KPiAgc3RhdGljIHNzaXplX3QgYXZhaWxhYmxlX3NpemVfc2hv dyhzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+ICAJCXN0cnVjdCBkZXZpY2VfYXR0cmlidXRlICphdHRy LCBjaGFyICpidWYpDQo+ICB7DQo=