From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id AD749E00A04; Wed, 1 Aug 2018 07:24:22 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (max.oss.09[at]gmail.com) * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [209.85.208.66 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 9E94FE009CF for ; Wed, 1 Aug 2018 07:24:19 -0700 (PDT) Received: by mail-ed1-f66.google.com with SMTP id t2-v6so6671861edr.5 for ; Wed, 01 Aug 2018 07:24:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:date:in-reply-to:references:mime-version :content-transfer-encoding; bh=DHjz3cQPLIC2Oi3MTPd7l+WBsoy0pfoWfWO7TEbTZYE=; b=clu931tEQZXGAoEPWNKBH8WVqzIRt7mvCc+LH8dGGkRTQTro/OQCgSf9EDaIgJBZ0c Qa/H+Pn9LeCTYxBAAF2x7uqh358zJ3ybz4V9cm6N2c11f1gv3+MIm5cpe7Wk/wmLSq6U CIMJc8Gl/m2WZtUGr9nk8zWQ92efJ1F9kb0FISQ3nKbX37vlqoJANU+czSLpty0JD2uw NU5zL8To4+46W/VgNQlLq6Bsxusci3YWDfrtyB127kTXqQFo0dPyfUJHXVtzOhnzG6M1 dIGm67WCbn9AUGXyUEHW0cPkoQrQmiBuPedEMsTEhn3IITb58fmb1IbvmBeKbvg0ar/c HLHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=DHjz3cQPLIC2Oi3MTPd7l+WBsoy0pfoWfWO7TEbTZYE=; b=Lz2O7FzfzPZ1nmUECrNGdKuXzEvyJ/HjCSPrATxQ09SPjDFG0j6loy9xAFzXpq5qFS Q6gyhdLMwQPymTrS7ZMqftLNcQ9W0wqXiXCo/2tI6QikKHfggaoTlCL+oE+IQ8gxEGgS 3UvLMyUQKkO3Y2UwjQQAb6FkLvnNCnI9Gc81UCE1lOfxLvsZI+G2a6BjNTQ3Hpl6H3Ox uqF8lx/NWkZ36sIebNV41sDhiQ7L2kMV1pOG+zQ18QJAlXEaxfkR6Tfc2jlCzw/PGiUT KgAyxYtLQotLSDIgvD/62GIeEa/hOmwH7CMxH1amTG3f78poP+9rVE4ybkxatjYSMA1E k41g== X-Gm-Message-State: AOUpUlH+XsQn+xfg9UAHca3OqEg7LJlZ1915hjgD/C5kFbxnDCi+oXRD ZazIJLsJL5nwj3CooLZ0a1A= X-Google-Smtp-Source: AAOMgpdcu1iU9qRACKoTdZKutOA1QM+399DeQuli7mYjHWrEx7ByDmSkvXoDJrVRIR7UXDps6lxxMw== X-Received: by 2002:a50:92c5:: with SMTP id l5-v6mr4202292eda.52.1533133458731; Wed, 01 Aug 2018 07:24:18 -0700 (PDT) Received: from Saturn.local.all ([195.48.14.138]) by smtp.gmail.com with ESMTPSA id o24-v6sm4472838edr.64.2018.08.01.07.24.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Aug 2018 07:24:17 -0700 (PDT) Message-ID: <1533133457.2950.23.camel@gmail.com> From: Max Krummenacher To: Tom Hochstein , meta-freescale@yoctoproject.org Date: Wed, 01 Aug 2018 16:24:17 +0200 In-Reply-To: <1532979851-21644-22-git-send-email-tom.hochstein@nxp.com> References: <1532979851-21644-1-git-send-email-tom.hochstein@nxp.com> <1532979851-21644-22-git-send-email-tom.hochstein@nxp.com> X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Subject: Re: [PATCH 51/52] bluez5: Apply patches for QCA6174 and QCA9377-3 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 14:24:22 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Resent, due to wrong sender address. Also cut out unneeded quote lines. Hi Does this really belong into meta-freescale? It looks like it is needed because some NXP boards use these chips. However they are not specific to NXP SoCs. And see inline comments below, I start them with 'MAX:': Regards Max Krummenacher Am Montag, den 30.07.2018, 14:44 -0500 schrieb Tom Hochstein: > Signed-off-by: Tom Hochstein --- recipes- > connectivity/bluez5/bluez5_5.%.bbappend | 14 + ...th-Add-bluetooth-support-for-QCA6174- > chip.patch | 2404 ++++++++++++++++++++ ...tach-set-flag-to-enable-HCI-reset-on-init.patch | 32 + ...nstead-of-strlcpy-with-strncpy-to-avoid-r.patch | 35 + 4 files changed, 2485 insertions(+) c > reate mode 100644 recipes-connectivity/bluez5/bluez5_5.%.bbappend create mode 100644 recipes- > connectivity/bluez5/files/0001-bluetooth-Add-bluetooth-support-for- QCA6174-chip.patch create mode > 100644 recipes-connectivity/bluez5/files/0002-hciattach-set-flag-to-enable-HCI-reset- on-init.patch create mode 100644 recipes-connectivity/bluez5/files/0003-hciattach-instead-of-strlcpy-with- strnc > py-to-avoid-r.patch diff --git a/recipes-connectivity/bluez5/bluez5_5.%.bbappend b/recipes- connectivity/bluez5/bluez5_5.%.bbappend new file mode 100644 index 0000000..00eb248 --- /dev/null +++ b/recipes-connectivity/bluez5/bluez5_5.%.bbappend @@ -0,0 +1,14 @@ +FILESEXTRAPATHS_prepend := "${THISDIR}/files:" + +# Do not start the service during system boot up +INITSCRIPT_PARAMS_${PN} = "stop 20 0 1 6 ." Max: That one would merit some text in the commit log. This changes behavior for all users of bluez5. But it looks that the line gets removed in the follow up patch so probably it can be deleted for good? > + +# Add patch for module bcm43xx +# Add patches for QCA modules with Qca6174 and Qca9377-3 chips +SR > C_URI += " \ + file://0001-bluetooth-Add-bluetooth-support-for-QCA6174-chip.patch \ + > file://0002-hciattach-set-flag-to-enable-HCI-reset-on-init.patch \ + file://0003 > -hciattach-instead-of-strlcpy-with-strncpy-to-avoid-r.patch \ + file://0004-Add-support- > for-Tufello-1.1-SOC.patch \ + file://0005-bluetooth-Add-support-for-multi-baud- > rate.patch \ Max: Patch 0004 and 0005 are only added with a follow up patch. IMHO one could squash the QCAxxxx and Tufello patches, if that is not desired then only add 0004 and 0005 to SRC_URI in the patch which actually does also add the corresponding files. > +" diff --git a/recipes-connectivity/bluez5/files/0001-bluetooth-Add-bluetooth-support-for-QCA6174- chip.patch b/recipes-connectivity/bluez5/files/0001-bluetooth-Add-bluetooth-support-for-QCA6174- ch > ip.patch new file mode 100644 index 0000000..5ae3c98 --- /dev/null +++ b/recipes- > connectivity/bluez5/files/0001-bluetooth-Add-bluetooth-support-for-QCA6174- chip.patch @@ -0,0 > +1,2404 @@ +From d509b84f237c11874087d7ea527e5ba2f460ed2c Mon Sep 17 00:00:00 2001 +From: Fugang > Duan +Date: Tue, 29 Aug 2017 10:12:57 +0800 +Subject: [PATCH 1/5] bluetooth : > Add bluetooth support for QCA6174 chip. + +Register the QCA6174 initialization routine with > hciattach for +downloading firmware patches to the bluetooth controller. +Add optional support 'f' > to control installation of line +discipline driver. Invoke hciattach from command line and +download > the firmware patches: + hciattach /dev/ttyHS0 qca 3000000 -t120 flow -f0 + +cherry-pick and > merged from: + https://source.codeaurora.org/quic/la/platform/external/bluetooth/bluez + branch: LNX.LE.5.3 + commit: commit bb96f3b759e0b99db70014302ca12929fb42f554 Max: I think a proper Upstream-Status: (with upstream meaning bluez.org) is missing. > + +Change-Id: I87f2927d7096904071a02d73d3afef0dc34db414 +Signed-off-by: Rupesh Tatiya urora.org> +Signed-off-by: Fugang Duan +--- + Makefile.tools | 3 +- + > tools/hciattach.c | 26 +- + tools/hciattach.h | 2 + + tools/hciattach_rome.c | 1864 > ++++++++++++++++++++++++++++++++++++++++++++++++ + tools/hciattach_rome.h | 371 ++++++++++ + 5 > files changed, 2264 insertions(+), 2 deletions(-) + diff --git a/recipes-connectivity/bluez5/files/0002-hciattach-set-flag-to-enable-HCI-reset-on- init.patch b/recipes-connectivity/bluez5/files/0002-hciattach-set-flag-to-enable-HCI-reset-on- init.patch new file mode 100644 index 0000000..a9ce17d --- /dev/null +++ b/recipes-connectivity/bluez5/files/0002-hciattach-set-flag-to-enable-HCI-reset-on-init.patch @@ -0,0 +1,32 @@ +From 3648d3c33b1dd0e11707328d87101d8044d23302 Mon Sep 17 00:00:00 2001 +From: Fugang Duan +Date: Tue, 29 Aug 2017 10:21:09 +0800 +Subject: [PATCH 2/5] hciattach: set flag to enable HCI reset on init + +On some qca devices, correct setup of BT+WLAN co-existance requires +HCI reset being set at the start of power on sequence. Sending HCI +resets has no side effect. + Max: Upstream-Status is missing. > +Change-Id: I71cb367d10d4d19d82b41af6a4a0b8b2f770f691 +Signed-off-by: Rupesh Tatiya rora.org> +--- > connectivity/bluez5/files/0003-hciattach-instead-of-strlcpy-with-strncpy-to-avoid- r.patch @@ -0,0 > +1,35 @@ +From 5877685b10560c40f1c4af375e30adf2a631fefc Mon Sep 17 00:00:00 2001 +From: Fugang Duan > +Date: Tue, 29 Aug 2017 14:54:44 +0800 +Subject: [PATCH 3/5] hciattach: > instead of strlcpy with strncpy to avoid rome + build error + +Instead of strlcpy with strncpy to > avoid rome build error. + +igned-off-by: Fugang Duan Max: Typo, missing 'S' Upstream-Status is missing. > +--- + tools/hciattach_rome.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git > a/tools/hciattach_rome.c b/tools/hciattach_rome.c +index 242a49f..c3e9fde 100644