From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stu Hsieh Subject: Re: [PATCH v1 06/15] drm/mediatek: add memory mode for RDMA Date: Thu, 2 Aug 2018 19:36:26 +0800 Message-ID: <1533209786.11190.60.camel@mtksdccf07> References: <1532420235-22268-1-git-send-email-stu.hsieh@mediatek.com> <1532420235-22268-7-git-send-email-stu.hsieh@mediatek.com> <1532486454.9280.12.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1532486454.9280.12.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: CK Hu Cc: srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIENLOgoKT24gV2VkLCAyMDE4LTA3LTI1IGF0IDEwOjQwICswODAwLCBDSyBIdSB3cm90ZToK PiBIaSwgU3R1Ogo+IAo+IE9uIFR1ZSwgMjAxOC0wNy0yNCBhdCAxNjoxNyArMDgwMCwgU3R1IEhz aWVoIHdyb3RlOgo+ID4gVGhpcyBwYXRjaCBhZGQgbWVtb3J5IG1vZGUgZm9yIFJETUEKPiA+IAo+ ID4gSWYgdXNlIFJETUEgdG8gcmVhZCBkYXRhIGZyb20gbWVtb3J5LCBpdCBzaG91bGQgc2V0IG1l bW9yeSBtb2RlIHRvIFJETUEKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogU3R1IEhzaWVoIDxzdHUu aHNpZWhAbWVkaWF0ZWsuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVr L210a19kaXNwX3JkbWEuYyB8IDE2ICsrKysrKysrKysrKysrKy0KPiA+ICAxIGZpbGUgY2hhbmdl ZCwgMTUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gCj4gWy4uLl0KPiAKPiA+ ICBzdGF0aWMgaW5saW5lIHN0cnVjdCBtdGtfZGlzcF9yZG1hICpjb21wX3RvX3JkbWEoc3RydWN0 IG10a19kZHBfY29tcCAqY29tcCkKPiA+IEBAIC0xMTEsNyArMTE2LDggQEAgc3RhdGljIHZvaWQg bXRrX3JkbWFfc3RhcnQoc3RydWN0IG10a19kZHBfY29tcCAqY29tcCkKPiA+ICAKPiA+ICBzdGF0 aWMgdm9pZCBtdGtfcmRtYV9zdG9wKHN0cnVjdCBtdGtfZGRwX2NvbXAgKmNvbXApCj4gPiAgewo+ ID4gLQlyZG1hX3VwZGF0ZV9iaXRzKGNvbXAsIERJU1BfUkVHX1JETUFfR0xPQkFMX0NPTiwgUkRN QV9FTkdJTkVfRU4sIDApOwo+ID4gKwl3cml0ZWwoUkRNQV9TT0ZUX1JFU0VULCBjb21wLT5yZWdz ICsgRElTUF9SRUdfUkRNQV9HTE9CQUxfQ09OKTsKPiA+ICsJd3JpdGVsKDAsIGNvbXAtPnJlZ3Mg KyBESVNQX1JFR19SRE1BX0dMT0JBTF9DT04pOwo+IAo+IFdpdGhvdXQgcmVzZXQsIHdoYXQgaGFw cGVuIHRvIGRyYW0gbW9kZT8gV2h5IGRpcmVjdCBsaW5rIG1vZGUgbmVlZCBub3QKPiB0aGlzIHJl c2V0Pwo+IAoKVGhlcmUgaXMgbm90aGluZyB0byBoYXBwZW4sIEkgd291bGQgcmVtb3ZlIGl0LgoK PiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgbXRrX3JkbWFfY29uZmlnKHN0cnVjdCBtdGtf ZGRwX2NvbXAgKmNvbXAsIHVuc2lnbmVkIGludCB3aWR0aCwKPiA+IEBAIC0xMjEsMTAgKzEyNywx OCBAQCBzdGF0aWMgdm9pZCBtdGtfcmRtYV9jb25maWcoc3RydWN0IG10a19kZHBfY29tcCAqY29t cCwgdW5zaWduZWQgaW50IHdpZHRoLAo+ID4gIAl1bnNpZ25lZCBpbnQgdGhyZXNob2xkOwo+ID4g IAl1bnNpZ25lZCBpbnQgcmVnOwo+ID4gIAlzdHJ1Y3QgbXRrX2Rpc3BfcmRtYSAqcmRtYSA9IGNv bXBfdG9fcmRtYShjb21wKTsKPiA+ICsJYm9vbCAqcmRtYV9tZW1vcnlfbW9kZSA9IGNvbXAtPmNv bXBfbW9kZTsKPiA+ICAKPiA+ICAJcmRtYV91cGRhdGVfYml0cyhjb21wLCBESVNQX1JFR19SRE1B X1NJWkVfQ09OXzAsIDB4ZmZmLCB3aWR0aCk7Cj4gPiAgCXJkbWFfdXBkYXRlX2JpdHMoY29tcCwg RElTUF9SRUdfUkRNQV9TSVpFX0NPTl8xLCAweGZmZmZmLCBoZWlnaHQpOwo+ID4gIAo+ID4gKwlp ZiAoKnJkbWFfbWVtb3J5X21vZGUgPT0gdHJ1ZSkgewo+ID4gKwkJcmRtYV91cGRhdGVfYml0cyhj b21wLCBESVNQX1JFR19SRE1BX1NJWkVfQ09OXzAsIDB4ZmYwMDAwLAo+ID4gKwkJCQkgTUFUUklY X0lOVF9NVFhfU0VMX0RFRkFVTFQpOwo+ID4gKwkJcmRtYV91cGRhdGVfYml0cyhjb21wLCBESVNQ X1JFR19SRE1BX0dMT0JBTF9DT04sCj4gPiArCQkJCSBSRE1BX01PREVfTUVNT1JZLCBSRE1BX01P REVfTUVNT1JZKTsKPiA+ICsJfQo+ID4gKwo+IAo+IEkgd291bGQgbGlrZSB0aGlzIHRvIGJlIGEg a2luZCBvZiAnbGF5ZXInIGNvbmZpZy4gSW4gc29tZSBTb0MsIG9uZSBsYXllcgo+IG9mIE9WTCBj b3VsZCBzd2l0Y2ggdG8gZGlyZWN0IGxpbmsgaW5wdXQgb3IgZHJhbSBpbnB1dC4gU28gSSB0aGlu ayBpdCdzCj4gYmV0dGVyIHRvIG1vdmUgdGhpcyBzZXR0aW5nIGludG8gc29tZSBsYXllciBpbnRl cmZhY2UuCj4gCj4gUmVnYXJkcywKPiBDSwo+IAoKSWYgbW92ZSBpdCB0byBsYXllcl9jb25maWcs IFJETUEgd291bGQgbm90IHRyaWdnZXIgaW50ZXJydXB0LgpJbiB0aGUgZnV0dXJlLCB3aGVuIGNt ZHEgcGF0Y2ggdXBzdHJlYW0gYW5kIGFjY2VwdGVkLCB0aGlzIHBhcnQgY2FuIG1vdmUKdG8gbGF5 ZXJfY29uZmlnLiAKClJlZ2FyZCwKU3R1Cgo+ID4gIAkvKgo+ID4gIAkgKiBFbmFibGUgRklGTyB1 bmRlcmZsb3cgc2luY2UgRFNJIGFuZCBEUEkgY2FuJ3QgYmUgYmxvY2tlZC4KPiA+ICAJICogS2Vl cCB0aGUgRklGTyBwc2V1ZG8gc2l6ZSByZXNldCBkZWZhdWx0IG9mIDggS2lCLiBTZXQgdGhlCj4g Cj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: stu.hsieh@mediatek.com (Stu Hsieh) Date: Thu, 2 Aug 2018 19:36:26 +0800 Subject: [PATCH v1 06/15] drm/mediatek: add memory mode for RDMA In-Reply-To: <1532486454.9280.12.camel@mtksdaap41> References: <1532420235-22268-1-git-send-email-stu.hsieh@mediatek.com> <1532420235-22268-7-git-send-email-stu.hsieh@mediatek.com> <1532486454.9280.12.camel@mtksdaap41> Message-ID: <1533209786.11190.60.camel@mtksdccf07> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, CK: On Wed, 2018-07-25 at 10:40 +0800, CK Hu wrote: > Hi, Stu: > > On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > > This patch add memory mode for RDMA > > > > If use RDMA to read data from memory, it should set memory mode to RDMA > > > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 16 +++++++++++++++- > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > [...] > > > static inline struct mtk_disp_rdma *comp_to_rdma(struct mtk_ddp_comp *comp) > > @@ -111,7 +116,8 @@ static void mtk_rdma_start(struct mtk_ddp_comp *comp) > > > > static void mtk_rdma_stop(struct mtk_ddp_comp *comp) > > { > > - rdma_update_bits(comp, DISP_REG_RDMA_GLOBAL_CON, RDMA_ENGINE_EN, 0); > > + writel(RDMA_SOFT_RESET, comp->regs + DISP_REG_RDMA_GLOBAL_CON); > > + writel(0, comp->regs + DISP_REG_RDMA_GLOBAL_CON); > > Without reset, what happen to dram mode? Why direct link mode need not > this reset? > There is nothing to happen, I would remove it. > > } > > > > static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > @@ -121,10 +127,18 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > unsigned int threshold; > > unsigned int reg; > > struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > > + bool *rdma_memory_mode = comp->comp_mode; > > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xfff, width); > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_1, 0xfffff, height); > > > > + if (*rdma_memory_mode == true) { > > + rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xff0000, > > + MATRIX_INT_MTX_SEL_DEFAULT); > > + rdma_update_bits(comp, DISP_REG_RDMA_GLOBAL_CON, > > + RDMA_MODE_MEMORY, RDMA_MODE_MEMORY); > > + } > > + > > I would like this to be a kind of 'layer' config. In some SoC, one layer > of OVL could switch to direct link input or dram input. So I think it's > better to move this setting into some layer interface. > > Regards, > CK > If move it to layer_config, RDMA would not trigger interrupt. In the future, when cmdq patch upstream and accepted, this part can move to layer_config. Regard, Stu > > /* > > * Enable FIFO underflow since DSI and DPI can't be blocked. > > * Keep the FIFO pseudo size reset default of 8 KiB. Set the > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E408C43142 for ; Thu, 2 Aug 2018 11:36:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F158214E0 for ; Thu, 2 Aug 2018 11:36:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F158214E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732295AbeHBN1S (ORCPT ); Thu, 2 Aug 2018 09:27:18 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:33029 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728767AbeHBN1S (ORCPT ); Thu, 2 Aug 2018 09:27:18 -0400 X-UUID: 73e2cb4ec47b468bbc38be9bf13ab8a2-20180802 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1083127647; Thu, 02 Aug 2018 19:36:27 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs03n2.mediatek.inc (172.21.101.182) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 2 Aug 2018 19:36:26 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Thu, 2 Aug 2018 19:36:26 +0800 Message-ID: <1533209786.11190.60.camel@mtksdccf07> Subject: Re: [PATCH v1 06/15] drm/mediatek: add memory mode for RDMA From: Stu Hsieh To: CK Hu CC: Philipp Zabel , David Airlie , Matthias Brugger , , , , , Date: Thu, 2 Aug 2018 19:36:26 +0800 In-Reply-To: <1532486454.9280.12.camel@mtksdaap41> References: <1532420235-22268-1-git-send-email-stu.hsieh@mediatek.com> <1532420235-22268-7-git-send-email-stu.hsieh@mediatek.com> <1532486454.9280.12.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK: On Wed, 2018-07-25 at 10:40 +0800, CK Hu wrote: > Hi, Stu: > > On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > > This patch add memory mode for RDMA > > > > If use RDMA to read data from memory, it should set memory mode to RDMA > > > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 16 +++++++++++++++- > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > [...] > > > static inline struct mtk_disp_rdma *comp_to_rdma(struct mtk_ddp_comp *comp) > > @@ -111,7 +116,8 @@ static void mtk_rdma_start(struct mtk_ddp_comp *comp) > > > > static void mtk_rdma_stop(struct mtk_ddp_comp *comp) > > { > > - rdma_update_bits(comp, DISP_REG_RDMA_GLOBAL_CON, RDMA_ENGINE_EN, 0); > > + writel(RDMA_SOFT_RESET, comp->regs + DISP_REG_RDMA_GLOBAL_CON); > > + writel(0, comp->regs + DISP_REG_RDMA_GLOBAL_CON); > > Without reset, what happen to dram mode? Why direct link mode need not > this reset? > There is nothing to happen, I would remove it. > > } > > > > static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > @@ -121,10 +127,18 @@ static void mtk_rdma_config(struct mtk_ddp_comp *comp, unsigned int width, > > unsigned int threshold; > > unsigned int reg; > > struct mtk_disp_rdma *rdma = comp_to_rdma(comp); > > + bool *rdma_memory_mode = comp->comp_mode; > > > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xfff, width); > > rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_1, 0xfffff, height); > > > > + if (*rdma_memory_mode == true) { > > + rdma_update_bits(comp, DISP_REG_RDMA_SIZE_CON_0, 0xff0000, > > + MATRIX_INT_MTX_SEL_DEFAULT); > > + rdma_update_bits(comp, DISP_REG_RDMA_GLOBAL_CON, > > + RDMA_MODE_MEMORY, RDMA_MODE_MEMORY); > > + } > > + > > I would like this to be a kind of 'layer' config. In some SoC, one layer > of OVL could switch to direct link input or dram input. So I think it's > better to move this setting into some layer interface. > > Regards, > CK > If move it to layer_config, RDMA would not trigger interrupt. In the future, when cmdq patch upstream and accepted, this part can move to layer_config. Regard, Stu > > /* > > * Enable FIFO underflow since DSI and DPI can't be blocked. > > * Keep the FIFO pseudo size reset default of 8 KiB. Set the > >