From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stu Hsieh Subject: Re: [PATCH v1 14/15] drm/mediatek: fixed the error value for add DSI1 in mutex Date: Thu, 2 Aug 2018 19:39:09 +0800 Message-ID: <1533209949.11190.63.camel@mtksdccf07> References: <1532420235-22268-1-git-send-email-stu.hsieh@mediatek.com> <1532420235-22268-15-git-send-email-stu.hsieh@mediatek.com> <1532495445.9280.22.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1532495445.9280.22.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: CK Hu Cc: srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIENLOgoKT24gV2VkLCAyMDE4LTA3LTI1IGF0IDEzOjEwICswODAwLCBDSyBIdSB3cm90ZToK PiBIaSwgU3R1Ogo+IAo+IAo+IE9uIFR1ZSwgMjAxOC0wNy0yNCBhdCAxNjoxNyArMDgwMCwgU3R1 IEhzaWVoIHdyb3RlOgo+ID4gVGhpcyBwYXRjaCBmaXhlZCB0aGUgZXJyb3IgdmFsdWUgZm9yIGFk ZCBEU0kxIGluIG11dGV4Cj4gPiAKPiAKPiBFbmdsaXNoIGlzIG5vdCBteSBtb3RoZXIgbGFuZ3Vh Z2UsIGJ1dCBzaG91bGQgaXQgYmUgJ2ZpeCcgcmF0aGVyIHRoYW4KPiAnZml4ZWQnPwo+IAo+IFJl Z2FyZHMsCj4gQ0sKPiAKT0sKClJlZ2FyZHMsClN0dQo+ID4gU2lnbmVkLW9mZi1ieTogU3R1IEhz aWVoIDxzdHUuaHNpZWhAbWVkaWF0ZWsuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19kcm1fZGRwLmMgfCAyICstCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9t dGtfZHJtX2RkcC5jCj4gPiBpbmRleCAzMjM5ZjIyNzg1ZmQuLmFjMDQ3ZmRiMWEyYiAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcC5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHAuYwo+ID4gQEAgLTQzNyw3ICs0 MzcsNyBAQCB2b2lkIG10a19kaXNwX211dGV4X2FkZF9jb21wKHN0cnVjdCBtdGtfZGlzcF9tdXRl eCAqbXV0ZXgsCj4gPiAgCQlyZWcgPSBNVVRFWF9TT0ZfRFNJMDsKPiA+ICAJCWJyZWFrOwo+ID4g IAljYXNlIEREUF9DT01QT05FTlRfRFNJMToKPiA+IC0JCXJlZyA9IE1VVEVYX1NPRl9EU0kwOwo+ ID4gKwkJcmVnID0gTVVURVhfU09GX0RTSTE7Cj4gPiAgCQlicmVhazsKPiA+ICAJY2FzZSBERFBf Q09NUE9ORU5UX0RTSTI6Cj4gPiAgCQlyZWcgPSBNVVRFWF9TT0ZfRFNJMjsKPiAKPiAKCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: stu.hsieh@mediatek.com (Stu Hsieh) Date: Thu, 2 Aug 2018 19:39:09 +0800 Subject: [PATCH v1 14/15] drm/mediatek: fixed the error value for add DSI1 in mutex In-Reply-To: <1532495445.9280.22.camel@mtksdaap41> References: <1532420235-22268-1-git-send-email-stu.hsieh@mediatek.com> <1532420235-22268-15-git-send-email-stu.hsieh@mediatek.com> <1532495445.9280.22.camel@mtksdaap41> Message-ID: <1533209949.11190.63.camel@mtksdccf07> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, CK: On Wed, 2018-07-25 at 13:10 +0800, CK Hu wrote: > Hi, Stu: > > > On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > > This patch fixed the error value for add DSI1 in mutex > > > > English is not my mother language, but should it be 'fix' rather than > 'fixed'? > > Regards, > CK > OK Regards, Stu > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > index 3239f22785fd..ac047fdb1a2b 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > @@ -437,7 +437,7 @@ void mtk_disp_mutex_add_comp(struct mtk_disp_mutex *mutex, > > reg = MUTEX_SOF_DSI0; > > break; > > case DDP_COMPONENT_DSI1: > > - reg = MUTEX_SOF_DSI0; > > + reg = MUTEX_SOF_DSI1; > > break; > > case DDP_COMPONENT_DSI2: > > reg = MUTEX_SOF_DSI2; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657BEC43142 for ; Thu, 2 Aug 2018 11:39:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20277214E0 for ; Thu, 2 Aug 2018 11:39:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20277214E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732314AbeHBNaB (ORCPT ); Thu, 2 Aug 2018 09:30:01 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:14571 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1732153AbeHBNaB (ORCPT ); Thu, 2 Aug 2018 09:30:01 -0400 X-UUID: d85b8e7963aa4bc293870d2f0a195b30-20180802 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 433779484; Thu, 02 Aug 2018 19:39:11 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Thu, 2 Aug 2018 19:39:09 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1210.3 via Frontend Transport; Thu, 2 Aug 2018 19:39:09 +0800 Message-ID: <1533209949.11190.63.camel@mtksdccf07> Subject: Re: [PATCH v1 14/15] drm/mediatek: fixed the error value for add DSI1 in mutex From: Stu Hsieh To: CK Hu CC: Philipp Zabel , David Airlie , Matthias Brugger , , , , , Date: Thu, 2 Aug 2018 19:39:09 +0800 In-Reply-To: <1532495445.9280.22.camel@mtksdaap41> References: <1532420235-22268-1-git-send-email-stu.hsieh@mediatek.com> <1532420235-22268-15-git-send-email-stu.hsieh@mediatek.com> <1532495445.9280.22.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, CK: On Wed, 2018-07-25 at 13:10 +0800, CK Hu wrote: > Hi, Stu: > > > On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > > This patch fixed the error value for add DSI1 in mutex > > > > English is not my mother language, but should it be 'fix' rather than > 'fixed'? > > Regards, > CK > OK Regards, Stu > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > index 3239f22785fd..ac047fdb1a2b 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > > @@ -437,7 +437,7 @@ void mtk_disp_mutex_add_comp(struct mtk_disp_mutex *mutex, > > reg = MUTEX_SOF_DSI0; > > break; > > case DDP_COMPONENT_DSI1: > > - reg = MUTEX_SOF_DSI0; > > + reg = MUTEX_SOF_DSI1; > > break; > > case DDP_COMPONENT_DSI2: > > reg = MUTEX_SOF_DSI2; > >