From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Verma, Vishal L" Subject: Re: [PATCH] ACPI: nfit: return -ENODEV if fail to find NFIT at startup Date: Fri, 3 Aug 2018 17:11:41 +0000 Message-ID: <1533316299.8557.71.camel@intel.com> References: <1533289198-11400-1-git-send-email-oceanhehy@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1533289198-11400-1-git-send-email-oceanhehy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "oceanhehy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "Jiang, Dave" , "lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org" Cc: "linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hehy1-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org" List-Id: linux-acpi@vger.kernel.org On Fri, 2018-08-03 at 05:39 -0400, Ocean He wrote: > From: Ocean He > > In the beginning of acpi_nfit_add, if fail to find NFIT table then > should > return -ENODEV, instead of 0. > > Signed-off-by: Ocean He > --- > drivers/acpi/nfit/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 7c47900..1790d7c 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -3355,7 +3355,7 @@ static int acpi_nfit_add(struct acpi_device > *adev) > if (ACPI_FAILURE(status)) { > /* This is ok, we could have an nvdimm hotplugged > later */ > dev_dbg(dev, "failed to find NFIT at startup\n"); > - return 0; > + return -ENODEV; Hm, the comment directly above this says this is ok.. Has this caused any problems in practice? > } > > rc = devm_add_action_or_reset(dev, acpi_nfit_put_table, > tbl); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C5B44210D8528 for ; Fri, 3 Aug 2018 10:11:48 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [PATCH] ACPI: nfit: return -ENODEV if fail to find NFIT at startup Date: Fri, 3 Aug 2018 17:11:41 +0000 Message-ID: <1533316299.8557.71.camel@intel.com> References: <1533289198-11400-1-git-send-email-oceanhehy@gmail.com> In-Reply-To: <1533289198-11400-1-git-send-email-oceanhehy@gmail.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "ross.zwisler@linux.intel.com" , "oceanhehy@gmail.com" , "Jiang, Dave" , "lenb@kernel.org" , "rjw@rjwysocki.net" Cc: "linux-acpi@vger.kernel.org" , "hehy1@lenovo.com" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: On Fri, 2018-08-03 at 05:39 -0400, Ocean He wrote: > From: Ocean He > > In the beginning of acpi_nfit_add, if fail to find NFIT table then > should > return -ENODEV, instead of 0. > > Signed-off-by: Ocean He > --- > drivers/acpi/nfit/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 7c47900..1790d7c 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -3355,7 +3355,7 @@ static int acpi_nfit_add(struct acpi_device > *adev) > if (ACPI_FAILURE(status)) { > /* This is ok, we could have an nvdimm hotplugged > later */ > dev_dbg(dev, "failed to find NFIT at startup\n"); > - return 0; > + return -ENODEV; Hm, the comment directly above this says this is ok.. Has this caused any problems in practice? > } > > rc = devm_add_action_or_reset(dev, acpi_nfit_put_table, > tbl); _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F2CDC28CF6 for ; Fri, 3 Aug 2018 17:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C34A82177F for ; Fri, 3 Aug 2018 17:11:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C34A82177F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729733AbeHCTI7 (ORCPT ); Fri, 3 Aug 2018 15:08:59 -0400 Received: from mga05.intel.com ([192.55.52.43]:29517 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727376AbeHCTI7 (ORCPT ); Fri, 3 Aug 2018 15:08:59 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2018 10:11:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,439,1526367600"; d="scan'208";a="245797206" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 03 Aug 2018 10:11:42 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 3 Aug 2018 10:11:42 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.40]) by FMSMSX126.amr.corp.intel.com ([169.254.1.163]) with mapi id 14.03.0319.002; Fri, 3 Aug 2018 10:11:41 -0700 From: "Verma, Vishal L" To: "Williams, Dan J" , "ross.zwisler@linux.intel.com" , "oceanhehy@gmail.com" , "Jiang, Dave" , "lenb@kernel.org" , "rjw@rjwysocki.net" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "linux-acpi@vger.kernel.org" , "hehy1@lenovo.com" Subject: Re: [PATCH] ACPI: nfit: return -ENODEV if fail to find NFIT at startup Thread-Topic: [PATCH] ACPI: nfit: return -ENODEV if fail to find NFIT at startup Thread-Index: AQHUKw9W31TJeaGVuEmcv5V4mRjBQqSuuU+A Date: Fri, 3 Aug 2018 17:11:41 +0000 Message-ID: <1533316299.8557.71.camel@intel.com> References: <1533289198-11400-1-git-send-email-oceanhehy@gmail.com> In-Reply-To: <1533289198-11400-1-git-send-email-oceanhehy@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.232.112.133] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQpPbiBGcmksIDIwMTgtMDgtMDMgYXQgMDU6MzkgLTA0MDAsIE9jZWFuIEhlIHdyb3RlOg0KPiBG cm9tOiBPY2VhbiBIZSA8aGVoeTFAbGVub3ZvLmNvbT4NCj4gDQo+IEluIHRoZSBiZWdpbm5pbmcg b2YgYWNwaV9uZml0X2FkZCwgaWYgZmFpbCB0byBmaW5kIE5GSVQgdGFibGUgdGhlbg0KPiBzaG91 bGQNCj4gcmV0dXJuIC1FTk9ERVYsIGluc3RlYWQgb2YgMC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6 IE9jZWFuIEhlIDxoZWh5MUBsZW5vdm8uY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvYWNwaS9uZml0 L2NvcmUuYyB8IDIgKy0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl dGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYWNwaS9uZml0L2NvcmUuYyBiL2Ry aXZlcnMvYWNwaS9uZml0L2NvcmUuYw0KPiBpbmRleCA3YzQ3OTAwLi4xNzkwZDdjIDEwMDY0NA0K PiAtLS0gYS9kcml2ZXJzL2FjcGkvbmZpdC9jb3JlLmMNCj4gKysrIGIvZHJpdmVycy9hY3BpL25m aXQvY29yZS5jDQo+IEBAIC0zMzU1LDcgKzMzNTUsNyBAQCBzdGF0aWMgaW50IGFjcGlfbmZpdF9h ZGQoc3RydWN0IGFjcGlfZGV2aWNlDQo+ICphZGV2KQ0KPiAgCWlmIChBQ1BJX0ZBSUxVUkUoc3Rh dHVzKSkgew0KPiAgCQkvKiBUaGlzIGlzIG9rLCB3ZSBjb3VsZCBoYXZlIGFuIG52ZGltbSBob3Rw bHVnZ2VkDQo+IGxhdGVyICovDQo+ICAJCWRldl9kYmcoZGV2LCAiZmFpbGVkIHRvIGZpbmQgTkZJ VCBhdCBzdGFydHVwXG4iKTsNCj4gLQkJcmV0dXJuIDA7DQo+ICsJCXJldHVybiAtRU5PREVWOw0K DQpIbSwgdGhlIGNvbW1lbnQgZGlyZWN0bHkgYWJvdmUgdGhpcyBzYXlzIHRoaXMgaXMgb2suLg0K SGFzIHRoaXMgY2F1c2VkIGFueSBwcm9ibGVtcyBpbiBwcmFjdGljZT8NCg0KPiAgCX0NCj4gIA0K PiAgCXJjID0gZGV2bV9hZGRfYWN0aW9uX29yX3Jlc2V0KGRldiwgYWNwaV9uZml0X3B1dF90YWJs ZSwNCj4gdGJsKTsNCg==