From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EB3B9210D8528 for ; Fri, 3 Aug 2018 10:13:40 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [PATCH] libnvdimm, bus: check id immediately following ida_simple_get Date: Fri, 3 Aug 2018 17:13:39 +0000 Message-ID: <1533316417.8557.72.camel@intel.com> References: <1533298113-17495-1-git-send-email-oceanhehy@gmail.com> In-Reply-To: <1533298113-17495-1-git-send-email-oceanhehy@gmail.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" , "ross.zwisler@linux.intel.com" , "oceanhehy@gmail.com" , "Jiang, Dave" Cc: "hehy1@lenovo.com" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: On Fri, 2018-08-03 at 08:08 -0400, Ocean He wrote: > From: Ocean He > > The id check was not executed immediately following ida_simple_get. > Just > change the codes position, without function change. > > Signed-off-by: Ocean He > --- > drivers/nvdimm/bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good, feel free to add Reviewed-by: Vishal Verma > > diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c > index 27902a8..ab28e7c 100644 > --- a/drivers/nvdimm/bus.c > +++ b/drivers/nvdimm/bus.c > @@ -350,12 +350,12 @@ struct nvdimm_bus *nvdimm_bus_register(struct > device *parent, > INIT_LIST_HEAD(&nvdimm_bus->mapping_list); > init_waitqueue_head(&nvdimm_bus->probe_wait); > nvdimm_bus->id = ida_simple_get(&nd_ida, 0, 0, GFP_KERNEL); > - mutex_init(&nvdimm_bus->reconfig_mutex); > - badrange_init(&nvdimm_bus->badrange); > if (nvdimm_bus->id < 0) { > kfree(nvdimm_bus); > return NULL; > } > + mutex_init(&nvdimm_bus->reconfig_mutex); > + badrange_init(&nvdimm_bus->badrange); > nvdimm_bus->nd_desc = nd_desc; > nvdimm_bus->dev.parent = parent; > nvdimm_bus->dev.release = nvdimm_bus_release; _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24035C28CF6 for ; Fri, 3 Aug 2018 17:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2FD62177F for ; Fri, 3 Aug 2018 17:13:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2FD62177F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729830AbeHCTKv (ORCPT ); Fri, 3 Aug 2018 15:10:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:28704 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727809AbeHCTKv (ORCPT ); Fri, 3 Aug 2018 15:10:51 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2018 10:13:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,439,1526367600"; d="scan'208";a="80307029" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 03 Aug 2018 10:13:39 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 3 Aug 2018 10:13:39 -0700 Received: from fmsmsx113.amr.corp.intel.com ([169.254.13.40]) by FMSMSX151.amr.corp.intel.com ([169.254.7.207]) with mapi id 14.03.0319.002; Fri, 3 Aug 2018 10:13:39 -0700 From: "Verma, Vishal L" To: "Williams, Dan J" , "ross.zwisler@linux.intel.com" , "oceanhehy@gmail.com" , "Jiang, Dave" CC: "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "hehy1@lenovo.com" Subject: Re: [PATCH] libnvdimm, bus: check id immediately following ida_simple_get Thread-Topic: [PATCH] libnvdimm, bus: check id immediately following ida_simple_get Thread-Index: AQHUKyLEcZHHgxcVEUuunj+xgF7dd6SuubSA Date: Fri, 3 Aug 2018 17:13:39 +0000 Message-ID: <1533316417.8557.72.camel@intel.com> References: <1533298113-17495-1-git-send-email-oceanhehy@gmail.com> In-Reply-To: <1533298113-17495-1-git-send-email-oceanhehy@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.232.112.133] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQpPbiBGcmksIDIwMTgtMDgtMDMgYXQgMDg6MDggLTA0MDAsIE9jZWFuIEhlIHdyb3RlOg0KPiBG cm9tOiBPY2VhbiBIZSA8aGVoeTFAbGVub3ZvLmNvbT4NCj4gDQo+IFRoZSBpZCBjaGVjayB3YXMg bm90IGV4ZWN1dGVkIGltbWVkaWF0ZWx5IGZvbGxvd2luZyBpZGFfc2ltcGxlX2dldC4NCj4gSnVz dA0KPiBjaGFuZ2UgdGhlIGNvZGVzIHBvc2l0aW9uLCB3aXRob3V0IGZ1bmN0aW9uIGNoYW5nZS4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IE9jZWFuIEhlIDxoZWh5MUBsZW5vdm8uY29tPg0KPiAtLS0N Cj4gIGRyaXZlcnMvbnZkaW1tL2J1cy5jIHwgNCArKy0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KDQpMb29rcyBnb29kLCBmZWVsIGZyZWUgdG8g YWRkDQpSZXZpZXdlZC1ieTogVmlzaGFsIFZlcm1hIDx2aXNoYWwubC52ZXJtYUBpbnRlbC5jb20+ DQoNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL252ZGltbS9idXMuYyBiL2RyaXZlcnMvbnZk aW1tL2J1cy5jDQo+IGluZGV4IDI3OTAyYTguLmFiMjhlN2MgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl cnMvbnZkaW1tL2J1cy5jDQo+ICsrKyBiL2RyaXZlcnMvbnZkaW1tL2J1cy5jDQo+IEBAIC0zNTAs MTIgKzM1MCwxMiBAQCBzdHJ1Y3QgbnZkaW1tX2J1cyAqbnZkaW1tX2J1c19yZWdpc3RlcihzdHJ1 Y3QNCj4gZGV2aWNlICpwYXJlbnQsDQo+ICAJSU5JVF9MSVNUX0hFQUQoJm52ZGltbV9idXMtPm1h cHBpbmdfbGlzdCk7DQo+ICAJaW5pdF93YWl0cXVldWVfaGVhZCgmbnZkaW1tX2J1cy0+cHJvYmVf d2FpdCk7DQo+ICAJbnZkaW1tX2J1cy0+aWQgPSBpZGFfc2ltcGxlX2dldCgmbmRfaWRhLCAwLCAw LCBHRlBfS0VSTkVMKTsNCj4gLQltdXRleF9pbml0KCZudmRpbW1fYnVzLT5yZWNvbmZpZ19tdXRl eCk7DQo+IC0JYmFkcmFuZ2VfaW5pdCgmbnZkaW1tX2J1cy0+YmFkcmFuZ2UpOw0KPiAgCWlmIChu dmRpbW1fYnVzLT5pZCA8IDApIHsNCj4gIAkJa2ZyZWUobnZkaW1tX2J1cyk7DQo+ICAJCXJldHVy biBOVUxMOw0KPiAgCX0NCj4gKwltdXRleF9pbml0KCZudmRpbW1fYnVzLT5yZWNvbmZpZ19tdXRl eCk7DQo+ICsJYmFkcmFuZ2VfaW5pdCgmbnZkaW1tX2J1cy0+YmFkcmFuZ2UpOw0KPiAgCW52ZGlt bV9idXMtPm5kX2Rlc2MgPSBuZF9kZXNjOw0KPiAgCW52ZGltbV9idXMtPmRldi5wYXJlbnQgPSBw YXJlbnQ7DQo+ICAJbnZkaW1tX2J1cy0+ZGV2LnJlbGVhc2UgPSBudmRpbW1fYnVzX3JlbGVhc2U7 DQo=